https://bugzilla.wikimedia.org/show_bug.cgi?id=61578
Bug ID: 61578
Summary: Flow: update Permalink browser test for code changes
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: Unprioritized
Component: Flow
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: sp...@wikimedia.org
CC: cmcma...@wikimedia.org, ebernhard...@wikimedia.org,
mpinc...@wikimedia.org, pandiculat...@gmail.com,
sp...@wikimedia.org
Web browser: ---
Mobile Platform: ---
The Actions menu Permalink test is failing with
timed out after 5 seconds, waiting for {:class=>"flow-topic-reply-submit",
:tag_name=>"button"} to become present (Watir::Wait::TimeoutError)
but commit c927f938 eliminated the specific class for the [Reply] button for a
top-level comment on a a topic.
However, simply changing this to "flow-reply-submit" doesn't work, because this
also matches the Reply button in all the hidden replies to existing comments
that precede the "Comment on xyz" box.
In general, the current PageObject elements only work because the first
matching element in the Flow board is probably the one you want, but since Flow
boards are made of dozens of similar items, it's fragile. Conceptually Flow
page object selectors ought to "point at" a particular topic or post on a page,
and then select elements within that.
jQuery selectors can fix this six ways to Sunday:
$( '.flow-reply-submit:visible' )
$( '.flow-reply-submit:last' )
$( 'form.flow-topic-reply-form .flow-reply-submit' )
etc. Mapping these to PageObject/cheezy whatever is... hazy.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
