[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

Lydia Pintscher  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

TMg  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 CC||mr.h...@gmx.de
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

--- Comment #6 from Gerrit Notification Bot  ---
Change 115310 merged by jenkins-bot:
Wikibase parsing of diff=... parameter was different from core

https://gerrit.wikimedia.org/r/115310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

--- Comment #5 from Gerrit Notification Bot  ---
Change 115310 had a related patch set uploaded by Thiemo Mättig (WMDE):
Wikibase parsing of diff=... parameter was different from core

https://gerrit.wikimedia.org/r/115310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

--- Comment #4 from Lydia Pintscher  ---
diff=0 compares to whatever is the newest revision. It is in email
notifications for changes for example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

--- Comment #3 from Thiemo Mättig  ---
(In reply to Lydia Pintscher from comment #2)
> https://www.wikidata.org/w/?title=Q5089124&diff=0&oldid=97248895
> is one.

Huh, where does the diff=0 come from? Do you typed this?
https://www.wikidata.org/w/?title=Q5089124&diff=cur&oldid=97248895 does work as
expected.

The core code that checks and parses the diff and oldid parameters is a bit
strange. There is no comparison with a constant "cur" in core. Instead it
checks for "prev", "next" and numbers and treads everything else (even an empty
...&diff&... with no equal sign) as "cur". Example:
https://www.wikidata.org/w/?diff&oldid=104570626

For some reason all this does not work in Wikibase. In my opinion it should be
made the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

--- Comment #2 from Lydia Pintscher  ---
https://www.wikidata.org/w/index.php?title=Q5089124&diff=0&oldid=97248895 is
one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

--- Comment #1 from Thiemo Mättig  ---
I fail to reproduce this. Do you have a few example URLs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 61749] viewing a diff does not show the latest revision below the diff

2014-02-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=61749

Lydia Pintscher  changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 Whiteboard||backlog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l