[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

--- Comment #6 from ryasm...@wikimedia.org ---
Verified the fix in production:
https://en.wikipedia.org/wiki/User:RYasmeen_(WMF)/sandbox?veaction=edit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

--- Comment #5 from ryasm...@wikimedia.org ---
Verified the fix in test2 environment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 116754 merged by jenkins-bot:
Store previous range in breakpoint for undo

https://gerrit.wikimedia.org/r/116754

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

James Forrester jforres...@wikimedia.org changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |VE-deploy-2014-03-06

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

--- Comment #4 from ryasm...@wikimedia.org ---
Verified the fix in Betalabs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

Ed Sanders esand...@wikimedia.org changed:

   What|Removed |Added

 CC||esand...@wikimedia.org
   Assignee|da...@sheetmusic.org.uk |esand...@wikimedia.org
Summary|VisualEditor: Cannot go to  |VisualEditor: Undoing
   |a newline after undoing a   |creation of empty heading
   |heading format and Uncaught |places cursor at invalid
   |Error: Inserted data is |offset
   |trying to close the root|
   |node (at index 0) appears   |
   |in the console  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

Ed Sanders esand...@wikimedia.org changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com
  Component|ContentEditable |Data Model

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

--- Comment #1 from Ed Sanders esand...@wikimedia.org ---
In standalone demo empty.html

1. Turn on 'get range on change', observe [1,1]
2. Create heading, observe [1,1]
3. Undo, observe [2,2]

Expected: Range is still [1,1] after undo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 62088] VisualEditor: Undoing creation of empty heading places cursor at invalid offset

2014-03-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=62088

--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 116754 had a related patch set uploaded by Esanders:
Use previous breakpoint's range when undoing

https://gerrit.wikimedia.org/r/116754

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l