[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 122862 merged by jenkins-bot: Prevent passing information between #invokes using math.random https://gerrit.wikimedia.org/r/122862 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 Jackmcbarn jackmcbarn+w...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||jackmcbarn+w...@gmail.com Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 --- Comment #3 from Brad Jorsch bjor...@wikimedia.org --- (In reply to orlodrim from comment #2) After thinking about it again, this probably requires some extra care in case of nested modules invocations. Otherwise, the random generator might be unexpectedly reset when frame:expandTemplate() is called, for instance. Good catch! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 122862 had a related patch set uploaded by Anomie: Prevent passing information between #invokes using math.random https://gerrit.wikimedia.org/r/122862 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |bjor...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 --- Comment #2 from orlod...@wiki256.net --- After thinking about it again, this probably requires some extra care in case of nested modules invocations. Otherwise, the random generator might be unexpectedly reset when frame:expandTemplate() is called, for instance. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62291] The seed for math.random() should be reset before #invoke
https://bugzilla.wikimedia.org/show_bug.cgi?id=62291 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Keywords||easy --- Comment #1 from Brad Jorsch bjor...@wikimedia.org --- Since math.random is supposed to be an interface to the C rand() function,[1] and that function is explicitly defined as being seeded with 1 if srand (math.randomseed) hasn't been called,[2] I'd suggest fixing this by calling math.randomseed( 1 ) at the top of mw.executeFunction() (in engines/LuaCommon/lualib/mw.lua). If no one objects in a reasonable period of time (and no one beats me to it), I'll submit a Gerrit change to do this at some point in the not-too-distant future. [1]: http://www.lua.org/manual/5.1/manual.html#pdf-math.random [2]: http://manpages.debian.net/cgi-bin/man.cgi?query=randsektion=3format=html -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
