[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119128 merged by jenkins-bot: Fix navigation issue with alt+esc on Ubuntu/Unity. https://gerrit.wikimedia.org/r/119128 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||gdu...@wikimedia.org Resolution|--- |FIXED --- Comment #7 from Gilles Dubuc gdu...@wikimedia.org --- Needs a mingle card -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 --- Comment #8 from Tisza Gergő gti...@wikimedia.org --- https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/365 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 119128 had a related patch set uploaded by Gergő Tisza: Fix navigation issue with alt+esc on Ubuntu/Unity. https://gerrit.wikimedia.org/r/119128 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 Sorawee Porncharoenwase nullzero.f...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||nullzero.f...@gmail.com Resolution|--- |WONTFIX --- Comment #1 from Sorawee Porncharoenwase nullzero.f...@gmail.com --- This one is by design (// Close the interface all the way if the user pressed 'esc'). However, I agree that bug: 62578 -- exit fullscreen by clicking the link provided by the browser -- should be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- --- Comment #2 from Tisza Gergő gti...@wikimedia.org --- This is definitely not by design. Pressing Esc should close the lightbox when the user presses it with that intent; it should not close the lightbox when it is pressed as part of some completely different interaction which is not even related to the browser. Granted, this is really a bug in Unity (that Esc press should not pass through to the browser in the first place), but it is an easy fix, just check for any modifier keys. Note that the Close the interface all the way if the user pressed 'esc' comment refers to closing the lightbox when it is fullscreen mode and the user presses Esc (the browser default would be to just un-fullscreen). IMO that is a bug too, as it is contrary to user expectations and standard browser behavior, but that is related to bug 62578. This bug is not related to fullscreen at all. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 --- Comment #3 from Tisza Gergő gti...@wikimedia.org --- Ugh, I left out a reproduction step, no wonder it does not make sense. This is the correct version: Steps to reproduce (on Chrome 33/Ubuntu 13 with Unity): 1. open lightbox 2. press and hold Alt 3. press Tab (opens task selection interface of the OS/window manager) 4. press Esc 5. release Alt -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62580] Lightbox exits when Esc is pressed with a modifier key
https://bugzilla.wikimedia.org/show_bug.cgi?id=62580 --- Comment #4 from Sorawee Porncharoenwase nullzero.f...@gmail.com --- Ohhh I'm so sorry. I misread. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
