[Bug 62663] Invalid extension attribute encoding
https://bugzilla.wikimedia.org/show_bug.cgi?id=62663 ssas...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED Assignee|gwi...@wikimedia.org|ssas...@wikimedia.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62663] Invalid extension attribute encoding
https://bugzilla.wikimedia.org/show_bug.cgi?id=62663 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118784 merged by jenkins-bot: (Bug 62663) Temp fix for handling non-string extension attribute values https://gerrit.wikimedia.org/r/118784 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62663] Invalid extension attribute encoding
https://bugzilla.wikimedia.org/show_bug.cgi?id=62663 --- Comment #1 from C. Scott Ananian canan...@wikimedia.org --- (Bug 62664 is for WTS crashing -- it shouldn't crash, even if the input is bogus.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62663] Invalid extension attribute encoding
https://bugzilla.wikimedia.org/show_bug.cgi?id=62663 --- Comment #2 from ssas...@wikimedia.org --- Known issue. We dont support templated attributes for extensions. From ext.core.ExtensionHandler.js: -- // SSS FIXME: We seem to have a problem on our hands here. // // AttributeExpander runs after ExtensionHandler which means // the native handlers will not receive fully expanded tokens. // // In the case of Cite.ref and Cite.references, this is not an issue // since the final processing takes place in the DOM PP phase, // by which time the marker tokens would have had everything expanded. // But, this may not be true for other exensions. // // So, we wont be able to robustly support templated ext. attributes // without a fix for this since attribute values might be ext-generated // and ext-attribute values might be templated. // // The fix might require breaking this cycle by expliclitly-expanding // ext-attribute-values here in a new pipeline. TO BE DONE. -- We use the same technique for any extension attributes that is not a plain string (which nbsp; is not). Perhaps we should at least forcibly convert the tokens to string which can at least handle the common case of entities in attribute values. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62663] Invalid extension attribute encoding
https://bugzilla.wikimedia.org/show_bug.cgi?id=62663 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62663] Invalid extension attribute encoding
https://bugzilla.wikimedia.org/show_bug.cgi?id=62663 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 118784 had a related patch set uploaded by Subramanya Sastry: (Bug 62663) Temp fix for handling non-string extension attribute values https://gerrit.wikimedia.org/r/118784 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l