[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Bartosz Dziewoński changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||matma@gmail.com Resolution|--- |FIXED --- Comment #13 from Bartosz Dziewoński --- This looks fixed, too. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #12 from Gerrit Notification Bot --- Change 125577 merged by jenkins-bot: Position hovercard according to mouse position https://gerrit.wikimedia.org/r/125577 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Prateek Saxena changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Prateek Saxena changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #11 from Prateek Saxena --- (In reply to kipod from comment #9) > i have a small concern: the event that triggers the popup can be > either "mouseenter" or "focus" Thanks for pointing this out, I'll update the patch. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Quiddity changed: What|Removed |Added CC||pandiculat...@gmail.com --- Comment #10 from Quiddity --- (In reply to Prateek Saxena from comment #5) [..] > time. If we move the hovercard along with mouse movement it'll become like > the sample that Dan has shown during the meeting - is that something we > want? - I don't. We definitely don't want it to move-around once visible. (Eg. Hovering on the items in the table lower down on this page: http://www.wowhead.com/items ) Because that's annoying, and it makes it impossible to click the popup! But the way that Navpopups does it, would be fine, and solve this bug. (It opens the popup wherever the mouse comes-to-rest, and ignores subsequent movements as long as the mouse is still over the link or the popup.) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #9 from kipod --- (In reply to Vibha Bamba from comment #8) > Prateek, any pending concerns here? i have a small concern: the event that triggers the popup can be either "mouseenter" or "focus". now, "focus" events do not contain viable "pageX" and "pageY" fields, so it may be better to do something like: offsetTop = (event.type == 'mouseenter' ? event.pageY + 20 : $el.offset().top + $el.height() + 9); and similarly for offsetLeft. no? peace. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #8 from Vibha Bamba --- Prateek, any pending concerns here? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #7 from kipod --- (In reply to Prateek Saxena from comment #5) > The issue with this approach is that sometimes the hovercard will collide > with the link. This will happen if the mouse entered the link from the top. > > The event gets triggered as soon as the mouse enters the link and that > position is taken for placement, the mouse might have moved in this much > time. If we move the hovercard along with mouse movement it'll become like > the sample that Dan has shown during the meeting - is that something we > want? - I don't. since the whole card serves as a link, obscuring the link does not seem like such a problem to me. i think this is the correct behavior, since we have no control over the element: it can be a very ling title, that spans the whole line, and of course, when the link gets word-wrapped, there is no way to place the card based on the element location that will work as expected in all cases (remember that browser's tooltip are poped relative to the mouse pointer). if this seems critical, it should be easy enough to take the element location into consideration and make a slight adjustment to try and not obscure the element, but the location should be based the mouse pointer and not the element. peace. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #6 from Prateek Saxena --- Created attachment 15091 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15091&action=edit fixedissue -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #5 from Prateek Saxena --- The issue with this approach is that sometimes the hovercard will collide with the link. This will happen if the mouse entered the link from the top. The event gets triggered as soon as the mouse enters the link and that position is taken for placement, the mouse might have moved in this much time. If we move the hovercard along with mouse movement it'll become like the sample that Dan has shown during the meeting - is that something we want? - I don't. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #4 from Gerrit Notification Bot --- Change 125577 had a related patch set uploaded by Prtksxna: Position hovercard according to mouse position https://gerrit.wikimedia.org/r/125577 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 --- Comment #3 from kipod --- (In reply to Vibha Bamba from comment #2) > Agree, Discussed with Prateek. i posted on [[mw:Extension talk:Popups]] [1] an outline of how i think this could/should be implemented. peace. __ hope this link works - otherwise treat it as text: "Extension talk:Popups: on mw wiki. no "preview" on bugzilla... -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Vibha Bamba changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |psax...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Vibha Bamba changed: What|Removed |Added CC||vba...@wikimedia.org --- Comment #2 from Vibha Bamba --- Agree, Discussed with Prateek. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 kipod changed: What|Removed |Added CC||fur.hew...@gmail.com --- Comment #1 from kipod --- the solution is simple: display the card based on mouse location rather than the location of the element that triggered it. there are other reasons for this: e.g., one might want to create a card for large elements (say, hovercard for an image), and the expectation is that the card will be near the mouse pointer, not fixed based on element location, which may be pretty far from the mouse for large element. btw - this is the way browsers display tooltips: if you have an image tooltip, it will show relative to the mouse, not to the image, so doing it the way i describe is meeting users' expectations. peace. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63159] Hovercards: Incorrect card placement for links with a line break
https://bugzilla.wikimedia.org/show_bug.cgi?id=63159 Dan Garry changed: What|Removed |Added CC||dga...@wikimedia.org Summary|Hovercards: Incorrect |Hovercards: Incorrect card |placement for links with a |placement for links with a |line break |line break -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
