https://bugzilla.wikimedia.org/show_bug.cgi?id=63310
Bug ID: 63310
Summary: Callers of ResourceLoader::getModule should check for
null return values
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: ResourceLoader
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: o...@wikimedia.org
CC: krinklem...@gmail.com, roan.katt...@gmail.com,
tpars...@wikimedia.org
Web browser: ---
Mobile Platform: ---
As a rule, callers of ResourceLoader::getModule() in
includes/resourceloader/ResourceLoader.php do not guard against a null return
value, and simply assume it is a ResourceLoaderModule object.
Exceptions on attempts to call methods on non-objects are the current
(superficial) cause of missing CSS / JS on
<http://en.hhvm.beta.wmflabs.org/wiki/Main_Page>. The deeper cause is probably
that en.hhvm.beta.wmflabs.org and en.wikipedia.beta.wmflabs.org share the same
DB but load a different set of extensions. Regardless, if it is possible for
ResourceLoader::getModule to return null, callers should check for it and react
appropriately.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
