https://bugzilla.wikimedia.org/show_bug.cgi?id=63322
Bug ID: 63322
Summary: ec2id puppet fact can yield some arbitrary HTML
Product: Wikimedia Labs
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Infrastructure
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: has...@free.fr
CC: abog...@wikimedia.org, rlan...@gmail.com
Web browser: ---
Mobile Platform: ---
I found out deployment-salt.eqiad.wmflabs puppet master got broken. Looking at
./puppet.conf and ./puppet.conf.d/10-self.conf I noticed the certname = fields
had some HTML such as:
<html>
<title>error 500</title>
blah some error message
Which ... break puppet!
Our factor in modules/base/lib/facter/ec2id.rb has no error handling:
Facter::Util::Resolution.exec("curl
http://169.254.169.254/1.0/meta-data/instance-id 2> /dev/null").chomp
Whenever the executed commands has an error it should bails out. Hopefully
curl exit with non 0 whenever it receives a 500.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
