https://bugzilla.wikimedia.org/show_bug.cgi?id=63424
Bug ID: 63424
Summary: Resolve "wrong and broken code" that's invoking
Title::newFromURL
Product: MediaWiki
Version: 1.23-git
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Unprioritized
Component: General/Unknown
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: dan...@danielnorton.com
Web browser: ---
Mobile Platform: ---
The comments to Title::newFromURL read, in part:
* Example of wrong and broken code:
* $title = Title::newFromURL( $wgRequest->getVal( 'title' ) );
*
* Example of right code:
* $title = Title::newFromText( $wgRequest->getVal( 'title' ) );
If that's accurate, then there's some code that needs fixing. Otherwise, this
comment is misleading and needs correcting and/or further/clearer qualification
as to when newFromURL may/should/must be used in favor of newFromText() and the
related risks, if any.
The core source files that have "wrong and broken code" are:
./includes/OutputPage.php
./includes/parser/CoreParserFunctions.php
./includes/specials/SpecialListfiles.php
./includes/specials/SpecialMergeHistory.php
./includes/specials/SpecialNewimages.php
./includes/specials/SpecialRecentchangeslinked.php
./includes/specials/SpecialUndelete.php
./includes/specials/SpecialWhatlinkshere.php
./includes/Wiki.php
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
