[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 --- Comment #21 from Ed Sanders --- That seems fine. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 --- Comment #19 from Roan Kattouw --- (In reply to ssastry from comment #18) > Parsoid can handle the preserved data-parsoid .. but, i haven't verified > that nothing breaks if data-parsoid is mangled badly. I think we handle it, > but we should verify that with some testing. I'll try to do some testing (of > mangled data-parsoid contents) tomorrow .. but I am about to head out on a > longish vacation. I'll poke marcoil otherwise. If you or Ed can do some > basic sanity testing, that would be helpful as well. What does "mangled badly" mean in this context? VE would only relocate data-parsoid, never modify it (although I suppose relocation out of context could count as mangled?) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 --- Comment #18 from ssas...@wikimedia.org --- Parsoid can handle the preserved data-parsoid .. but, i haven't verified that nothing breaks if data-parsoid is mangled badly. I think we handle it, but we should verify that with some testing. I'll try to do some testing (of mangled data-parsoid contents) tomorrow .. but I am about to head out on a longish vacation. I'll poke marcoil otherwise. If you or Ed can do some basic sanity testing, that would be helpful as well. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 Roan Kattouw changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #17 from Roan Kattouw --- (In reply to ssastry from comment #12) > To summarize the discussion from IRC, we figured out that we had a gap in > our collective cut-paste handling, and found a solution to preserve syntax > on cut-paste that should work. > > * VE preserves the data-parsoid attribute on paste which Parsoid can then > use to preserve the syntax. Parsoid should be prepared to handle mangled > data-parsoid contents in the generic paste scenario. > Subbu, is Parsoid prepared for this yet? Ed has submitted a commit that will cause VE to preserve data-parsoid on paste; can I merge this safely? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 --- Comment #16 from Gerrit Notification Bot --- Change 173807 had a related patch set uploaded by Esanders: Create 'preserveGenerated' mode for cloneElements and use in copy https://gerrit.wikimedia.org/r/173807 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 Gerrit Notification Bot changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 --- Comment #15 from Gerrit Notification Bot --- Change 173805 had a related patch set uploaded by Esanders: Remove data-parsoid removal hack https://gerrit.wikimedia.org/r/173805 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 --- Comment #14 from Ed Sanders --- Preserving data-parsoid is fine, but the table issue is caused by wrapper paragraphs being converted to regular paragraphs. We should possibly not throw away wrapper properties but that needs to be investigated. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 James Forrester changed: What|Removed |Added Assignee|jforrester+veteambztickets@ |esand...@wikimedia.org |wikimedia.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 James Forrester changed: What|Removed |Added Summary|VisualEditor: Preserve |VisualEditor: Preserve |`data-parsoid` attribute on |`data-parsoid` attribute on |internal copy-paste so that |internal copy-paste so that |Parsoid preserves e.g. |Parsoid preserves e.g. |syntax layout. |syntax layout -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 72426] VisualEditor: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout.
https://bugzilla.wikimedia.org/show_bug.cgi?id=72426 James Forrester changed: What|Removed |Added Priority|Unprioritized |High Status|NEW |ASSIGNED Component|serializer |ContentEditable CC||dc...@wikimedia.org Assignee|parsoid-t...@wikimedia.org |jforrester+veteambztickets@ ||wikimedia.org Summary|Tables should default to|VisualEditor: Preserve |all-in-one-line syntax |`data-parsoid` attribute on ||internal copy-paste so that ||Parsoid preserves e.g. ||syntax layout. Target Milestone|--- |VE-deploy-nextup Product|Parsoid |VisualEditor --- Comment #13 from James Forrester --- Per discussion with Parsoid team, moving this back to VE side and re-titling. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
