[Wikidata-bugs] [Maniphest] [Reopened] T91376: Make ValueView qunit tests independent of focus.

2015-03-12 Thread adrianheine
adrianheine reopened this task as Open. TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Changed Project Column] T88543: Browsertests for geo value input

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88543 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Block] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-12 Thread adrianheine
adrianheine reopened blocking task T91376: Make ValueView qunit tests independent of focus. as Open. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T88795: Browsertests for badge-selector

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88795 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T74664: Smoke browsertests for statements on properties

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T74664 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Commented On] T91376: Make ValueView qunit tests independent of focus.

2015-03-12 Thread adrianheine
adrianheine added a comment. We have a tag, but unfortunately the fix does not work for PhantomJS. https://github.com/wmde/ValueView/pull/165 does, though. TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Changed Project Column] T91376: Make ValueView qunit tests independent of focus.

2015-03-12 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T91376 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Changed Project Column] T89243: Remove time conversion logic from JavaScript code

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T89243 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T72710: StorageException in EditEntityActionTest::testActionForPage (edit-already-exists) and related failures

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T72710 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Commented On] T88275: No language fallback applied for property labels on qualifiers and references in JS UI.

2015-03-12 Thread adrianheine
adrianheine added a comment. I realized that we probably can skip step 3. (and remove most of `wbUsedEntities` right now) since we don't re-render anything anymore :) I'll try that out. TASK DETAIL https://phabricator.wikimedia.org/T88275 REPLY HANDLER ACTIONS Reply to comment or attach

[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)

2015-03-12 Thread adrianheine
adrianheine closed blocking task T88543: Browsertests for geo value input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T55845 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Lowered Priority] T88543: Browsertests for geo value input

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T88543 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Closed] T63601: DataTypes should pass jshint

2015-03-12 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. We don't use the DataTypes project on gerrit currently. TASK DETAIL https://phabricator.wikimedia.org/T63601 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Updated] T86182: Allow list of available languages to be configurable

2015-03-12 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. What's currently missing is the actual configuration interface. I wrote a proposal regarding that in https://phabricator.wikimedia.org/T78007. I think, though, that for most current needs we could just hard-code our

[Wikidata-bugs] [Maniphest] [Commented On] T88275: No language fallback applied for property labels on qualifiers and references in JS UI.

2015-03-11 Thread adrianheine
adrianheine added a comment. My proposal: 1. Move the existing formatting JS code into an EntityIdFormatter 2. Replace usage of the formatting code with usage of EntityIdFormatter 3. Add pre-formatted EntityIds to parser output (probably replacing most of `wbUsedEntities`) 4. Implement API

[Wikidata-bugs] [Maniphest] [Updated] T75875: Find a home for EntityChange and friends

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. See also https://phabricator.wikimedia.org/T75643. TASK DETAIL https://phabricator.wikimedia.org/T75875 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Updated] T75643: EntityChange in lib depends on EntityContent in repo

2015-03-10 Thread adrianheine
adrianheine added a blocked task: T75863: split wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T75643 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T76252: create AcceptLanguageSet that is usable in DataModel

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I don't get this. What would it be used for? TASK DETAIL https://phabricator.wikimedia.org/T76252 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T51024: Removal of de-formal from allowed language for labels

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Wikidata looks fine in de-formal. As for not allowing de-formal for labels, aliases and descriptions: Wikibase now internally supports specific language lists for them, so we could implement this. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Updated] T47675: [statements-ui] Display red links for deleted Properties

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. This is the inverse to https://phabricator.wikimedia.org/T67533. TASK DETAIL https://phabricator.wikimedia.org/T47675 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable save button until server responds

2015-03-10 Thread adrianheine
adrianheine added a comment. I don't think it's broken per se. In any case, supporting saving of unparsed values (i.e. ad-hoc parsing) is quite some new feature which would require a lot of work. TASK DETAIL https://phabricator.wikimedia.org/T59665 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Commented On] T75879: move wikibase parsers and validators into a separate repository

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Validators are only used in repo now and could be moved there. TASK DETAIL https://phabricator.wikimedia.org/T75879 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Closed] T44576: [statements-ui] Qunit tests for the creation and display of statements

2015-03-10 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T44576 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T66995: WikibaseExceptionLocalizer has repo-specific code

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Is this still the case? TASK DETAIL https://phabricator.wikimedia.org/T66995 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T57961: the message that shows the number of sources for a statement seems to use PLURAL incorrectly

2015-03-10 Thread adrianheine
adrianheine added a comment. You're right, it's like this: `wikibase-ui-pendingquantitycounter-nonpending` and `wikibase-ui-pendingquantitycounter-pending` are basically called with $1: wikibase-propertyedittool-counter-entrieslabel, $2: n, $3: span title=wikibase-propertyedittool-counter

[Wikidata-bugs] [Maniphest] [Closed] T65308: Split EntityIdFormatter from EntityIdValueFormatter

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAa79f1366a8bef7431854e30d89b7e4a312e0fa55. TASK DETAIL https://phabricator.wikimedia.org/T65308

[Wikidata-bugs] [Maniphest] [Updated] T76866: Split validators from DataType class

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Possibly done with https://phabricator.wikimedia.org/rEWBA28c003dbba7ce80a750a1e8d7f96df993ebdf66d. What do you think, @daniel? TASK DETAIL https://phabricator.wikimedia.org/T76866 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74043: Remove class aliases from data-values/geo

2015-03-10 Thread adrianheine
adrianheine added subscribers: Aklapper, Lucie. adrianheine merged a task: T87748: remove class_alias usage. TASK DETAIL https://phabricator.wikimedia.org/T74043 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Merged] T87748: remove class_alias usage

2015-03-10 Thread adrianheine
adrianheine closed this task as a duplicate of T74043: Remove class aliases from data-values/geo. TASK DETAIL https://phabricator.wikimedia.org/T87748 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T68486: Make EntityViewFactory

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAf027aea0c5d75df239fa3c6dc7a5b899845043f6. TASK DETAIL https://phabricator.wikimedia.org/T68486

[Wikidata-bugs] [Maniphest] [Closed] T71671: False message: List of values is complete.

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Please reopen if this happens again. TASK DETAIL https://phabricator.wikimedia.org/T71671 REPLY HANDLER ACTIONS Reply to comment or attach

[Wikidata-bugs] [Maniphest] [Closed] T44433: Cleanup PID code in Utils

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAacf54e9dd03a043494bab3c6f482a911092c8eee. TASK DETAIL https://phabricator.wikimedia.org/T44433

[Wikidata-bugs] [Maniphest] [Unblock] T75653: Implement new Wikibase Skin

2015-03-10 Thread adrianheine
adrianheine closed blocking task T75652: Research how we can maximize compatibility of a new Wikibase skin with Vector (and Monobook) as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T75653 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Closed] T75652: Research how we can maximize compatibility of a new Wikibase skin with Vector (and Monobook)

2015-03-10 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. Currently we are not planning to create a new Wikibase skin. TASK DETAIL https://phabricator.wikimedia.org/T75652 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T49930: Allow accessing data from an item not connected to the current page - arbitrary access (tracking)

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T49930 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Closed] T65528: Replace usage of SimpleSiteLink with Wikibase\DataModel\SiteLink

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Couldn't find any `SimpleSiteLink` in Wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T65528 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Declined] T43813: Make a separate extension out of the template engine

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Declined. adrianheine claimed this task. adrianheine added a comment. Core now has its own template engine. We should rather switch to that one: https://phabricator.wikimedia.org/T78559 https

[Wikidata-bugs] [Maniphest] [Commented On] T39459: Don't try to add labels in non-existing languages: restrict to Language::isKnownLanguageTag

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Due to language fallbacks, this looks pretty good now (https://www.wikidata.org/wiki/Q2?uselang=xyzzy), but it still asks you to enter label, description and aliases in xyzzy. `EntityViewFactory::newEntityTermsView

[Wikidata-bugs] [Maniphest] [Closed] T57961: the message that shows the number of sources for a statement seems to use PLURAL incorrectly

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. I don't think this is a code issue either, doesn't look like lego to me. TASK DETAIL https://phabricator.wikimedia.org/T57961 REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Commented On] T45024: Special pages should check permissions and read-only mode before showing a form

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Is that still the case? When doing https://gerrit.wikimedia.org/r/#/c/194532/, I got the feeling that the special pages would not show up without correct permissions. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T88589: Use of wgUserLanguage is deprecated. Use mw.config instead. in AnonymousI18n gadget

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T88589 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2015-03-10 Thread adrianheine
adrianheine added a blocking task: T75643: EntityChange in lib depends on EntityContent in repo. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T65804: php class namespace errors

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. I suppose this is done since we removed all `class_alias` usages. TASK DETAIL https://phabricator.wikimedia.org/T65804 REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Closed] T67432: PHP notice: Undefined Offset: 1

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. All our modules now support being but directly in `vendor/`. TASK DETAIL https://phabricator.wikimedia.org/T67432 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Commented On] T73100: wbformatvalue called twice when creating statement

2015-03-10 Thread adrianheine
adrianheine added a comment. @Snaterlicious Still the case? TASK DETAIL https://phabricator.wikimedia.org/T73100 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T73271: Wikidata should use style guide

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T73271 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T45295: Keyword 'use' inconsistency for php namespaces

2015-03-10 Thread adrianheine
adrianheine added subscribers: thiemowmde, adrianheine. adrianheine added a comment. I think we are moving towards `use`-ing them, but I'm not sure. @ThiemoWMDE? TASK DETAIL https://phabricator.wikimedia.org/T45295 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T53660: Detect the edit state to adapt help messages to user errors

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I think this is not Wikidata-specific. @Lydia_Pintscher? TASK DETAIL https://phabricator.wikimedia.org/T53660 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Commented On] T87640: Wikidata edits do not update page watched icon

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. We have code in place that tries to do that, so apparently it's broken. TASK DETAIL https://phabricator.wikimedia.org/T87640 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Commented On] T55849: Migrate current selenium tests to cucumber

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Are there still unmigrated tests? TASK DETAIL https://phabricator.wikimedia.org/T55849 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unblock] T70019: Use pre-fetched labels throughout EntityView

2015-03-10 Thread adrianheine
adrianheine closed blocking task T70020: Use EntityIdHtmlLinkFormatter for format properties in EntityView as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70019 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T70020: Use EntityIdHtmlLinkFormatter for format properties in EntityView

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAbaf7578c5e675a455a43f3afee3aa59d8fe4c81b TASK DETAIL https://phabricator.wikimedia.org/T70020

[Wikidata-bugs] [Maniphest] [Closed] T69394: [Monolingual] Can not search for language names in my language

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://github.com/wmde/ValueView/commit/dceacfc4aff1b794fa90045f738db838f93c88b8. TASK DETAIL https://phabricator.wikimedia.org/T69394

[Wikidata-bugs] [Maniphest] [Closed] T75360: save button not activated when changing order of statements

2015-03-10 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T75360 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Closed] T60180: changes to ordering don't persist under certain condition

2015-03-10 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. Moving is not supported anymore. TASK DETAIL https://phabricator.wikimedia.org/T60180 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable save button until server responds

2015-03-10 Thread adrianheine
adrianheine added a comment. This has been the case for all datavalue types for a year. I suppose users adapted to it. Close? TASK DETAIL https://phabricator.wikimedia.org/T59665 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Retitled] T87370: Use ContentLanguages object for special pages JS

2015-03-10 Thread adrianheine
adrianheine changed the title from Use ContentLanguages object for special pages to Use ContentLanguages object for special pages JS. TASK DETAIL https://phabricator.wikimedia.org/T87370 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Retitled] T87369: Use ContentLanguages object for terms JS

2015-03-10 Thread adrianheine
adrianheine changed the title from Use ContentLanguages object for terms to Use ContentLanguages object for terms JS. TASK DETAIL https://phabricator.wikimedia.org/T87369 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T85252: Edit buttons are getting cached, although their visibility depends on user rights

2015-03-04 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T85252 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T88950: Migrate all relevant Lua modules from mw.wikibase.getEntity to mw.wikibase.getEntityObject

2015-03-04 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88950 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Commented On] T88441: investigate how language fallbacks can be done in entity search

2015-03-04 Thread adrianheine
adrianheine added a comment. Some questions: - Who/what (else) is using SearchEntities? - How will we build language fallback chains? Who will configure them? I think that's pretty important for deciding what the API looks like (bool vs list of languages) - Can we really get away

[Wikidata-bugs] [Maniphest] [Updated] T90756: Maintenance script to update a client wiki's subscriptions based on the usage tracking table.

2015-03-04 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://gerrit.wikimedia.org/r/#/c/193815/ TASK DETAIL https://phabricator.wikimedia.org/T90756 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T89698: API function wbsetqualifier blocks frontend

2015-03-04 Thread adrianheine
adrianheine added a comment. I think the current behavior is not too bad. The Wikibase JavaScript code found some value it cannot allow you to edit because the UI is not able to represent the current state. What's broken about this is that the UI is not able to handle non-standard calendar

[Wikidata-bugs] [Maniphest] [Commented On] T87579: investigate solutions for items with a large number of aliases

2015-03-04 Thread adrianheine
adrianheine added a comment. Other ideas: - Horizontal table with headers in the left column (below language, maybe right-aligned) - Horizontal table without the headers at all Why is the description between aliases and label? To me it seems like aliases and labels are of the same kind, just

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a comment. The failing ExpertExtender tests also need focus apparently. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T90492: Make Wikibase Repo work with a custom File collection, not only Wikimedia Commons

2015-03-03 Thread adrianheine
adrianheine added a comment. I'd suggest to introduce an ExpertFactory replacing the currently used ExpertStore. Then we could control instantiation arguments for the experts and the ValueViewBuilder would get simpler. ContentLanguages could be passed through the ExpertFactory, too. Currently

[Wikidata-bugs] [Maniphest] [Raised Priority] T85799: mw-debug.log missing in Jenkins jobs (Failed to be created Permission denied)

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from Normal to Needs Triage. TASK DETAIL https://phabricator.wikimedia.org/T85799 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Raised Priority] T87858: Adjust AuthorityControl Gadget to snakview name changes

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from High to Unbreak Now!. TASK DETAIL https://phabricator.wikimedia.org/T87858 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Raised Priority] T85252: Edit buttons are getting cached, although their visibility depends on user rights

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from High to Needs Triage. TASK DETAIL https://phabricator.wikimedia.org/T85252 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a comment. Thank you, @Krinkle! TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine created this task. adrianheine added subscribers: adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper. adrianheine added projects: Continuous-Integration, Wikidata, § Wikidata-Sprint-2015-02-25. TASK DESCRIPTION TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Created] T91376: Make ValueView qunit tests independent of focus.

2015-03-03 Thread adrianheine
adrianheine created this task. adrianheine added subscribers: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine. adrianheine added projects: § Wikidata-Sprint-2015-02-25, Wikidata, Continuous-Integration. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Created] T91385: Use MessageProvider for views in Wikibase

2015-03-03 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Currently, the MessageProvider is only used for the ValueView; it could and should be used for all the views

[Wikidata-bugs] [Maniphest] [Raised Priority] T91376: Make ValueView qunit tests independent of focus.

2015-03-03 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-02-25 workboard. adrianheine raised the priority of this task from Normal to High. TASK DETAIL https://phabricator.wikimedia.org/T91376 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Changed Project Column] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T74184 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T91377 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T77982: Implement Unit Selector widget

2015-03-03 Thread adrianheine
adrianheine closed blocking task T77981: QuantityValueParser: Allow unit to be specified via options as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77982 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T77981: QuantityValueParser: Allow unit to be specified via options

2015-03-03 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77981 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T77977: Unit support (tracking)

2015-03-03 Thread adrianheine
adrianheine closed blocking task T77981: QuantityValueParser: Allow unit to be specified via options as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77977 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)

2015-03-03 Thread adrianheine
adrianheine closed blocking task T88545: Browsertests for URL value input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T55845 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Lowered Priority] T88545: Browsertests for URL value input

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T88545 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Unblock] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine closed blocking task T91377: Make Wikibase qunit tests independent of focus as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. They already are, it's just ValueView. TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Updated] T91376: Make ValueView qunit tests independent of focus.

2015-03-03 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/ValueView/pull/161 TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a comment. AFAIK we are the only ones with focus tests. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T90453: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength

2015-03-03 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T90453#1073327, @Krinkle wrote: - The relevant software is incorrectly using the ResourceLoader module system. (E.g. using it as a complete class registry.) This has all kinds of scalability impacts and semantic fragileness

[Wikidata-bugs] [Maniphest] [Updated] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a blocking task: T91377: Make Wikibase qunit tests independent of focus. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine added a blocked task: T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit. TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T75496: Support new types of Entities in Wikibase Repository

2015-02-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T75496 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T77985: Add mechanism for registering new entity types, to work with things like EntityViewFactory

2015-02-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77985 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T76021: Create extension mechanism for Wikibase Repository

2015-02-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T76021 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-02-27 Thread adrianheine
adrianheine added subscribers: WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW. adrianheine added a comment. The focusing tests fail. We should either try to detect if they could possibly pass and otherwise skip them or remove them altogether. @Tobi_WMDE_SW @snaterlicious @WMDE-Fisch What do you think

[Wikidata-bugs] [Maniphest] [Commented On] T87237: RFC: Possible redesign of the EntityTermsProvider interface

2015-02-26 Thread adrianheine
adrianheine added a comment. Following Thiemo's analysis, I think we don't gain much by artificially grouping the terms properties and items have. The fact that we are not able to come up with a sane name for this adds up to the feeling that this is arbitrary and does not really correspond

[Wikidata-bugs] [Maniphest] [Commented On] T88441: investigate how language fallbacks can be done in entity search

2015-02-26 Thread adrianheine
adrianheine added a comment. @Lydia_Pintscher: If this is resolved, who reviewed it? TASK DETAIL https://phabricator.wikimedia.org/T88441 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T90720: Introduce wikibase.view.ViewFactory

2015-02-26 Thread adrianheine
adrianheine added a comment. Why did you create a separate task for this? There already is a 1:1 relation for task and change here. TASK DETAIL https://phabricator.wikimedia.org/T90720 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Claimed] T90268: BadMethodCallException from line 244 of EntityViewPlaceholderExpander.php

2015-02-24 Thread adrianheine
adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T90268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T90268: BadMethodCallException from line 244 of EntityViewPlaceholderExpander.php

2015-02-24 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-02-03. TASK DETAIL https://phabricator.wikimedia.org/T90268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T90459: wikidata qunit test on labs-vagrant have errors

2015-02-24 Thread adrianheine
adrianheine added a comment. [ef7b5d6d] Exception Caught: Non-daemonized mode is no longer supported. Please install the mediawiki/services/jobrunner service and update $wgJobTypeConf as needed. TASK DETAIL https://phabricator.wikimedia.org/T90459 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T75604: create documentation of php data model

2015-02-19 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T75604 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74907: move git repositories that are dependencies of wikidata to gerrit

2015-02-19 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T74907 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

<    4   5   6   7   8   9   10   11   12   >