zeljkofilipin added projects: Release-Engineering-Team,
Release-Engineering-Team-TODO.
TASK DETAIL
https://phabricator.wikimedia.org/T224125
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: hashar, Aklapper, EBernhardson, Smalyshev
zeljkofilipin added a subscriber: hashar.
zeljkofilipin added a comment.
I think there's a project to **//remove//** special config settings for CI,
see T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly
deprecating the feature <https://phabricator.wikimedia.org/T199
zeljkofilipin added a comment.
In T167432#5317884 <https://phabricator.wikimedia.org/T167432#5317884>,
@Addshore wrote:
> I can't find the jobs for test right now? Are these even running any more?
Or are we just on beta now?
I'm not sure what you mean. This?
Ran
zeljkofilipin added a comment.
Should this task be resolved? There's nothing left in tests/browser
<https://phabricator.wikimedia.org/diffusion/EWLE/browse/master/tests/browser/>.
TASK DETAIL
https://phabricator.wikimedia.org/T179916
EMAIL PREFERENCES
https://phabricator.wikimed
zeljkofilipin closed subtask T223774: The first Selenium test for
WikibaseCirrusSearch as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T223789
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Aklapper, Smalyshev
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T224125
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Aklapper, EBernhardson, Smalyshev, zeljkofilipin, Mholloway, darthmon_wmde
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T224284
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave, zeljkofilipin
Cc: aude, Aklapper, Tobi_WMDE_SW, noarave, Daryl-TTMG, RomaAmorRoma
zeljkofilipin added subscribers: hashar, zeljkofilipin.
zeljkofilipin added a comment.
I've had this happen to me locally (T126611#2022173
<https://phabricator.wikimedia.org/T126611#2022173>) but I didn't know a
mediawiki instance at a jenkins VM would be ratelimited at all. @hashar
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T225796
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Daryl-TTMG, RomaAmorRoma,
E.S.A
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T224284
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave, zeljkofilipin
Cc: aude, Aklapper, Tobi_WMDE_SW, noarave, Daryl-TTMG, RomaAmorRoma
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T224125
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Aklapper, EBernhardson, Smalyshev, zeljkofilipin, Mholloway, darthmon_wmde
zeljkofilipin added a project: Wikimedia-Hackathon-2019.
TASK DETAIL
https://phabricator.wikimedia.org/T00
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: hashar, zeljkofilipin, noarave, alaa_wmde, WMDE-leszek, Aklapper
zeljkofilipin added a comment.
- I will be at #wikimedia-hackathon-2019
<https://phabricator.wikimedia.org/tag/wikimedia-hackathon-2019/> next week, if
anybody wants to pair on this.
- The convention is to have Selenium tests (including `wdio.conf.js`) in
`tests/selenium`, if po
zeljkofilipin triaged this task as "Normal" priority.
TASK DETAIL
https://phabricator.wikimedia.org/T00
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: hashar, zeljkofilipin, noarave, alaa_wmde, WMDE-leszek, Aklappe
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T00
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: hashar, zeljkofilipin, noarave, alaa_wmde, WMDE-leszek, Aklapper, Nandana
zeljkofilipin triaged this task as "Unbreak Now!" priority.
zeljkofilipin added a comment.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes.
Train blockers are UBN!
TASK DETAIL
https://phabricator.wikimedia.org/T218950
EMAIL PREFERENC
zeljkofilipin triaged this task as "Unbreak Now!" priority.
zeljkofilipin added a comment.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes.
Train blockers are UBN!
TASK DETAIL
https://phabricator.wikimedia.org/T218826
EMAIL PREFERENC
zeljkofilipin added a comment.
/me facepalms 臘♂️
Thanks everybody. I blame phabricator for this duplicate. I have searched
for `PHP Fatal Error: Argument 1 passed to
Wikibase\Rdf\RdfBuilder::addEntityRedirect() must be an instance of
Wikibase\DataModel\Entity\EntityId, null given
zeljkofilipin closed this task as a duplicate of T213483: Fatal error: null
EntityId argument passed to addEntityRedirect (Special:EntityData broken for
some items).
Restricted Application removed a subscriber: Liuxinyu970226.
TASK DETAIL
https://phabricator.wikimedia.org/T218825
EMAIL
zeljkofilipin merged a task: T218825: PHP Fatal Error: Argument 1 passed to
Wikibase\Rdf\RdfBuilder::addEntityRedirect() must be an instance of
Wikibase\DataModel\Entity\EntityId, null given.
zeljkofilipin added subscribers: Ladsgroup, alaa_wmde.
TASK DETAIL
https://phabricator.wikimedia.org
zeljkofilipin added a comment.
Caused by 493096
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/493096>?
TASK DETAIL
https://phabricator.wikimedia.org/T218825
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofili
zeljkofilipin added a parent task: T206676: 1.33.0-wmf.22 deployment blockers.
TASK DETAIL
https://phabricator.wikimedia.org/T218825
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Aklapper, TerraCodes, Liuxinyu970226, zeljkofilipin
zeljkofilipin created this task.
zeljkofilipin added projects: Wikimedia-production-error, User-zeljkofilipin,
Wikidata, Wikidata-Campsite.
zeljkofilipin triaged this task as "Unbreak Now!" priority.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper.
TASK D
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T207235
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Lydia_Pintscher, Addshore, Ladsgroup, Krinkle, Aklapper, alaa_wmde,
Nandana
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAIL
https://phabricator.wikimedia.org/T194252
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek, zeljkofilipin
Cc: Addshore, Aklapper, gerritbot, hashar, zeljkofilipin, WMDE
zeljkofilipin added a project: Wikidata-Campsite.
Restricted Application added a project: Wikidata.
TASK DETAIL
https://phabricator.wikimedia.org/T217648
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zeljkofilipin
Cc: Aklapper, hashar
zeljkofilipin raised the priority of this task from "Normal" to "High".
zeljkofilipin added a comment.
This is the most common error right now in both fatal-monitor
<https://logstash.wikimedia.org/app/kibana#/dashboard/Fatal-Monitor> and
mediawiki-errors
<https
zeljkofilipin added subscribers: Ladsgroup, Addshore.zeljkofilipin added a comment.
In T210285#4866054, @hashar wrote:
Given the job is not working at all, I think we should just delete it. Not sure whom to reach out to to approve that.
@Addshore @Ladsgroup you were pretty active recently
zeljkofilipin added a parent task: T20: 1.33.0-wmf.12 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, zeljkofilipinCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE
zeljkofilipin added a project: Wikimedia-production-error.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Tarrow, Jakob_WMDE, Lucas_Werkmeister_WMDE, Pablo-WMDE, Jdforrester-WMF, daniel
zeljkofilipin added a comment.
TLDR: because this is a new error, it's blocking the train. Since people are already on vacation or leaving soon, I need to know if it's fine to move the train forward with this, or not.TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION**TLDR: because this is a new error, it's blocking the train. Since people are already on vacation or leaving soon, I need to know if it's fine to move the train forward with this, or not.**
Noticed in [[ https
zeljkofilipin added subscribers: Cparle, WMDE-leszek, daniel, Jdforrester-WMF.zeljkofilipin added a comment.
Pinging people mentioned in the commit: @daniel @Addshore @Jdforrester-WMF @WMDE-leszek @CparleTASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps
zeljkofilipin added a comment.
Only 479419 changed lib/includes/Store/Sql/PageTableEntityQueryBase.php.TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Addshore, TerraCodes, Liuxinyu970226
zeljkofilipin added a comment.
Wikibase commits new in wmf.9: MediaWiki_1.33/wmf.9/Changelog#WikibaseTASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Addshore, TerraCodes, Liuxinyu970226
zeljkofilipin added a parent task: T206663: 1.33.0-wmf.9 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper, zeljkofilipin, Nandana, Lahi, Gq86, GoranSMilovanovic
zeljkofilipin triaged this task as "Unbreak Now!" priority.Restricted Application added subscribers: Liuxinyu970226, TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T212427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc:
zeljkofilipin created this task.zeljkofilipin added projects: Wikidata, Wikidata-Campsite.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONNoticed in Fatal-Monitor
[XBulpgpAAK4AAK7YOp0D] /w/api.php?action="" Wikibase\DataModel\Services\Lookup\EntityLookupExce
zeljkofilipin added a comment.
Do you have an estimate on the numbers when move group2 to wmf.8? If you estimate that the number will remain low, then I guess this is not blocking the train. If you don't have an estimate, I would be reluctant to move the train forward and this would still block
zeljkofilipin added a project: Release-Engineering-Team (Backlog).
TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana
zeljkofilipin removed a project: Release-Engineering-Team (Kanban).
TASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Lydia_Pintscher, Stashbot, Ladsgroup, hoo, Addshore, aude, gerritbot
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Lydia_Pintscher, Stashbot, Ladsgroup, hoo, Addshore, aude, gerritbot, PokestarFan
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T197875EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper, WMDE-leszek, zeljkofilipin, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden
zeljkofilipin added a comment.
As far as I am concerned, it's fine not to run a failing test, until it's fixed. See how it's done for core: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457854TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL PREFERENCEShttps://phabricator.wikimedia.org
zeljkofilipin added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Addshore, Ladsgroup, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden
zeljkofilipin added subscribers: Ladsgroup, Addshore.zeljkofilipin added a comment.
@Ladsgroup @Addshore do you know what is the problem?TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc
zeljkofilipin added a subtask: T204205: selenium-daily-beta-Wikibase Jenkins job fails with: AssertionError: 'Q1xy' === 'Item:Q1xy'.
TASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc
zeljkofilipin added a parent task: T167432: Run Wikibase daily browser tests on Jenkins.
TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper, zeljkofilipin, Lahi, Gq86
zeljkofilipin created this task.zeljkofilipin added projects: wikiba.se, Wikidata.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONselenium-daily-beta-Wikibase Jenkins job fails:
> MEDIAWIKI_USER='Selenium user' MW_SERVER=https://wikidata.beta.wmflabs.org:443 MW_SCRIPT_PATH
zeljkofilipin added a parent task: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
TASK DETAILhttps://phabricator.wikimedia.org/T204205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper
zeljkofilipin added a comment.
I'm not sure how to reproduce this:
$ vagrant ssh
vagrant@vagrant:~$ cd /vagrant/mediawiki
vagrant@vagrant:/vagrant/mediawiki$ php5 phpunit.php
-bash: php5: command not found
vagrant@vagrant:/vagrant/mediawiki$ which php5
vagrant@vagrant:/vagrant/mediawiki
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, zeljkofilipinCc: Pablo-WMDE, hoo, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo
zeljkofilipin added a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T201337EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, zeljkofilipinCc: gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22
zeljkofilipin added a comment.
In T200011#4487774, @WMDE-leszek wrote:
hardcoding the directory structure (and name) like done now is a bit evil.
Agreed. Even if you decide you don't care about running tests targeting beta cluster, hard-coding paths to files from another repository is a code
zeljkofilipin added a comment.
In T200011#4487750, @Addshore wrote:
The WikibaseLexeme extension can't function without the Wikibase extension loaded anyway, so the browser tests would never pass anyway.
The Jenkins job (running daily, targeting beta cluster) just clones a repository, runs npm
zeljkofilipin added a comment.
Removed parent task because of T191060#4453892.TASK DETAILhttps://phabricator.wikimedia.org/T200420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: zeljkofilipin, aaron, gerritbot, Stashbot, WMDE-leszek, Addshore
zeljkofilipin removed a parent task: T191060: 1.32.0-wmf.14 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T200420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: aaron, gerritbot, Stashbot, WMDE-leszek, Addshore, TerraCodes
zeljkofilipin added a parent task: T191060: 1.32.0-wmf.14 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T200420EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, zeljkofilipinCc: gerritbot, Stashbot, WMDE-leszek, Addshore
zeljkofilipin added a comment.
In T200340#4450574, @Ladsgroup wrote:
It's probably a new version that got released but not updated in the vendor I think.
Is there a way to quickly fix this? Or is there a workaround? I need an estimate on when this could be resolved, since it's blocking
zeljkofilipin added a comment.
I have rolled back group 1 from .14 to .13, but now I see the same error for .13
[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of /srv/mediawiki/php-1.32.0-wmf.13/vendor/wikibase/data-model/src/Entity
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```
I have rolled back group 1 from .14 to .13, but now I see the same error for .13
```
[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of /srv/mediawiki/php
zeljkofilipin renamed this task from "[{exception_id}] {exception_url} Wikibase\DataModel\Entity\EntityIdParsingException from line 49 of /srv/mediawiki/php-1.32.0-wmf.14/vendor/wikibase/data-model/src/Entity/DispatchingEntityIdParser.php: $serialization must not be an empty string" to
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONNoticed at [[ https://logstash.wikimedia.org/app/kibana#/dashboard/Fatal-Monitor | Fatal Monitor ]] after pushing 1.32.0-wmf.14 to group 1.TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONNoticed after pushing 1.32.0-wmf.14 to group 1.TASK DETAILhttps://phabricator.wikimedia.org/T200340EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Krinkle
zeljkofilipin added a comment.
According to conversation with @Anomie in #mediawiki-core, this is no longer blocking the train.TASK DETAILhttps://phabricator.wikimedia.org/T200072EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Stashbot
zeljkofilipin removed a parent task: T191059: 1.32.0-wmf.13 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T200072EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Stashbot, Liuxinyu970226, daniel, zeljkofilipin, TerraCodes
zeljkofilipin added a comment.
Removing T191059: 1.32.0-wmf.13 deployment blockers as the parent task because of T199983#4447103 and T191059#4447107.TASK DETAILhttps://phabricator.wikimedia.org/T199983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
zeljkofilipin removed a parent task: T191059: 1.32.0-wmf.13 deployment blockers.
TASK DETAILhttps://phabricator.wikimedia.org/T199983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: zeljkofilipin, hoo, Nikki, Niharika, hashar, Jdforrester-WMF
zeljkofilipin added a comment.
@hoo friendly but serious reminder: this is the only blocking task of the current train that does not have a clear way forward. Is there anything we can do here to unblock the train?TASK DETAILhttps://phabricator.wikimedia.org/T199983EMAIL PREFERENCEShttps
zeljkofilipin raised the priority of this task from "High" to "Unbreak Now!".zeljkofilipin added a comment.
Changing priority to UBN since it's blocking the train.
Friendly reminder: the train is blocked because of this task. (It's not the only blocker at the time I write thi
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...## Node.js [[ https://integration.wikimedia.org/ci/job/WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker/ | WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker ]]
{T200011}
# Done ...TASK
zeljkofilipin added a subtask: T200011: `ERROR: Cannot find module '../../../../Wikibase/repo/tests/selenium` when running WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job.
TASK DETAILhttps://phabricator.wikimedia.org/T194252EMAIL PREFERENCEShttps://phabricator.wikimedia.org
zeljkofilipin added a parent task: T194252: Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T200011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: zeljkofilipin
zeljkofilipin created this task.zeljkofilipin added projects: Wikidata, Lexicographical data.
TASK DESCRIPTIONWikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker Jenkins job does this:
git clone WikibaseLexeme
npm install
npm run selenium-daily
It fails because WikibaseLexeme repository
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...## Node.js [[ https://integration.wikimedia.org/ci/job/WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker/ | WikibaseLexeme-npm-browser-run-selenium-daily-node-6-docker ]]
[[ https
zeljkofilipin added a parent task: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
TASK DETAILhttps://phabricator.wikimedia.org/T194252EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, zeljkofilipinCc
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONTwo jobs should be created, one running Ruby Selenium tests ([[ https://integration.wikimedia.org/ci/job/selenium-WikibaseLexeme-chrome/ | selenium-WikibaseLexeme-chrome ]]), one running Node.js Selenium tests
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...# TODO
## Docker
Get WikibaseLexeme running locally, following instructions at [[ https://github.com/addshore/mediawiki-docker-dev | addshore/mediawiki-docker-dev ]] and [[ https://github.com/wikimedia
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... fails with `PHP Fatal error: Uncaught Error: Class 'Wikibase\WikibaseSettings' not found in /home/jenkins/workspace/selenium-WikibaseLexeme-jessie/src/extensions/WikibaseLexeme/src/Registrar.php:18
zeljkofilipin closed this task as "Resolved".zeljkofilipin claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Aklapper, gerritbot, WMDE-leszek, Tarrow
zeljkofilipin closed subtask T197868: `Class 'Wikibase\DataModel\Entity\ItemId' not found` error when trying to install WikibaseLexeme as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T194252EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreference
zeljkofilipin removed a project: User-zeljkofilipin.
TASK DETAILhttps://phabricator.wikimedia.org/T195372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Lexicographical data, KaMan, Esc3300, Pablo-WMDE, gerritbot, Lea_Lacroix_WMDE, Aklapper
zeljkofilipin added a project: MediaWiki-Core-Tests.
TASK DETAILhttps://phabricator.wikimedia.org/T194252EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, zeljkofilipinCc: hashar, zeljkofilipin, gerritbot, WMDE-leszek, Aklapper, Gaboe420, Versusxo
zeljkofilipin removed projects: User-zeljkofilipin, Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T180228EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Ladsgroup, gerritbot, Aklapper, zeljkofilipin, Lahi, Gq86
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION# TODO
mediawiki/extensions/Wikibase: master: Start a very basic nodejs browser test [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441051 | 441051 ]]# Done
# Done
mediawiki/core: master: Selenium
zeljkofilipin added a comment.
My composer.local.json was always good, I have noticed that the readme was wrong in a desperate attempt to follow the instructions blindly.
So, nobody else can reproduce the problem?
Maybe there is something wrong with my machine. Do I need to have a specific
zeljkofilipin added a comment.
In T197868#4318830, @Addshore wrote:
but wikibase/data-model still isn't in your composer.lock?
No.
Could be some sort of bug with the composer merge plugin?
路♂️
All I can think of suggestion is remove you vendor dir and the composer.lock file and try again
zeljkofilipin added a comment.
In T197868#4312358, @Addshore wrote:
It doesn't look like you have done the "Install the dependencies with composer:" step in the WikibaseLexeme readme.
But I did:
~/Documents/gerrit/mediawiki/core$ docker run -it --rm --user $(id -u):$(id -g) -v ~
zeljkofilipin added a comment.
@Addshore P7288TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: WMDE-leszek, Tarrow, Addshore, Aklapper, zeljkofilipin, Lahi, Gq86, GoranSMilovanovic, QZanden
zeljkofilipin added a comment.
I am following instructions from addshore/mediawiki-docker-dev and wikimedia/mediawiki-extensions-WikibaseLexeme. I am at docker-compose exec "web" php /var/www/mediawiki/maintenance/update.php --wiki default --quick step of WikibaseLexeme's readme f
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...## Node.js [[ https://integration.wikimedia.org/ci/view/Selenium/job/selenium-WikibaseLexeme-jessie/ | selenium-WikibaseLexeme-jessie ]]
Added WikibaseLexeme project for a daily Node.js Selenium test run
zeljkofilipin closed subtask T197882: jenkins_jobs.errors.JenkinsJobsException: Duplicate entry found in '/src/integration/config/jjb/selenium.yaml: 'WikibaseLexeme' already defined as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T194252EMAIL PREFER
zeljkofilipin closed this task as "Resolved".zeljkofilipin added a comment.
Resolved with 441827.TASK DETAILhttps://phabricator.wikimedia.org/T197882EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: gerritbot, Aklapper, zeljkofilipin
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... fails with `PHP Fatal error: Uncaught Error: Class 'Wikibase\WikibaseSettings' not found in /home/jenkins/workspace/selenium-WikibaseLexeme-jessie/src/extensions/WikibaseLexeme/src/Registrar.php:18
zeljkofilipin added a comment.
Thanks, I did run docker system prune and docker system prune --volumes. I still get the same error message. TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc
zeljkofilipin added a comment.
I don't have much experience with Docker, so in attempt to start clean, I have deleted addshore/mediawiki-docker-dev, mediawiki/core, Wikibase and WikibaseLexeme repositories and cloned them again. I get the same error message. I think I remember the instructions
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```
It's a code smell if a repository just assumes another repository would be available at a precise location. If some code is shared between Wikibase and WikibaseLexeme it belongs to a library, probably
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```
I have tried reproducing the problem on my machine, but I get different error messages. 樂
```
~/Documents/gerrit/mediawiki/vagrant/mediawiki/extensions/WikibaseLexeme$ MEDIAWIKI_ENVIRONMENT=beta bundle
zeljkofilipin added a comment.
In T197875#4307078, @WMDE-leszek wrote:
The reason why I think Wikibase code is needed is that WikibaseLexeme/tests/browser/features/support/env.rb contains following stuff:
require_all File.dirname(__FILE__) + '/../../../../../Wikibase/tests/browser/features
zeljkofilipin updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... mediawiki/extensions/Wikibase: master: Start a very basic nodejs browser test [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441051 | 441051 ]]
integration/config: master: Run qunit-selenium Jenkins
301 - 400 of 964 matches
Mail list logo