Re: [Wikidata] Breaking change in JSON serialization?

2016-08-16 Thread Peter F. Patel-Schneider
On 08/16/2016 07:57 AM, Daniel Kinzler wrote: > Am 11.08.2016 um 23:12 schrieb Peter F. Patel-Schneider: >> Until suitable versioning is part of the Wikidata JSON dump format and >> contract, however, I don't think that consumers of the dumps should just >> ignore new fields. > > Full versioning

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-16 Thread Daniel Kinzler
Am 11.08.2016 um 23:12 schrieb Peter F. Patel-Schneider: > Until suitable versioning is part of the Wikidata JSON dump format and > contract, however, I don't think that consumers of the dumps should just > ignore new fields. Full versioning is still in the future, but I'm happy that we are in

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-11 Thread Markus Kroetzsch
Dear all, There have been some interesting discussions about breaking changes here, but before we continue in this direction, let me repeat that I did not start this thread to define what is a "breaking change" in JSON. There are JSON libraries that define this in a strict way (siding with

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-11 Thread Peter F. Patel-Schneider
On 08/11/2016 01:35 PM, Stas Malyshev wrote: > Hi! > >> My view is that this tool should be extremely cautious when it sees new data >> structures or fields. The tool should certainly not continue to output >> facts without some indication that something is suspect, and preferably >> should

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-11 Thread Stas Malyshev
Hi! > My view is that this tool should be extremely cautious when it sees new data > structures or fields. The tool should certainly not continue to output > facts without some indication that something is suspect, and preferably > should refuse to produce output under these circumstances. I

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-11 Thread Peter F. Patel-Schneider
On 08/05/2016 08:57 AM, Daniel Kinzler wrote: > Am 05.08.2016 um 17:34 schrieb Peter F. Patel-Schneider: >> So some additions are breaking changes then. What is a system that consumes >> this information supposed to do? If the system doesn't monitor announcements >> then it has to assume that

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-11 Thread Peter F. Patel-Schneider
My view is that any tool that imports external data has to be very cautious about additions to the format of that data absent strong guarantees about the effects of these additions. Consider a tool that imports the Wikidata JSON dump, extracts base facts from the dump, and outputs these facts in

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-05 Thread Stas Malyshev
Hi! > Consumers of data generally cannot tell whether the addition of a new field to > a data encoding is a breaking change or not. Given this, code that consumes > encoded data should at least produce warnings when it encounters encodings > that it is not expecting and preferably should refuse

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-05 Thread Daniel Kinzler
Am 05.08.2016 um 17:34 schrieb Peter F. Patel-Schneider: > So some additions are breaking changes then. What is a system that consumes > this information supposed to do? If the system doesn't monitor announcements > then it has to assume that any new field can be a breaking change and thus >

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-05 Thread Daniel Kinzler
Am 05.08.2016 um 15:02 schrieb Peter F. Patel-Schneider: > I side firmly with Markus here. > > Consumers of data generally cannot tell whether the addition of a new field to > a data encoding is a breaking change or not. Without additional information, they cannot know, though for "mix and

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-05 Thread Peter F. Patel-Schneider
I side firmly with Markus here. Consumers of data generally cannot tell whether the addition of a new field to a data encoding is a breaking change or not. Given this, code that consumes encoded data should at least produce warnings when it encounters encodings that it is not expecting and

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-05 Thread Daniel Kinzler
Hi Markus! You are asking use to better communicate changes to our serialization, even if it's not a breaking change according to the spec. I agree we should do that. We are trying to improve our processes to achieve this. Can we ask you in return to try to make your software more robust, by not

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-04 Thread Markus Kroetzsch
Daniel, You present arguments on issues that I would never even bring up. I think we fully agree on many things here. Main points of misunderstanding: * I was not talking about the WMDE definition of "breaking change". I just meant "a change that breaks things". You can define this term for

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-04 Thread Daniel Kinzler
Hi Markus! I would like to elaborate a little on what Lydia said. Am 04.08.2016 um 09:27 schrieb Markus Kroetzsch: > It seems that some changes have been made to the JSON serialization recently: > > https://github.com/Wikidata/Wikidata-Toolkit/issues/237 This specific change has been announced

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-04 Thread Markus Kroetzsch
On 04.08.2016 11:45, Lydia Pintscher wrote: On Thu, Aug 4, 2016 at 9:27 AM, Markus Kroetzsch wrote: Hi, It seems that some changes have been made to the JSON serialization recently: https://github.com/Wikidata/Wikidata-Toolkit/issues/237 Could somebody from

Re: [Wikidata] Breaking change in JSON serialization?

2016-08-04 Thread Lydia Pintscher
On Thu, Aug 4, 2016 at 9:27 AM, Markus Kroetzsch wrote: > Hi, > > It seems that some changes have been made to the JSON serialization > recently: > > https://github.com/Wikidata/Wikidata-Toolkit/issues/237 > > Could somebody from the dev team please comment on

[Wikidata] Breaking change in JSON serialization?

2016-08-04 Thread Markus Kroetzsch
Hi, It seems that some changes have been made to the JSON serialization recently: https://github.com/Wikidata/Wikidata-Toolkit/issues/237 Could somebody from the dev team please comment on this? Is this going to be in the dumps as well or just in the API? Are further changes coming up? Are