[Wikidata-bugs] [Maniphest] [Updated] T49415: creation of new claims (and perhaps other edits) can be (auto)patrolled on wikidata

2015-09-03 Thread Ricordisamoa
Ricordisamoa added a subscriber: Ricordisamoa. Herald added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T49415 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ricordisamoa Cc: Ricordisamoa, Wikidata-bugs, Jdforrester-WMF, Abraha

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T95168: [Task] Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

2015-09-03 Thread Ricordisamoa
Ricordisamoa added a subscriber: Ricordisamoa. TASK DETAIL https://phabricator.wikimedia.org/T95168 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Ricordisamoa Cc: Ricordisamoa, daniel, gerritbot, Addshore, Anomie, aude, Aklapper, Wikidata

[Wikidata-bugs] [Maniphest] [Changed Project Column] T110022: Factor contents of HttpFunctions.php into separate library

2015-09-03 Thread Krinkle
Krinkle moved this task to To Do on the Librarization workboard. TASK DETAIL https://phabricator.wikimedia.org/T110022 WORKBOARD https://phabricator.wikimedia.org/project/board/43/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lydia_P

[Wikidata-bugs] [Maniphest] [Commented On] T110384: Page banner should not render on revisions

2015-09-03 Thread Sumit
Sumit added a comment. Banner has been showing above diff because by nature it is meant to be the first element of page body. For this it uses OutputPage::prependHtml() on page body. In case of a diff, it does not distinguish it from other content. TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T110384: Page banner should not render on revisions

2015-09-03 Thread Nicolas_Raoul
Nicolas_Raoul added a comment. From a user experience point of view, I agree with Tgr that the banner should appear between the diff (or source edit box) and the actual page content, so that the preview is as close to reality as possible. TASK DETAIL https://phabricator.wikimedia.org/T110384

[Wikidata-bugs] [Maniphest] [Updated] T96038: [Bug] wikibase.special.itemDisambiguation.js is broken

2015-09-03 Thread Ricordisamoa
Ricordisamoa added a subscriber: Ricordisamoa. Ricordisamoa added a comment. Fixed by https://gerrit.wikimedia.org/r/233114 as part of https://phabricator.wikimedia.org/T86647. TASK DETAIL https://phabricator.wikimedia.org/T96038 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Edited] T67846: wbeditentity: try to use appropriate autocomment instead of the generic one

2015-09-03 Thread Ricordisamoa
Ricordisamoa edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T67846 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ricordisamoa Cc: thiemowmde, Aklapper, Wikidata-bugs, Addshore, Tobi_WMDE_SW, jayvdb, Ricordisamoa, Lydia_P

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T93853: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page

2015-09-03 Thread Ricordisamoa
Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot. Ricordisamoa removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T93853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW, Ricordisamoa

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T111346: [Bug] Item links on normal wiki pages sometimes prepended by label

2015-09-03 Thread Liuxinyu970226
Liuxinyu970226 added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T111346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Liuxinyu970226 Cc: Liuxinyu970226, aude, daniel, Bene, Aklapper, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T111319: Add PLURAL support for parameters of precision messages

2015-09-03 Thread Liuxinyu970226
Liuxinyu970226 added a blocked task: T40781: Messages needing PLURAL support (tracking). TASK DETAIL https://phabricator.wikimedia.org/T111319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Liuxinyu970226 Cc: Aklapper, Nemo_bis, Wikidata-bugs, aude,

[Wikidata-bugs] [Maniphest] [Updated] T111319: Add PLURAL support for parameters of precision messages

2015-09-03 Thread Liuxinyu970226
Liuxinyu970226 set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Liuxinyu970226 Cc: Aklapper, Nemo_bis, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee ___

[Wikidata-bugs] [Maniphest] [Triaged] T110843: Banners do not show up in mobile editor preview

2015-09-03 Thread Jdlrobson
Jdlrobson triaged this task as "High" priority. Jdlrobson edited projects, added MobileFrontend, Easy; removed Wikidata. Jdlrobson set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T110843 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Closed] T111201: Post-Deployment discussion for Russian Wikivoyage

2015-09-03 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. Let us know if you need any more support or you find any bugs/problems with the software! thanks @atsirlin! TASK DETAIL https://phabricator.wikimedia.org/T111201 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] [Triaged] T110904: Banners should support extraClassNames parameter

2015-09-03 Thread Jdlrobson
Jdlrobson triaged this task as "High" priority. Jdlrobson added a project: Easy. Jdlrobson set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, W

[Wikidata-bugs] [Maniphest] [Changed Project Column] T111201: Post-Deployment discussion for Russian Wikivoyage

2015-09-03 Thread Jdlrobson
Jdlrobson moved this task to Aug 13-> on the Wikidata-Page-Banner workboard. TASK DETAIL https://phabricator.wikimedia.org/T111201 WORKBOARD https://phabricator.wikimedia.org/project/board/1158/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlro

[Wikidata-bugs] [Maniphest] [Commented On] T111304: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on l

2015-09-03 Thread Jdlrobson
Jdlrobson added a subscriber: Jdlrobson. Jdlrobson added a comment. Is this issue likely to be with how WikidataPageBanner is using OOUI or is it an issue in OOUI itself. Can anyone advise? TASK DETAIL https://phabricator.wikimedia.org/T111304 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T110384: Page banner should not render on revisions

2015-09-03 Thread Jdlrobson
Jdlrobson added a subscriber: Nicolas_Raoul. Jdlrobson added a comment. @nicolas_Raoul thoughts on @tgr's comment [1]? Should banners be showing underneath the diff itself? @sumit any idea why they were showing up where they were? [1] https://phabricator.wikimedia.org/T110384#1598347 TASK DETA

[Wikidata-bugs] [Maniphest] [Closed] T110905: Long titles should be truncated automatically

2015-09-03 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T110905 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: gerritbot, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pints

[Wikidata-bugs] [Maniphest] [Updated] T105642: TypeErrors on Wikidata: wb.Site and wikibase.WikibaseContentLanguages are not constructors

2015-09-03 Thread Ricordisamoa
Ricordisamoa added a comment. In https://phabricator.wikimedia.org/T105642#1603796, @He7d3r wrote: > I haven't seen this recently, however I got > > > Error: Syntax error, unrecognized expression: unsupported pseudo: > > wikibase-statementview > https://phabricator.wikimedia.org/T85804? TASK

[Wikidata-bugs] [Maniphest] [Commented On] T78281: Deprecate and remove Claims class

2015-09-03 Thread gerritbot
gerritbot added a comment. Change 235684 merged by Bene: Remove last usages of the Claims class https://gerrit.wikimedia.org/r/235684 TASK DETAIL https://phabricator.wikimedia.org/T78281 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, g

[Wikidata-bugs] [Maniphest] [Commented On] T105642: TypeErrors on Wikidata: wb.Site and wikibase.WikibaseContentLanguages are not constructors

2015-09-03 Thread He7d3r
He7d3r added a comment. I haven't seen this recently, however I got > Error: Syntax error, unrecognized expression: unsupported pseudo: > wikibase-statementview when I opened that URL (both logged in or out), from https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T72209: [Task] Create a special page to query for badges

2015-09-03 Thread He7d3r
He7d3r added a project: user-notice. TASK DETAIL https://phabricator.wikimedia.org/T72209 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, He7d3r Cc: daniel, gerritbot, Jonas, Aklapper, Kopiersperre, jayvdb, Opraco, putnik, AlessioMela, Horcrux9

[Wikidata-bugs] [Maniphest] [Commented On] T111039: [Story] repo edit-summary mechanism on the client: part 4

2015-09-03 Thread gerritbot
gerritbot added a comment. Change 235834 had a related patch set uploaded (by Daniel Kinzler): Pass changeParams through to ChangeLineFormatter, via RevisionData. https://gerrit.wikimedia.org/r/235834 TASK DETAIL https://phabricator.wikimedia.org/T111039 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Factor contents of HttpFunctions.php into separate library

2015-09-03 Thread Addshore
Addshore added a comment. Not really tracked on phab, see https://github.com/addwiki/mediawiki-api-base/issues/5 TASK DETAIL https://phabricator.wikimedia.org/T110022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lydia_Pintscher, Ric

[Wikidata-bugs] [Maniphest] [Updated] T111039: [Story] repo edit-summary mechanism on the client: part 4

2015-09-03 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T111039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, gerritbot Cc: gerritbot, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Commented On] T111039: [Story] repo edit-summary mechanism on the client: part 4

2015-09-03 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 235786 had a related patch set uploaded (by Daniel Kinzler): Generate edit summary in ExternalChangeFactory. https://gerrit.wikimedia.org/r/235786 TASK DETAIL https://phabricator.wikimedia.org/T111039 EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] [Changed Project Column] T99796: [Bug] site_identifiers tables are corrupt

2015-09-03 Thread JanZerebecki
JanZerebecki moved this task to consider for next sprint on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T99796 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Changed Project Column] T77977: [Epic] Unit support

2015-09-03 Thread Johan
Johan moved this task to In current Tech News draft on the user-notice workboard. TASK DETAIL https://phabricator.wikimedia.org/T77977 WORKBOARD https://phabricator.wikimedia.org/project/board/1097/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T99796: [Bug] site_identifiers tables are corrupt

2015-09-03 Thread JanZerebecki
JanZerebecki removed a project: Wikidata-Sprint-2015-09-01. TASK DETAIL https://phabricator.wikimedia.org/T99796 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: gerritbot, hoo, aude, Aklapper, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T111039: [Story] repo edit-summary mechanism on the client: part 4

2015-09-03 Thread daniel
daniel edited the task description. daniel set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Malyacko

[Wikidata-bugs] [Maniphest] [Updated] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread Jc3s5h
Jc3s5h added a comment. In https://phabricator.wikimedia.org/T95425#1603371, @daniel wrote: > @Jc3s5h I don't see how any of the differences you mention are relevant in > the context of precision/uncertainty. Let me give you another example. If you put in a measurement of 725, it goes in the

[Wikidata-bugs] [Maniphest] [Commented On] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread daniel
daniel added a comment. @Jc3s5h I don't see how any of the differences you mention are relevant in the context of precision/uncertainty. TASK DETAIL https://phabricator.wikimedia.org/T95425 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread Jc3s5h
Jc3s5h added a comment. In https://phabricator.wikimedia.org/T95425#1602763, @daniel wrote in part: > @thiemowmde for the same reason 1964 with the precision set to century will > be rendered as 20th century, not 1964+/-50. If you want a solution to be analogous to the way time is handled, the

[Wikidata-bugs] [Maniphest] [Commented On] T111304: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on l

2015-09-03 Thread Anomie
Anomie added a subscriber: Anomie. Anomie added a comment. Unfortunately since it's fataling the request parameters don't make it into api.log. But I only see two things using OOUI\IconWidget: OOUI\FieldLayout, which would probably have run into the problem first before getting to the contained

[Wikidata-bugs] [Maniphest] [Changed Project Column] T111304: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Elemen

2015-09-03 Thread Anomie
Anomie moved this task to Non-core-API stuff on the MediaWiki-API workboard. TASK DETAIL https://phabricator.wikimedia.org/T111304 WORKBOARD https://phabricator.wikimedia.org/project/board/200/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie

[Wikidata-bugs] [Maniphest] [Commented On] T111395: RdfDumpGeneratorTest::testReferenceDedup test failure

2015-09-03 Thread aude
aude added a comment. could be related 20) Wikibase\Test\Rdf\ComplexValueRdfBuilderTest::testAddSnakValue with data set "globecoordinate" (P4, DataValues\Geo\Values\GlobeCoordinateValue, array(' "Point(12.25 -45.5)"^^

[Wikidata-bugs] [Maniphest] [Created] T111343: Various wikibase phpunit failures

2015-09-03 Thread aude
aude created this task. aude added a subscriber: aude. aude added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION I get quite a lot of phpunit test failures when I run tests locally :( some I've had (somewhat) for a while, like number unlocalizer tests, the "KITT

[Wikidata-bugs] [Maniphest] [Triaged] T111343: [Bug] wikibase phpunit failures

2015-09-03 Thread aude
aude triaged this task as "Normal" priority. TASK DETAIL https://phabricator.wikimedia.org/T111343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs, Malyacko ___ Wiki

[Wikidata-bugs] [Maniphest] [Commented On] T111322: Update Quality extensions and Property Suggester to use data movel services 2.0

2015-09-03 Thread aude
aude added a comment. needs https://github.com/Wikidata-lib/PropertySuggester/pull/147 and https://github.com/wmde/WikidataBuildResources/pull/38 TASK DETAIL https://phabricator.wikimedia.org/T111322 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Changed Project Column] T111322: Update Quality extensions and Property Suggester to use data movel services 2.0

2015-09-03 Thread aude
aude moved this task to Review on the Wikidata-Sprint-2015-09-01 workboard. TASK DETAIL https://phabricator.wikimedia.org/T111322 WORKBOARD https://phabricator.wikimedia.org/project/board/1476/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude C

[Wikidata-bugs] [Maniphest] [Claimed] T111322: Update Quality extensions and Property Suggester to use data movel services 2.0

2015-09-03 Thread aude
aude claimed this task. aude set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111322 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Lydia_Pintscher, gerritbot, aude, Aklapper, Wikidata-bugs, Malyacko __

[Wikidata-bugs] [Maniphest] [Changed Project Column] T111342: [Bug] WikiPageEntityRedirectLookup::getRedirectForEntityId does not work correctly for items in main NS

2015-09-03 Thread aude
aude moved this task to Review on the Wikidata-Sprint-2015-09-01 workboard. TASK DETAIL https://phabricator.wikimedia.org/T111342 WORKBOARD https://phabricator.wikimedia.org/project/board/1476/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude C

[Wikidata-bugs] [Maniphest] [Updated] T111342: [Bug] WikiPageEntityRedirectLookup::getRedirectForEntityId does not work correctly for items in main NS

2015-09-03 Thread aude
aude added a project: Wikidata-Sprint-2015-09-01. TASK DETAIL https://phabricator.wikimedia.org/T111342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Aklapper, aude, Wikidata-bugs, Malyacko ___

[Wikidata-bugs] [Maniphest] [Changed Project Column] T111343: [Bug] wikibase phpunit failures

2015-09-03 Thread aude
aude moved this task to Doing on the Wikidata-Sprint-2015-09-01 workboard. TASK DETAIL https://phabricator.wikimedia.org/T111343 WORKBOARD https://phabricator.wikimedia.org/project/board/1476/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc

[Wikidata-bugs] [Maniphest] [Claimed] T111343: [Bug] wikibase phpunit failures

2015-09-03 Thread aude
aude claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T111343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs, Malyacko ___ Wikidata-bugs mailing lis

[Wikidata-bugs] [Maniphest] [Updated] T111343: [Bug] wikibase phpunit failures

2015-09-03 Thread aude
aude added a project: Wikidata-Sprint-2015-09-01. TASK DETAIL https://phabricator.wikimedia.org/T111343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs, Malyacko ___

[Wikidata-bugs] [Maniphest] [Retitled] T111342: [Bug] WikiPageEntityRedirectLookup::getRedirectForEntityId does not work correctly for items in main NS

2015-09-03 Thread aude
aude changed the title from "[Bug] WikiPageEntityStoreTest::testSaveRedirect test failure" to "[Bug] WikiPageEntityRedirectLookup::getRedirectForEntityId does not work correctly for items in main NS". TASK DETAIL https://phabricator.wikimedia.org/T111342 EMAIL PREFERENCES https://phabricato

[Wikidata-bugs] [Maniphest] [Retitled] T111391: [Bug] PropertySuggester\GetSuggestionsTest::testExecution test failure

2015-09-03 Thread aude
aude changed the title from "PropertySuggester\GetSuggestionsTest::testExecution test failure" to "[Bug] PropertySuggester\GetSuggestionsTest::testExecution test failure". aude set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111391 EMAIL PREFERENCES https://phabricator.

[Wikidata-bugs] [Maniphest] [Retitled] T111398: [Bug] TermSqlIndexTest test failures ("KITTENS should have mittens")

2015-09-03 Thread aude
aude changed the title from "TermSqlIndexTest test failures ("KITTENS should have mittens")" to "[Bug] TermSqlIndexTest test failures ("KITTENS should have mittens")". aude set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111398 EMAIL PREFERENCES https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Retitled] T111395: [Bug] RdfDumpGeneratorTest::testReferenceDedup test failure

2015-09-03 Thread aude
aude changed the title from "RdfDumpGeneratorTest::testReferenceDedup test failure" to "[Bug] RdfDumpGeneratorTest::testReferenceDedup test failure". aude set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/

[Wikidata-bugs] [Maniphest] [Updated] T111395: RdfDumpGeneratorTest::testReferenceDedup test failure

2015-09-03 Thread aude
aude added a blocked task: T111343: [Bug] wikibase phpunit failures. TASK DETAIL https://phabricator.wikimedia.org/T111395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs __

[Wikidata-bugs] [Maniphest] [Updated] T111392: [Bug] MwTimeIsoFormatterTest and MediaWikiNumberUnlocalizerTest failures

2015-09-03 Thread aude
aude added a blocked task: T111343: [Bug] wikibase phpunit failures. TASK DETAIL https://phabricator.wikimedia.org/T111392 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs __

[Wikidata-bugs] [Maniphest] [Updated] T98032: Mobile page banner experiment is clashing with WikidataPageBanner

2015-09-03 Thread Jdlrobson
Jdlrobson edited projects, added MobileFrontend; removed Reading-Web. TASK DETAIL https://phabricator.wikimedia.org/T98032 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: gerritbot, Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia

[Wikidata-bugs] [Maniphest] [Updated] T111343: [Bug] wikibase phpunit failures

2015-09-03 Thread aude
aude added blocking tasks: T111398: TermSqlIndexTest test failures ("KITTENS should have mittens"), T111395: RdfDumpGeneratorTest::testReferenceDedup test failure, T111392: [Bug] MwTimeIsoFormatterTest and MediaWikiNumberUnlocalizerTest failures, T111391: PropertySuggester\GetSuggestionsTest::t

[Wikidata-bugs] [Maniphest] [Updated] T111398: TermSqlIndexTest test failures ("KITTENS should have mittens")

2015-09-03 Thread aude
aude added a blocked task: T111343: [Bug] wikibase phpunit failures. TASK DETAIL https://phabricator.wikimedia.org/T111398 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs __

[Wikidata-bugs] [Maniphest] [Updated] T111391: PropertySuggester\GetSuggestionsTest::testExecution test failure

2015-09-03 Thread aude
aude added a blocked task: T111343: [Bug] wikibase phpunit failures. TASK DETAIL https://phabricator.wikimedia.org/T111391 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Aklapper, aude, Wikidata-bugs __

[Wikidata-bugs] [Maniphest] [Updated] T111390: [Bug] RepoHooksTest::testImportHandleRevisionXMLTag_hook test failure

2015-09-03 Thread aude
aude added a blocked task: T111343: [Bug] wikibase phpunit failures. TASK DETAIL https://phabricator.wikimedia.org/T111390 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: aude, Aklapper, Wikidata-bugs __

[Wikidata-bugs] [Maniphest] [Created] T111398: TermSqlIndexTest test failures ("KITTENS should have mittens")

2015-09-03 Thread aude
aude created this task. aude added a subscriber: aude. aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Herald added a subscriber: Aklapper. TASK DESCRIPTION ``` 43) Wikibase\Test\TermSqlIndexTest::testGetMatchingTerms with data set "orderByWeight, prefixSearch and case

[Wikidata-bugs] [Maniphest] [Commented On] T111390: [Bug] RepoHooksTest::testImportHandleRevisionXMLTag_hook test failure

2015-09-03 Thread aude
aude added a comment. possibly related 19) Wikibase\Tests\RepoHooksTest::testOnImportHandleRevisionXMLTag with data set "item" (array('wikibase-item'), 'MWException') Failed asserting that exception of type "MWException" is thrown. /var/www/wiki/w/tests/phpunit/MediaWikiTestCase.php:131

[Wikidata-bugs] [Maniphest] [Commented On] T111392: [Bug] MwTimeIsoFormatterTest and MediaWikiNumberUnlocalizerTest failures

2015-09-03 Thread aude
aude added a comment. probably related 16) Wikibase\Test\MessageParameterFormatterTest::testFormat with data set "float en" (123.456, 'en', '123.456') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'123.456' +'123,456' /var/www/wiki/w/extensions/W

[Wikidata-bugs] [Maniphest] [Created] T111395: RdfDumpGeneratorTest::testReferenceDedup test failure

2015-09-03 Thread aude
aude created this task. aude added a subscriber: aude. aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Herald added a subscriber: Aklapper. TASK DESCRIPTION ``` 15) Wikibase\Test\Dumpers\RdfDumpGeneratorTest::testReferenceDedup with data set "references" (array(Q7,

[Wikidata-bugs] [Maniphest] [Retitled] T111392: [Bug] MwTimeIsoFormatterTest and MediaWikiNumberUnlocalizerTest failures

2015-09-03 Thread aude
aude changed the title from "MwTimeIsoFormatterTest test failures" to "[Bug] MwTimeIsoFormatterTest and MediaWikiNumberUnlocalizerTest failures". aude set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111392 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pane

[Wikidata-bugs] [Maniphest] [Created] T111392: MwTimeIsoFormatterTest test failures

2015-09-03 Thread aude
aude created this task. aude added subscribers: Aklapper, aude. aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. TASK DESCRIPTION when running tests locally ``` 1) ValueFormatters\Test\MwTimeIsoFormatterTest::testFormat with data set #80 ('', +9

[Wikidata-bugs] [Maniphest] [Created] T111391: PropertySuggester\GetSuggestionsTest::testExecution test failure

2015-09-03 Thread aude
aude created this task. aude added subscribers: aude, Aklapper. aude added projects: MediaWiki-extensions-WikibaseRepository, Wikidata. TASK DESCRIPTION when running tests locally ``` PropertySuggester\GetSuggestionsTest::testExecution DBQueryError: A database error has occurred. Did yo

[Wikidata-bugs] [Maniphest] [Created] T111390: [Bug] RepoHooksTest::testImportHandleRevisionXMLTag_hook test failure

2015-09-03 Thread aude
aude created this task. aude added a subscriber: aude. aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Herald added a subscriber: Aklapper. TASK DESCRIPTION when running tests locally: ``` 1) Wikibase\Tests\RepoHooksTest::testImportHandleRevisionXMLTag_hook with d

[Wikidata-bugs] [Maniphest] [Commented On] T111342: [Bug] WikiPageEntityStoreTest::testSaveRedirect test failure

2015-09-03 Thread aude
aude added a comment. https://gerrit.wikimedia.org/r/#/c/235757/ TASK DETAIL https://phabricator.wikimedia.org/T111342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Aklapper, aude, Wikidata-bugs, Malyacko __

[Wikidata-bugs] [Maniphest] [Claimed] T111342: [Bug] WikiPageEntityStoreTest::testSaveRedirect test failure

2015-09-03 Thread aude
aude triaged this task as "Normal" priority. aude claimed this task. aude added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T111342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Aklapper, aude, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Updated] T77977: [Epic] Unit support

2015-09-03 Thread matej_suchanek
matej_suchanek added a project: user-notice. TASK DETAIL https://phabricator.wikimedia.org/T77977 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Popcorndude, Darkdadaah, matej_suchanek, Mbch331, Jc3s5h, Mike_Peel, Luke081515, Wolf

[Wikidata-bugs] [Maniphest] [Commented On] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread daniel
daniel added a comment. @thiemowmde for the same reason 1964 with the precision set to century will be rendered as 20th century, not 1964+/-50. Basically, we have two conflicting principles here: the principle of least surprise agrees with you thiemo (I entered one thing, but see another, wtf?)

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread thiemowmde
thiemowmde added subscribers: Lydia_Pintscher, Addshore. thiemowmde added a comment. This discussion was frustrating from the start and obviously not going anywhere. I think I already said multiple times that this bug is not about "false precision", whatever that means in the context of the give

[Wikidata-bugs] [Maniphest] [Updated] T111304: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on line 1

2015-09-03 Thread Jdforrester-WMF
Jdforrester-WMF added a project: Wikidata-Page-Banner. Herald added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T111304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: Legoktm, Krenair, Jdforrester-WMF, Aklap

[Wikidata-bugs] [Maniphest] [Commented On] T111342: [Bug] WikiPageEntityStoreTest::testSaveRedirect test failure

2015-09-03 Thread aude
aude added a comment. the problem happens with items in the main namespace. I have a fix (trivial), but also am working on adding tests for this. TASK DETAIL https://phabricator.wikimedia.org/T111342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T87759: [Story] Allow simultaneous editing of mainsnak and references

2015-09-03 Thread gerritbot
gerritbot added a comment. Change 223542 abandoned by Thiemo Mättig (WMDE): Make referencesChanger optional in the referenceview widget https://gerrit.wikimedia.org/r/223542 TASK DETAIL https://phabricator.wikimedia.org/T87759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Commented On] T87759: [Story] Allow simultaneous editing of mainsnak and references

2015-09-03 Thread gerritbot
gerritbot added a comment. Change 224074 merged by Thiemo Mättig (WMDE): Add missing listview dependencies to toolbar controllers https://gerrit.wikimedia.org/r/224074 TASK DETAIL https://phabricator.wikimedia.org/T87759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/em

[Wikidata-bugs] [Maniphest] [Commented On] T87759: [Story] Allow simultaneous editing of mainsnak and references

2015-09-03 Thread gerritbot
gerritbot added a comment. Change 224076 abandoned by Thiemo Mättig (WMDE): Add combined statementview-referenceview remove toolbar https://gerrit.wikimedia.org/r/224076 TASK DETAIL https://phabricator.wikimedia.org/T87759 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/

[Wikidata-bugs] [Maniphest] [Commented On] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread Jc3s5h
Jc3s5h added a comment. In https://phabricator.wikimedia.org/T95425#1602377, @daniel wrote in part: > > We could just drop rounding, but that would lead to //false precision// when > applying unit conversion. So we could apply rounding only if we do conversion > - but that would be even mor

[Wikidata-bugs] [Maniphest] [Commented On] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread daniel
daniel added a comment. Round trip stability for rendered output is nice, but was never a design goal. In fact, it doesn't work for most things. If this is not about editing, saying it causes "data loss" is misleading. "Quantity rendering does not preserve precision" would be descriptive. But

[Wikidata-bugs] [Maniphest] [Edited] T48643: [Story] Dispatching via delayed jobs (instead of cron script)

2015-09-03 Thread daniel
daniel edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T48643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Tobi_WMDE_SW, JanZerebecki, Wikidata-bugs, Abraham, Nemo_bis, Denny, aude, Ricordisamoa, Lyd

[Wikidata-bugs] [Maniphest] [Edited] T108944: [Epic] Improve change dispatching

2015-09-03 Thread daniel
daniel edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T108944 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: hoo, Lydia_Pintscher, Jonas, Aklapper, Wikidata-bugs, aude, Malyacko __

[Wikidata-bugs] [Maniphest] [Updated] T70381: [Task] [Dispatch via delayed job] Implement the trigger job

2015-09-03 Thread daniel
daniel removed a blocked task: T108944: [Epic] Improve change dispatching. TASK DETAIL https://phabricator.wikimedia.org/T70381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Wikidata-bugs, Tobi_WMDE_SW, aude _

[Wikidata-bugs] [Maniphest] [Edited] T111356: [Story] wb_changes.change_info should only contain the minimum of information required for processing the change on the client.

2015-09-03 Thread daniel
daniel edited the task description. daniel set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111356 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, Aklapper, Jonas, Lydia_Pintscher, hoo, Wikidata-bugs, aude, Malya

[Wikidata-bugs] [Maniphest] [Edited] T109821: [Task] Avoid unserializing metadata, especially diffs, when processing changes

2015-09-03 Thread daniel
daniel edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T109821 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, daniel, Wikidata-bugs, aude, GWicke, Malyacko ___

[Wikidata-bugs] [Maniphest] [Edited] T109821: [Task] Avoid unserializing metadata, especially diffs, when processing changes

2015-09-03 Thread daniel
daniel edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T109821 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, daniel, Wikidata-bugs, aude, GWicke, Malyacko ___

[Wikidata-bugs] [Maniphest] [Updated] T70382: [Task] [Dispatch via delayed job] schedule trigger jobs on each change

2015-09-03 Thread daniel
daniel removed a blocked task: T108944: [Epic] Improve change dispatching. TASK DETAIL https://phabricator.wikimedia.org/T70382 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Wikidata-bugs, Tobi_WMDE_SW, aude _

[Wikidata-bugs] [Maniphest] [Updated] T108944: [Epic] Improve change dispatching

2015-09-03 Thread daniel
daniel removed blocking tasks: T111353: understand MW jobQueue system and write RFC on how dispatching will use it, T70381: [Task] [Dispatch via delayed job] Implement the trigger job, T70382: [Task] [Dispatch via delayed job] schedule trigger jobs on each change. TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Updated] T111353: understand MW jobQueue system and write RFC on how dispatching will use it

2015-09-03 Thread daniel
daniel added a blocked task: T48643: [Story] Dispatching via delayed jobs (instead of cron script). TASK DETAIL https://phabricator.wikimedia.org/T111353 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: aude, Addshore, daniel, JanZerebecki,

[Wikidata-bugs] [Maniphest] [Updated] T111353: understand MW jobQueue system and write RFC on how dispatching will use it

2015-09-03 Thread daniel
daniel removed a blocked task: T108944: [Epic] Improve change dispatching. TASK DETAIL https://phabricator.wikimedia.org/T111353 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: aude, Addshore, daniel, JanZerebecki, Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Updated] T48643: [Story] Dispatching via delayed jobs (instead of cron script)

2015-09-03 Thread daniel
daniel added a blocking task: T111353: understand MW jobQueue system and write RFC on how dispatching will use it. TASK DETAIL https://phabricator.wikimedia.org/T48643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Tobi_WMDE_SW,

[Wikidata-bugs] [Maniphest] [Retitled] T48643: [Story] Dispatching via delayed jobs (instead of cron script)

2015-09-03 Thread daniel
daniel changed the title from "[Task] Dispatching via delayed jobs (instead of cron script)" to "[Story] Dispatching via delayed jobs (instead of cron script)". TASK DETAIL https://phabricator.wikimedia.org/T48643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Created] T111356: [Story] wb_changes.change_info should only contain the minimum of information required for processing the change on the client.

2015-09-03 Thread daniel
daniel created this task. daniel added subscribers: hoo, Lydia_Pintscher, Jonas, Aklapper, daniel. daniel added projects: Epic, Wikidata. TASK DESCRIPTION Unserializing large object structures is expensive, and it's bogging down change dispatching on the repo as well as change handling on the c

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T65411: wikis not removed from wb_changes_dispatch table when removed from localClientDatabases setting

2015-09-03 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. Herald added a subscriber: Aklapper. I'm unsure how to best solve this. We could: - automatically remove the old wiki from wb_changes_dispatch. Disadvantage: if you add the wiki back, the dispatcher would then send //everything// to it,

[Wikidata-bugs] [Maniphest] [Created] T111353: understand MW jobQueue system and write RFC on how dispatching will use it

2015-09-03 Thread JanZerebecki
JanZerebecki created this task. JanZerebecki added subscribers: hoo, Lydia_Pintscher, Aklapper, JanZerebecki, daniel, Addshore, aude. JanZerebecki added a project: Wikidata. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T111353 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T111346: [Bug] Item links on normal wiki pages sometimes prepended by label

2015-09-03 Thread daniel
daniel added a comment. @bene huh, strange. I was under the impression that the Linker was not used for vanilla wiki links at all, so our hook code shouldn't ever be triggered for that. perhaps that changed? TASK DETAIL https://phabricator.wikimedia.org/T111346 EMAIL PREFERENCES https://p

[Wikidata-bugs] [Maniphest] [Triaged] T111346: [Bug] Item links on normal wiki pages sometimes prepended by label

2015-09-03 Thread daniel
daniel triaged this task as "High" priority. daniel added a comment. Causes broken & confusing page rendering TASK DETAIL https://phabricator.wikimedia.org/T111346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: aude, daniel, Bene, Aklapp

[Wikidata-bugs] [Maniphest] [Updated] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread thiemowmde
thiemowmde added a comment. I changed the tasks description because when I reported this bug it was never exclusively about editing. The editing issue was fixed in https://github.com/wmde/ValueView/pull/183/files#diff-6e3ed44714251084b2ff46be5bb6b80fR54, as a side effect while working on T11018

[Wikidata-bugs] [Maniphest] [Retitled] T95425: [Bug] Quantity formatter rounding causes significant data loss

2015-09-03 Thread thiemowmde
thiemowmde changed the title from "[Bug] Quantity rounding causes data loss when editing" to "[Bug] Quantity formatter rounding causes significant data loss". thiemowmde edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T95425 EMAIL PREFERENCES https://phabricator.w

[Wikidata-bugs] [Maniphest] [Unblock] T108944: [Epic] Improve change dispatching

2015-09-03 Thread daniel
daniel closed blocking task T111008: Deserialize only the site link diff when dispatching changes as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T108944 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: hoo, Lydia_Pintscher, Jon

[Wikidata-bugs] [Maniphest] [Closed] T111008: Deserialize only the site link diff when dispatching changes

2015-09-03 Thread daniel
daniel closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T111008 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: aude, Aklapper, Wikidata-bugs, Malyacko ___ Wikidata-

[Wikidata-bugs] [Maniphest] [Commented On] T111346: [Bug] Item links on normal wiki pages sometimes prepended by label

2015-09-03 Thread Bene
Bene added a comment. Something like === {{P|131}}: Conflicts with === * [[Q3317390]]: [[Property:P31]] * [[Q3492538]]: [[Property:P31]] * [[Q3801388]]: [[Property:P31]] * [[Q4118344]]: [[Property:P31]] * [[Q4808232]]: [[Property:P31]] * [[Q4837847]]: [[Property:P31]] * [[Q4926792

[Wikidata-bugs] [Maniphest] [Commented On] T111346: [Bug] Item links on normal wiki pages sometimes prepended by label

2015-09-03 Thread daniel
daniel added a comment. Please also provide the relevant wikitext. I suspect this has something to do with some parser function or other. TASK DETAIL https://phabricator.wikimedia.org/T111346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel C

  1   2   >