Smalyshev added a comment.
The fix may be to use continuations at least for changes that are safe to do so (non-current ones, tail poller, etc.) Not sure what to do for recent ones - probably just skip a second, even though it risks losing changes?TASK
Smalyshev created this task.Smalyshev added projects: Wikidata-Query-Service, Discovery-Wikidata-Query-Service-Sprint.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery.
TASK DESCRIPTIONIf Updater is used with short batchSize (e.g. --batchSize 4) it gets stuck since it
gerritbot added a comment.
Change 345627 merged by Krinkle:
[mediawiki/extensions/WikibaseQuality@master] Use full qualified names in @uses/@covers in PHPUnit
https://gerrit.wikimedia.org/r/345627TASK DETAILhttps://phabricator.wikimedia.org/T161721EMAIL
gerritbot added a comment.
Change 345628 merged by Krinkle:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use full qualified names in @uses/@covers in PHPUnit
https://gerrit.wikimedia.org/r/345628TASK DETAILhttps://phabricator.wikimedia.org/T161720EMAIL
gerritbot added a comment.
Change 345629 merged by Krinkle:
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Use full qualified names in @uses/@covers in PHPUnit
https://gerrit.wikimedia.org/r/345629TASK DETAILhttps://phabricator.wikimedia.org/T161718EMAIL
Krinkle closed subtask T93404: [Task] run phpunit ResourcesTest from core for wikibase as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T108946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Liuxinyu970226, Ricordisamoa, Aklapper,
Krinkle closed this task as "Resolved".Krinkle claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T93404EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: hashar, Lydia_Pintscher, gerritbot, JanZerebecki, Aklapper, QZanden, Salgo60,
Jonas created this task.Jonas added projects: Wikidata-Sprint, Regression, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONF7222140: pasted_fileTASK DETAILhttps://phabricator.wikimedia.org/T162198EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Dvorapa added a project: MediaWiki-General-or-Unknown.
TASK DETAILhttps://phabricator.wikimedia.org/T159654EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, Dvorapa, 45Jayjay1969, QZanden, Salgo60, SamanthaNguyen, D3r1ck01, Izno,
daniel added a subscriber: aude.daniel added a comment.
@hoo @aude Are you ok with merging/deploying the config patch?
I'd like to test this as follows:
stop the dispatch script for a while.
do lots of edits
run a bunch of dispatcher instances in parallel
make sure there are no errors
somehow
hashar edited the task description. (Show Details)
EDIT DETAILSWe have an issue with the MediaWiki tests when running them on the 4GB RAM instances. We would need either RAM or Swap to be added to the Nodepool image.
Project Name: `contintcloud`
Private Flavor: 6G RAM / 2 vCPU / 40 Disk
---
hashar added a parent task: T140904: Existing Labs project quota increase requests (Tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T162166EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: StudiesWorld, JanZerebecki, Aklapper, hoo, Paladox,
hashar edited the task description. (Show Details)
EDIT DETAILS...Alternatively, instead of adding more RAM, we could create a flavor with less disk (40G -> 35G) and a 5G Swap. I have no idea how the boot would manage to find it though, potentially labelled `disk.swap`.
TASK
hashar created this task.hashar added projects: Wikidata, MediaWiki-extensions-Scribunto, Continuous-Integration-Config, Labs.
TASK DESCRIPTIONWe have an issue with the MediaWiki tests when running them on the 4GB RAM instances. We would need either RAM or Swap to be added to the Nodepool image.
hashar created subtask T162166: For contintcloud either add RAM or Swap to the instances.
TASK DETAILhttps://phabricator.wikimedia.org/T125050EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: greg, Legoktm, Krinkle, Stashbot, Lydia_Pintscher,
Fnielsen added a comment.
I suppose that a warning message could be annoying.
Another related issue is that the Clear button is pretty close to the Run button. This may also accidentally result in loss of input.TASK DETAILhttps://phabricator.wikimedia.org/T162156EMAIL
hashar added a comment.
Note to self, diskimage-builder wipe out /etc/fstab:
elements/debootstrap/install.d/15-cleanup-debootstrapcat << EOF | tee /etc/fstab > /dev/null
proc /proc proc nodev,noexec,nosuid 0 0
LABEL=${DIB_ROOT_LABEL} / ${FS_TYPE} errors=remount-ro 0 1
EOF
Eg there is no swap
Jonas added a comment.
Further investigated:
entity.getStatements();
In getStatementGroupListView() in ViewFactory.js does not return Statements.TASK DETAILhttps://phabricator.wikimedia.org/T162025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc:
hoo removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T155166EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, Tgr, hoo, Lucie, Lydia_Pintscher, Micru, SacredWKnight, Aklapper, QZanden, Salgo60, D3r1ck01, Izno,
hoo closed this task as "Resolved".hoo moved this task from Review to Done on the Wikidata-Sprint board.
TASK DETAILhttps://phabricator.wikimedia.org/T155166WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL
gerritbot added a comment.
Change 346167 merged by Hoo man:
[mediawiki/extensions/ArticlePlaceholder@master] Add a name to CreateArticleDialog.
https://gerrit.wikimedia.org/r/346167TASK DETAILhttps://phabricator.wikimedia.org/T155166EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-04-04T16:03:32Z] Updated the Wikidata property suggester with data from last Monday's JSON dump and applied the T132839 workaroundsTASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL
Lucas_Werkmeister_WMDE added a comment.
The current revision ID isn’t synced back to the config, but stored in the RevisionStore – per claim. That’s why you get that warning even during normal editing when adding new statements: the RevisionStore doesn’t have a revision ID for that claim yet (it’s
gerritbot added a comment.
Change 345329 merged by Jonas Kress (WMDE):
[mediawiki/extensions/WikibaseLexeme@master] Add section header for senses.
https://gerrit.wikimedia.org/r/345329TASK DETAILhttps://phabricator.wikimedia.org/T161523EMAIL
Jheald created this task.Jheald added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONThe UI for categorisation on Commons has a very nice feature that next to categories there is a down-arrow link, that when clicked presents sub-categories of the current category for
gerritbot added a comment.
Change 346312 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Proper fix for namespace registration issue
https://gerrit.wikimedia.org/r/346312TASK DETAILhttps://phabricator.wikimedia.org/T162154EMAIL
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T162154EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDE, gerritbotCc: gerritbot, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60,
Jheald added a comment.
+1 on the need for this.
As WD statements become ever more extended, accumulating qualifiers, references, rankings etc, it becomes more and more of a pain to execute if/when a statement has to be moved from one item to a different item. At the moment it requires
gerritbot added a comment.
Change 345590 merged by Jakob:
[mediawiki/extensions/WikibaseLexeme@master] Add browsertests for List of Forms
https://gerrit.wikimedia.org/r/345590TASK DETAILhttps://phabricator.wikimedia.org/T160522EMAIL
Jonas added a comment.
Actually we had a feature to save the latest query in the browser storage
Which we had to kill, because of a complaint T128851: https://query.wikidata.org/ loads old queries instead of starting a new query
I would rather enable that feature again instead of that warning,
hoo closed subtask T55562: [Bug] Special:UnconnectedPages lists connected pages as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T96040EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Luke081515, Liuxinyu970226, aude, Aklapper, QZanden,
hoo closed this task as "Resolved".hoo claimed this task.hoo added a comment.Herald added a subscriber: TerraCodes.
This is not actionable.
Due to infrastructure problems very rarely such things might happen, but that's not specific to Wikibase. Also this is only derived data, so it's acceptable
Lydia_Pintscher triaged this task as "Low" priority.Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
TASK DETAILhttps://phabricator.wikimedia.org/T162153WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL
Fnielsen created this task.Fnielsen added a project: Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery.
TASK DESCRIPTIONWhen editing in the input of the Wikidata Query Service the browser can be closed without any warning. If the browser window
Jonas created this task.Jonas added projects: Wikidata, Wikidata-Sprint.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONWe had to insert a hack to make the namespace registration work.
https://gerrit.wikimedia.org/r/#/c/346153/2/src/WikibaseLexeme.hooks.php
// FIXME: Ugly hack find solution
gerritbot added a comment.
Change 345586 merged by Jonas Kress (WMDE):
[mediawiki/extensions/WikibaseLexeme@master] Add language attribute and Form ID class to Form of a Lexeme
https://gerrit.wikimedia.org/r/345586TASK DETAILhttps://phabricator.wikimedia.org/T160522EMAIL
Zoglun added a comment.Herald added a project: Discovery-Search.
When will this bug get fix? Using Redis instead of mysql to store jobs now.
However, We can't afford a large memory, which made jobs stored in Redis been truncated when reaching memory cap (2,000 to 3,000 jobs).TASK
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added a project: Discovery.
TASK DESCRIPTIONThere seems to be a client-side memory leak in the query service. If you keep running new queries,
jcrespo added a comment.
Thank you again!TASK DETAILhttps://phabricator.wikimedia.org/T160887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: gerritbot, Lydia_Pintscher, thiemowmde, Marostegui, aude, hoo, daniel, Aklapper, jcrespo, QZanden, Salgo60,
aude added a comment.
@jcrespo we backported/deployed this last ThursdayTASK DETAILhttps://phabricator.wikimedia.org/T160887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: gerritbot, Lydia_Pintscher, thiemowmde, Marostegui, aude, hoo, daniel,
jcrespo added a comment.
Thank you very much for working on this- do you have an estimation on when this will be fully deployed?TASK DETAILhttps://phabricator.wikimedia.org/T160887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: gerritbot,
aude closed this task as "Resolved".aude removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T160887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: gerritbot, Lydia_Pintscher, thiemowmde, Marostegui, aude, hoo, daniel,
daniel added a comment.
@hoo The all-option has been removed, as per T161631.
@aude Having a limit on the offset would be good, if we can't implement paging based on a unique key. But I suppose that is worth a separate ticket. This one can then be closed. The issues for the live site should be
aude added a comment.
think we can mark this as resolved? If we think necessary, can add a limit for offsetTASK DETAILhttps://phabricator.wikimedia.org/T160887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: gerritbot, Lydia_Pintscher, thiemowmde,
aude added a comment.
think there already is a limit of 5000TASK DETAILhttps://phabricator.wikimedia.org/T160887EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: gerritbot, Lydia_Pintscher, thiemowmde, Marostegui, aude, hoo, daniel, Aklapper, jcrespo,
hashar added a comment.
--log-junit is what fails the build so no.
What fork() is doing is that it tries to allocate the whole virtual memory from the caller. In a trace above the PHP process had 1.8G and the system had 562M free + 959 cached. .That is not enough reclaimable memory to fit the
hoo removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T161577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: daniel, WMDE-leszek, gerritbot, hoo, ArielGlenn, Gehel, EBernhardson, Lunewa, QZanden, Salgo60, D3r1ck01, Izno,
hoo closed this task as "Resolved".hoo claimed this task.hoo added a comment.
The immediate issue in question has been resolved by switching our dumpers back to Zend php.
For fixing the actual memory leak, please see T161695: Wikidata dump maintenance scripts cause HHVM to leak memory
hoo added a comment.
I looked into this briefly today and it seems that it's not caused by any HHVM special handling within one of the Wikibase components, thus we are probably indeed dealing with a HHVM bug.TASK DETAILhttps://phabricator.wikimedia.org/T161695EMAIL
hoo added a comment.
@hashar If we can't allocate more resources, can we disable --log-junit for just this job for now?TASK DETAILhttps://phabricator.wikimedia.org/T125050EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Krinkle, Stashbot,
daniel added a comment.
In T161527#3152755, @Smalyshev wrote:
Perhaps https://commons.wikimedia.org/data-mediainfo/File:Foo.jpg
So what would be the content of https://commons.wikimedia.org/data/File:Foo.jpg then? I'm still not clear on why would we need several data slots on the same page.
hoo created this task.hoo added projects: ArticlePlaceholder, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONPer T156832: [RfC] Decide whether to index not-notable placeholders placeholders that are not-notable, but are covered by ArticlePlaceholderSearchEngineIndexed should have
hashar added a comment.
Ran the whole suite again with the ulimit in place but without --log-junit which is memory heavy. The whole suite pass just fine and there are no fork() issues.
debug log reports 912.2M and PHPUnit reports 924.50MB
So my best guess is that:
our code invokes
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).
TASK DETAILhttps://phabricator.wikimedia.org/T160931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, ReleaseTaggerBotCc: gerritbot, Addshore, Aklapper,
Addshore closed this task as "Resolved" by committing R1890:53463ec61292: Use onContentAlterParserOutput hook.
TASK DETAILhttps://phabricator.wikimedia.org/T160931EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Aklapper,
gerritbot added a comment.
Change 343261 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Use onContentAlterParserOutput hook
https://gerrit.wikimedia.org/r/343261TASK DETAILhttps://phabricator.wikimedia.org/T160931EMAIL
hashar added a comment.
Gave it a try directly on the instance running solely the Scribunto tests after the memory limit got raised to 70M which ends up being ulimit -v 68359.
WORKSPACE=/home/jenkins/workspace/mwext-testextension-php55-composer-trusty \
php tests/phpunit/phpunit.php
hoo added a comment.
In T125050#3152305, @hashar wrote:
What this show is that at the point I took the capture, there were several Scribunto/engines/LuaStandalone/binaries/lua5_1_5_linux_64_generic/lua process running. I guess they are on hold somehow. Though the lua_ulimit.sh does not appear.
Nemo_bis closed subtask T160865: Create Wikipedia Khowar as "Declined".
TASK DETAILhttps://phabricator.wikimedia.org/T18976EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Nemo_bisCc: StevenJ81, Acer, Danny_B, TerraCodes, JEumerus, greg, Krenair, Aklapper,
59 matches
Mail list logo
