[Wikidata-bugs] [Maniphest] [Updated] T191413: PHP error when purging page in entity namespace with non-entity ID title

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic. TASK DETAILhttps://phabricator.wikimedia.org/T191413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Retitled] T191413: PHP error when purging page in entity namespace with non-entity ID title

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "Argument 1 passed to WikibaseQuality\ConstraintReport\Api\ResultsCache::delete() must be an instance of Wikibase\DataModel\Entity\EntityId, null given" to "PHP error when purging page in entity namespace with non-entity ID title". TASK

[Wikidata-bugs] [Maniphest] [Commented On] T191413: Argument 1 passed to WikibaseQuality\ConstraintReport\Api\ResultsCache::delete() must be an instance of Wikibase\DataModel\Entity\EntityId, null giv

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I can also provoke the same error by visiting https://www.wikidata.org/w/index.php?title=T191413="">, so we definitely can’t fix this error in all cases, the title might just be garbage :)TASK DETAILhttps://phabricator.wikimedia.org/T191413EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T191413: Argument 1 passed to WikibaseQuality\ConstraintReport\Api\ResultsCache::delete() must be an instance of Wikibase\DataModel\Entity\EntityId, null giv

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Ah, I think I see where the problem comes from… this is the request URL (with the numeric part of the item ID redacted): /w/index.php?title=Q█/=""> The trailing slash is probably the reason for the error – the page still has an entity content

[Wikidata-bugs] [Maniphest] [Commented On] T173971: Get community input on tools, bots and workflows on Wikimedia Commons that will likely be affected by Structured Data on Commons.

2018-04-04 Thread Qgil
Qgil added a comment. What is the status of this task? #liaisons-jan-mar-2018 is over, and we need to move out or resolve it.TASK DETAILhttps://phabricator.wikimedia.org/T173971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SandraF_WMF, QgilCc: Qgil, 0x010C,

[Wikidata-bugs] [Maniphest] [Edited] T191413: Argument 1 passed to WikibaseQuality\ConstraintReport\Api\ResultsCache::delete() must be an instance of Wikibase\DataModel\Entity\EntityId, null given

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Only happened once in the past 24 hours. Request URL indicates someone was purging an item (let’s redact which one it was, it probably doesn’t matter – but the item exists and has no recent log

[Wikidata-bugs] [Maniphest] [Created] T191413: Argument 1 passed to WikibaseQuality\ConstraintReport\Api\ResultsCache::delete() must be an instance of Wikibase\DataModel\Entity\EntityId, null given

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality, Wikibase-Quality-Constraints, Wikimedia-log-errors.Herald added a subscriber: Aklapper. TASK DESCRIPTIONFound in Logstash: PHP Error: Argument 1 passed to

[Wikidata-bugs] [Maniphest] [Commented On] T190670: Unclear behavior of grammatical feature diff headers

2018-04-04 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Let's remove the numbers from the breadcrumbs. As for the hardcoding of the /: Yes it should be / like in item diffs. Is it hardcoded there? Do the same as done there.TASK DETAILhttps://phabricator.wikimedia.org/T190670EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423915 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] Add test for LexemeContent::getPatchedCopy https://gerrit.wikimedia.org/r/423915TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T179155: Find a better solution for dewiki's Modul:Wikidata isParent

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. What happens when Kreuzberg has more than one “instance of” statements? Should the surrounding Lua code then call mw.wikibase.isInHierarchy / mw.wikibase.getClosestInHierarchy in a loop? I wonder if it’s necessary to support a list of fromIds instead of a

[Wikidata-bugs] [Maniphest] [Updated] T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap

2018-04-04 Thread TheDJ
TheDJ added a parent task: T191405: Mark interwiki links as external links when they fall outside the WMF family. TASK DETAILhttps://phabricator.wikimedia.org/T113034EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, TheDJCc: Ladsgroup, kchapman,

[Wikidata-bugs] [Maniphest] [Commented On] T179155: Find a better solution for dewiki's Modul:Wikidata isParent

2018-04-04 Thread hoo
hoo added a comment. Moved this to review to gather comments about my proposal (T179155#4102708).TASK DETAILhttps://phabricator.wikimedia.org/T179155EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Lucas_Werkmeister_WMDE, thiemowmde, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Changed Project Column] T183837: Wikidata Edit-a-thon 2018 in Buea

2018-04-04 Thread Qgil
Qgil moved this task from Jan-Mar-2018 to Apr-Jun-2018 on the Developer-Relations board.Qgil edited projects, added Developer-Relations (Apr-Jun-2018); removed Developer-Relations (Jan-Mar-2018). TASK

[Wikidata-bugs] [Maniphest] [Updated] T135147: Make the domain model implemented by Site/SiteLookup/SiteStore more flexible

2018-04-04 Thread TheDJ
TheDJ added a parent task: T7501: Expand prefix of interproject link when showing the link in the tooltip. TASK DETAILhttps://phabricator.wikimedia.org/T135147EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, TheDJCc: WMDE-leszek, Zppix, Smalyshev,

[Wikidata-bugs] [Maniphest] [Commented On] T189185: [Bug] possible to remove last lemma

2018-04-04 Thread WMDE-leszek
WMDE-leszek added a comment. I've had a stab at making constructor parameters related to required properties of Lexeme non-nullable and it seems to break several places where there are explicit new Lexeme() calls. It seems there are several situations the "empty" lexeme has been created, as

[Wikidata-bugs] [Maniphest] [Commented On] T190921: Editing Lexeme: Hide GUI buttons w/o permission

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423877 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Allow ReadModeViewFactory to be overridden by extensions. https://gerrit.wikimedia.org/r/423877TASK DETAILhttps://phabricator.wikimedia.org/T190921EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T190921: Editing Lexeme: Hide GUI buttons w/o permission

2018-04-04 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T190921EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, WMDE-leszek, Aklapper, Lydia_Pintscher, Pablo-WMDE, Versusxo,

[Wikidata-bugs] [Maniphest] [Claimed] T164372: Implement “Units” constraint

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a subscriber: Ladsgroup. TASK DETAILhttps://phabricator.wikimedia.org/T164372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Assigned] T170610: Add “no bounds” constraint

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE assigned this task to Ladsgroup.Herald added a project: User-Ladsgroup. TASK DETAILhttps://phabricator.wikimedia.org/T170610EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Closed] T191016: Constraint checks on empty items have empty depended entity IDs

2018-04-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Invalid".Lucas_Werkmeister_WMDE moved this task from Tasks to Done on the Wikidata-Ministry-Of-Magic board.Lucas_Werkmeister_WMDE added a comment. The last event with this message in logstash was on 2018-04-02T21:24:45. A few minutes later, group1 moved

[Wikidata-bugs] [Maniphest] [Claimed] T190924: Editing Lexeme: Check permission in APIs

2018-04-04 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T190924EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: WMDE-leszek, Aklapper, Lydia_Pintscher, Pablo-WMDE, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423872 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] Also check forms diff in LexemeDiff::isEmpty https://gerrit.wikimedia.org/r/423872TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread Addshore
Addshore added a comment. It looks like this is specifically to do with undoing of an edit that adds a grammatical feature.TASK DETAILhttps://phabricator.wikimedia.org/T187215EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Pablo-WMDE, gerritbot,

[Wikidata-bugs] [Maniphest] [Closed] T188279: Investigate optimzing wb_terms

2018-04-04 Thread Ladsgroup
Ladsgroup closed this task as "Resolved".Ladsgroup added a comment. I'd say let's call this done.TASK DETAILhttps://phabricator.wikimedia.org/T188279EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Stashbot, gerritbot, jcrespo, Marostegui,

[Wikidata-bugs] [Maniphest] [Unblock] T188992: Make wb_terms table fancy

2018-04-04 Thread Ladsgroup
Ladsgroup closed subtask T188279: Investigate optimzing wb_terms as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T188992EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: jcrespo, Jonas, Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Lahi,

[Wikidata-bugs] [Maniphest] [Claimed] T189596: Run deleteAutopatrolLogs script for Wikidata (WMF)

2018-04-04 Thread Ladsgroup
Ladsgroup claimed this task.Ladsgroup updated the task description. (Show Details)Herald added a project: User-Ladsgroup. CHANGES TO TASK DESCRIPTIONAfter April 4th 2018, run the script from {T189594}.. This script should delete auto patrol actions in wikidata, a cronjob in operations/puppet (in

[Wikidata-bugs] [Maniphest] [Updated] T191391: Apply schema changes to an isolated database and examine the results

2018-04-04 Thread Ladsgroup
Ladsgroup added a project: Wikidata-Ministry-Of-Magic. TASK DETAILhttps://phabricator.wikimedia.org/T191391EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Aklapper, Lucas_Werkmeister_WMDE, Jonas, jcrespo, Ladsgroup, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Created] T191391: Apply schema changes to an isolated database and examine the results

2018-04-04 Thread Ladsgroup
Ladsgroup created this task.Ladsgroup added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, DBA.Herald added a project: User-Ladsgroup. TASK DESCRIPTIONSee T188279#4101129 and onwardsTASK DETAILhttps://phabricator.wikimedia.org/T191391EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423867 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP SCRATCH: Investigate grammatical feature undo failings https://gerrit.wikimedia.org/r/423867TASK

[Wikidata-bugs] [Maniphest] [Commented On] T189580: Investigate: Undoing and restore edit on a form does not work

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 423867 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP SCRATCH: Investigate grammatical feature undo failings https://gerrit.wikimedia.org/r/423867TASK

[Wikidata-bugs] [Maniphest] [Commented On] T189479: Enforce permission checks on Special:NewLexeme

2018-04-04 Thread Pablo-WMDE
Pablo-WMDE added a comment. Per https://www.mediawiki.org/wiki/Manual:User_rights#Creating_a_new_group_and_assigning_permissions_to_it ff. it is only possible to change group definitions via configuration change, not via the API the "(all)" group which by default is associated with the

[Wikidata-bugs] [Maniphest] [Claimed] T189185: [Bug] possible to remove last lemma

2018-04-04 Thread WMDE-leszek
WMDE-leszek claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T189185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Pablo-WMDE, Jakob_WMDE, Addshore, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique,

[Wikidata-bugs] [Maniphest] [Commented On] T143273: Wikidata based ArticlePlaceholder pages won't open in the app

2018-04-04 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. This is still an issue though, no? And WMF intends to work more on the ArticlePlaceholder in the coming year leading to more usage afaik. I don't think this should be closed.TASK DETAILhttps://phabricator.wikimedia.org/T143273EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187215: [Bug] Undo of an edit on a form silently fails

2018-04-04 Thread Addshore
Addshore added a comment. In T187215#4100512, @Lydia_Pintscher wrote: Sorry here is the diff: https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L230=29727=29726 So it looks like there is still some issue with grammatical features, I'll investigate..TASK

[Wikidata-bugs] [Maniphest] [Commented On] T175199: Index certain statements for Wikidata items

2018-04-04 Thread gerritbot
gerritbot added a comment. Change 383364 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Bind against FieldDefinitions interface instead of implementation https://gerrit.wikimedia.org/r/383364TASK DETAILhttps://phabricator.wikimedia.org/T175199EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188279: Investigate optimzing wb_terms

2018-04-04 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-04-04T07:36:03Z] Synchronized wmf-config/db-codfw.php: Depool db2083 - T188279 (duration: 01m 17s)TASK DETAILhttps://phabricator.wikimedia.org/T188279EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T188279: Investigate optimzing wb_terms

2018-04-04 Thread Marostegui
Marostegui added a comment. So I have created the following user: test_user that has all privileges from terbium. I have already left the password on @Ladsgroup's home in terbium and he's tested that he can connect finely. Lastly, this host is downtimed, so if replication breaks due to the tests,

[Wikidata-bugs] [Maniphest] [Commented On] T188279: Investigate optimzing wb_terms

2018-04-04 Thread jcrespo
jcrespo added a comment. We can either change the password, or the user, or both. +1TASK DETAILhttps://phabricator.wikimedia.org/T188279EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: Stashbot, gerritbot, jcrespo, Marostegui, Nikerabbit,

[Wikidata-bugs] [Maniphest] [Commented On] T188279: Investigate optimzing wb_terms

2018-04-04 Thread Marostegui
Marostegui added a comment. db2083 is now depooled and with alert notifications disabled. Assuming @Ladsgroup will use the wikiadmin user to perform all the needed ALTERs, I would like to change its password to use a temporary and a different one from production, so he needs to specifically use a

[Wikidata-bugs] [Maniphest] [Commented On] T188279: Investigate optimzing wb_terms

2018-04-04 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-04-04T05:59:54Z] Synchronized wmf-config/db-eqiad.php: Depool db2083 - T188279 (duration: 01m 17s)TASK DETAILhttps://phabricator.wikimedia.org/T188279EMAIL

<    1   2