[Wikidata-bugs] [Maniphest] [Claimed] T147169: Make sure Wikibase dump maintenance scripts solely use the "dump" db group

2018-06-12 Thread hoo
hoo moved this task from Incoming to Peer Review on the Wikidata-Campsite board.hoo claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T147169WORKBOARDhttps://phabricator.wikimedia.org/project/board/3402/EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T147169: Make sure Wikibase dump maintenance scripts solely use the "dump" db group

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T147169EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, ArielGlenn, thiemowmde, Addshore, aaron, Aklapper, Smalyshev,

[Wikidata-bugs] [Maniphest] [Commented On] T147169: Make sure Wikibase dump maintenance scripts solely use the "dump" db group

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 440022 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/core@master] Allow passing the default DB group to use in Maintenance scripts https://gerrit.wikimedia.org/r/440022TASK DETAILhttps://phabricator.wikimedia.org/T147169EMAIL

[Wikidata-bugs] [Maniphest] [Created] T197038: Wikibase phpunit failure blocking WikidataPageBanner patches

2018-06-12 Thread Jdlrobson
Jdlrobson created this task.Jdlrobson added projects: Wikibase-Quality, Wikidata-Page-Banner, Readers-Web-Backlog (Tracking).Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONSeen on https://gerrit.wikimedia.org/r/440003 19:46:47 There was 1 error: 19:46:47

[Wikidata-bugs] [Maniphest] [Commented On] T152185: Map code throwing JS exception on IE11 Windows 7 causing Pagebanner not to be shown and Common.js not running due to JS error thrown by leaflet

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 432618 abandoned by Jdlrobson: Show banner that is loaded from cache https://gerrit.wikimedia.org/r/432618TASK DETAILhttps://phabricator.wikimedia.org/T152185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdlrobson,

[Wikidata-bugs] [Maniphest] [Updated] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, TheDJ, Sjoerddebruin, Zerabat, Legoktm, Trijnstel, Jdforrester-WMF, Shanmugamp7, Stryn,

[Wikidata-bugs] [Maniphest] [Updated] T187296: Increase kafka event retention to 14 or 21 days

2018-06-12 Thread Ottomata
Ottomata set the point value for this task to "2". TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: OttomataCc: mforns, elukey, Ottomata, Aklapper, Nuria, Ladsgroup, Pchelolo, JAllemandou, Smalyshev, Lahi,

[Wikidata-bugs] [Maniphest] [Commented On] T187296: Increase kafka event retention to 31

2018-06-12 Thread Pchelolo
Pchelolo added a comment. If we add a new mediawiki topic, we need to remember to run this command for it. Or implement T157092 :)TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ottomata, PcheloloCc:

[Wikidata-bugs] [Maniphest] [Updated] T187296: Increase kafka event retention to 31

2018-06-12 Thread Pchelolo
Pchelolo added a project: Services (watching). TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ottomata, PcheloloCc: mforns, elukey, Ottomata, Aklapper, Nuria, Ladsgroup, Pchelolo, JAllemandou, Smalyshev,

[Wikidata-bugs] [Maniphest] [Commented On] T113642: Should be possible to print breadcrumbs above the heading to avoid reflows on Wikivoyage

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 440003 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/WikidataPageBanner@master] Allow skins to render subtitle after banner https://gerrit.wikimedia.org/r/440003TASK DETAILhttps://phabricator.wikimedia.org/T113642EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T187296: Increase kafka event retention to 14 or 21 days

2018-06-12 Thread Ottomata
Ottomata added a comment. Doing the following for all main-eqiad and main-codfw: for t in \ mediawiki.page-create\ mediawiki.page-delete\ mediawiki.page-edit \ mediawiki.page-move \

[Wikidata-bugs] [Maniphest] [Retitled] T187296: Increase kafka event retention to 31

2018-06-12 Thread Ottomata
Ottomata renamed this task from "Increase kafka event retention to 14 or 21 days" to "Increase kafka event retention to 31".Ottomata claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T187296: Increase kafka event retention to 14 or 21 days

2018-06-12 Thread Ottomata
Ottomata added a comment. mediawiki eventbus topics should now be retained for 31 days in main Kafka clusters. If we add a new mediawiki topic, we need to remember to run this command for it.TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T187296: Increase kafka event retention to 14 or 21 days

2018-06-12 Thread Ottomata
Ottomata added a project: Analytics-Kanban. TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: OttomataCc: mforns, elukey, Ottomata, Aklapper, Nuria, Ladsgroup, Pchelolo, JAllemandou, Smalyshev, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Commented On] T196172: Test schema migration script

2018-06-12 Thread Anomie
Anomie added a comment. Increasing the batch size to 1000 increased the time-per-transaction to about 2-3 seconds, and decreased the total time to 12447 seconds (a savings of only about 23 minutes). Time for the subsequent runs was down to about 32 seconds. MRSS stayed the same (BTW, an initial

[Wikidata-bugs] [Maniphest] [Commented On] T187296: Increase kafka event retention to 14 or 21 days

2018-06-12 Thread Ottomata
Ottomata added a comment. I'll make this 31 days just to bump it up to a month. We have plenty of space for this.TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: OttomataCc: mforns, elukey, Ottomata,

[Wikidata-bugs] [Maniphest] [Updated] T187296: Increase kafka event retention to 14 or 21 days

2018-06-12 Thread Ottomata
Ottomata merged a task: T196409: Consider increasing retention for mediawiki event topics. TASK DETAILhttps://phabricator.wikimedia.org/T187296EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: OttomataCc: mforns, elukey, Ottomata, Aklapper, Nuria, Ladsgroup,

[Wikidata-bugs] [Maniphest] [Commented On] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I also created a dummy change (here), and it looks like CI is failing on other extensions, but not on WikibaseQualityConstraints itself… damn. (WikibaseQuality is an almost empty extension, by the way, which we should probably get rid of at some point.

[Wikidata-bugs] [Maniphest] [Commented On] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439982 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] DNM: dummy change https://gerrit.wikimedia.org/r/439982TASK

[Wikidata-bugs] [Maniphest] [Commented On] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439981 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Reset ConstraintLookup service around some tests https://gerrit.wikimedia.org/r/439981TASK

[Wikidata-bugs] [Maniphest] [Commented On] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread hashar
hashar added a comment. @Lucas_Werkmeister_WMDE dont worry that can wait tomorrow :-] Feel free to poke me on IRC tomorrow morning.TASK DETAILhttps://phabricator.wikimedia.org/T197017EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc:

[Wikidata-bugs] [Maniphest] [Updated] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread hashar
hashar removed a project: Math.hashar added a comment. In CI, WikibaseQuality does not depend on Math: $ colordiff -u Math WikibaseQuality --- Math 2018-06-12 18:54:57.569521197 +0200 +++ WikibaseQuality 2018-06-12 18:55:13.609284832 +0200 @@ -1,4 +1,3 @@ -mediawiki/extensions/Math

[Wikidata-bugs] [Maniphest] [Updated] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikibase-Quality-Constraints. TASK DETAILhttps://phabricator.wikimedia.org/T197017EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, hashar, Aklapper, Gaboe420,

[Wikidata-bugs] [Maniphest] [Commented On] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I haven’t been able to reproduce this locally yet, but I have a hunch – see the above change. (Is the CI failure reliable or flaky?)TASK DETAILhttps://phabricator.wikimedia.org/T197017EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T197017EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985,

[Wikidata-bugs] [Maniphest] [Commented On] T183487: MCR schema migration stage 3: drop support for legacy fields

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439976 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] Remove direct access to the text table. https://gerrit.wikimedia.org/r/439976TASK DETAILhttps://phabricator.wikimedia.org/T183487EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439977 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t cache constraints when running unit tests https://gerrit.wikimedia.org/r/439977TASK

[Wikidata-bugs] [Maniphest] [Updated] T183487: MCR schema migration stage 3: drop support for legacy fields

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T183487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, Gaboe420, Versusxo,

[Wikidata-bugs] [Maniphest] [Updated] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)). TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)). TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: gerritbot, RazShuty, Aklapper, Gaboe420,

[Wikidata-bugs] [Maniphest] [Edited] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [`ConstraintRepository`, `ConstraintLookup`](https://gerrit.wikimedia.org/r/439619) - [ - [x] [`CheckResultSerializer`, `CheckResultDeserializer`](https://gerrit.wikimedia.org/r/439620) - [ -

[Wikidata-bugs] [Maniphest] [Created] T197017: Math PHPUnit fail due to WikibaseQuality SpecialConstraintReportTest: not found

2018-06-12 Thread hashar
hashar created this task.hashar added projects: Math, Wikibase-Quality.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONOn a dummy change made to the Math extension (436237), a PHPUnit test is failling: Test report. Seems the hamcrest test is looking for but

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439934 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Extract constants for service names https://gerrit.wikimedia.org/r/439934TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439620 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move CheckResultSerializer+Deserializer to services https://gerrit.wikimedia.org/r/439620TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439909 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Run data-access tests on commit https://gerrit.wikimedia.org/r/439909TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439957 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix data-access phpunit tests https://gerrit.wikimedia.org/r/439957TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [`ViolationMessageSerializer`, `ViolationMessageDeserializer`](https://gerrit.wikimedia.org/r/439953) - [ ] [`ConstraintParameterParser`](https://gerrit.wikimedia.org/r/439962)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439962 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move ConstraintParameterParser to services https://gerrit.wikimedia.org/r/439962TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439957 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Fix data-access phpunit tests https://gerrit.wikimedia.org/r/439957TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. @Ladsgroup are you aware of any existing task to use MediaWikiServices in Wikibase itself? Because a lot of our services depend on Wikibase services, which we currently get from WikibaseRepo::getDefaultInstance().TASK

[Wikidata-bugs] [Maniphest] [Edited] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [extract constants](https://gerrit.wikimedia.org/r/439934) - [ ] [`ViolationMessageSerializer`, `ViolationMessageDeserializer`](https://gerrit.wikimedia.org/r/439953)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439953 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Move ViolationMessageSerializer+Deserializer to services https://gerrit.wikimedia.org/r/439953TASK

[Wikidata-bugs] [Maniphest] [Commented On] T191600: Showing the lemma in recent changes

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439951 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] LexemeLinkFormatter: test it is used https://gerrit.wikimedia.org/r/439951TASK

[Wikidata-bugs] [Maniphest] [Edited] T195708: Prefill spelling variant of new form representation

2018-06-12 Thread Lydia_Pintscher
Lydia_Pintscher updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONWhen adding a new form most of the time the spelling variant of the form representation will be the same as the spelling variant of the Lemma. We should pre-fill the spelling variant of a new form's first

[Wikidata-bugs] [Maniphest] [Commented On] T195708: Prefill spelling variant of new form representation

2018-06-12 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. We discussed it today and concluded that we don't know enough from the users yet and will therefore only pre-fill it for Lexemes with one Lemma. For the Lexemes with more than one we don't pre-fill.TASK DETAILhttps://phabricator.wikimedia.org/T195708EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T195461: Display the lemmas in Special:WhatLinksHere

2018-06-12 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T195461EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Nikki, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Edited] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [`CheckResultSerializer`, `CheckResultDeserializer`](https://gerrit.wikimedia.org/r/439620) - [ ] [extract constants](https://gerrit.wikimedia.org/r/439934)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439934 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Extract constants for service names https://gerrit.wikimedia.org/r/439934TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439930 abandoned by Addshore: Run data-access phpunit tests Reason: email didn't include the fact there was already a patch for this :D https://gerrit.wikimedia.org/r/439930TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439930 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Run data-access phpunit tests https://gerrit.wikimedia.org/r/439930TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [setup, `LoggingHelper`](https://gerrit.wikimedia.org/r/439618) - [ - [x] [`ConstraintRepository`, `ConstraintLookup`](https://gerrit.wikimedia.org/r/439619)...TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196882: Create a code abstraction for "display entity link" use-case

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439927 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)): [mediawiki/extensions/Wikibase@master] Refactor ItemIdHtmlLinkFormatterTest https://gerrit.wikimedia.org/r/439927TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196949: Some of the claim identifiers use an initial lowercase "q" and some an uppercase "Q"

2018-06-12 Thread jeblad
jeblad added a comment. This can be a bigger issue if the ids are not consistent, so this should be fixed. Note especially that a simple string comparison between ids are not sufficient to decide if two claims are equal when this bug is in effect.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-06-12 Thread hashar
hashar added a comment. From https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439289 Wikibase was failing the Selenium tests which are run by the 'quibble' job at least for the php7. It might be faster and thus ended up hitting the race condition. I have crafted a dummy change for Wikibase

[Wikidata-bugs] [Maniphest] [Commented On] T196172: Test schema migration script

2018-06-12 Thread Anomie
Anomie added a comment. For eowiki, with the default batch size (500): Each transaction took around 1-2 seconds during the initial run. The initial run took 13855 seconds to insert 6306218 (there was a bug that made it skip the first row, BTW). The second run (after fixing the bug) took 47

[Wikidata-bugs] [Maniphest] [Merged] T196935: Evaluate Special:ItemDisambiguation usages

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added subscribers: Lucas_Werkmeister_WMDE, Addshore.Lucas_Werkmeister_WMDE merged a task: T196993: Investigate uses of Special:ItemDisambiguation. TASK DETAILhttps://phabricator.wikimedia.org/T196935EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439619 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Move ConstraintRepository+ConstraintLookup to services https://gerrit.wikimedia.org/r/439619TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, RazShuty, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985,

[Wikidata-bugs] [Maniphest] [Commented On] T163328: Add the truthy nt dump to dcat-AP

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 424291 merged by ArielGlenn: [operations/puppet@production] Support prefixed dump types https://gerrit.wikimedia.org/r/424291TASK DETAILhttps://phabricator.wikimedia.org/T163328EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439909 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)): [mediawiki/extensions/Wikibase@master] Run data-access tests on commit https://gerrit.wikimedia.org/r/439909TASK

[Wikidata-bugs] [Maniphest] [Updated] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)). TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, ReleaseTaggerBotCc: gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T194938: Wikibase Lexeme: security alert digest - hoek npm module in Wikibase Lexeme is a security alert

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Should hopefully be improved now, but since I can’t even see the security bug myself, I’m not going to close this task yet.TASK DETAILhttps://phabricator.wikimedia.org/T194938EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T195754: Enable Special:ItemDisambiguation back

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subtask: T196935: Evaluate Special:ItemDisambiguation usages. TASK DETAILhttps://phabricator.wikimedia.org/T195754EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: waldyrious, Esc3300, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T193641: track number of editors from other Wikimedia projects who also edit on Wikidata over time

2018-06-12 Thread Addshore
Addshore added a comment. As we want thi to land in graphite and create a grafana board this is probably very similar to: https://github.com/wikimedia/analytics-refinery-source/blob/master/refinery-job/src/main/scala/org/wikimedia/analytics/refinery/job/WikidataArticlePlaceholderMetrics.scala

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-06-12 Thread Jan_Dittrich
Jan_Dittrich added a comment. @Jan_Dittrich what should it look like if there’s a line break in one of the labels? Hmm, good point. I would suggest to have it end bluntly and keep it display:inline (or a behavior like that. ) F22145080: image.png ↑rough exampleTASK

[Wikidata-bugs] [Maniphest] [Triaged] T196868: Track new API reported maxlag for wikidata on grafana dashboard

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T196868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Declined] T195299: Broken edit summary when editing grammatical features of a form

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Declined".Pablo-WMDE added a comment. So I'll boldly close this.TASK DETAILhttps://phabricator.wikimedia.org/T195299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T196998: Wikidata: Data-access tests are not being run on commit (and ever)

2018-06-12 Thread RazShuty
RazShuty added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T196998EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RazShutyCc: RazShuty, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude,

[Wikidata-bugs] [Maniphest] [Updated] T193641: track number of editors from other Wikimedia projects who also edit on Wikidata over time

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite. TASK DETAILhttps://phabricator.wikimedia.org/T193641EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Addshore, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Updated] T196935: Evaluate Special:ItemDisambiguation usages

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a parent task: T195754: Enable Special:ItemDisambiguation back. TASK DETAILhttps://phabricator.wikimedia.org/T196935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Addshore, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T184933: Use or to view coordinates on Wikidata

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite. TASK DETAILhttps://phabricator.wikimedia.org/T184933EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, hoo, Ayack, Sjoerddebruin, Aklapper, Gaboe420, Versusxo,

[Wikidata-bugs] [Maniphest] [Updated] T196993: Investigate uses of Special:ItemDisambiguation

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as a duplicate of T196935: Evaluate Special:ItemDisambiguation usages. TASK DETAILhttps://phabricator.wikimedia.org/T196993EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Ladsgroup,

[Wikidata-bugs] [Maniphest] [Commented On] T167127: Standard UI for including statements in constraint violation messages

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. @Jan_Dittrich what should it look like if there’s a line break in one of the labels?TASK DETAILhttps://phabricator.wikimedia.org/T167127EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_Dittrich,

[Wikidata-bugs] [Maniphest] [Edited] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...#patch-for-review: - [ - [x] [setup, `LoggingHelper`](https://gerrit.wikimedia.org/r/439618)...TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T195755: Migrate Special:ItemDisambiguation to use elastic

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I created some subtasks for the next steps, but IMHO only T196991: Restore old behavior of Special:ItemDisambiguation is required for T195754: Enable Special:ItemDisambiguation back.TASK DETAILhttps://phabricator.wikimedia.org/T195755EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T190670: Unclear behavior of grammatical feature diff headers

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE updated the task description. (Show Details)Pablo-WMDE set the point value for this task to "2". CHANGES TO TASK DESCRIPTION...WHEN a diff of grammatical features on a lexeme is presented THEN no "grammatical feature" id is shown in the diff "breadcrumb" ...TASK

[Wikidata-bugs] [Maniphest] [Created] T196992: Move EntitySearchHelper somewhere else

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Ministry-Of-Magic, Wikidata-Campsite. TASK DESCRIPTIONAs pointed out in review comments of I22ad897084, we now have a page from the Special namespace using a class from the Api namespace, which is a

[Wikidata-bugs] [Maniphest] [Created] T196991: Restore old behavior of Special:ItemDisambiguation

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE triaged this task as "High" priority.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Ministry-Of-Magic, Wikidata-Campsite. TASK DESCRIPTIONSince I22ad897084, Special:ItemDisambiguation has some unwanted features: it does a

[Wikidata-bugs] [Maniphest] [Edited] T190670: Unclear behavior of grammatical feature diff headers

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...{F16099963} Additional question: Did we decide on the "/"-separator for the diff header breadcrumbs? Should they be translatable? It is currently hardcoded in `BasicDiffView` and

[Wikidata-bugs] [Maniphest] [Commented On] T196053: Make WikibaseQualityConstraints use MediawikiServices for its services

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439618 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Set up ServiceWiring, add LoggingHelper service https://gerrit.wikimedia.org/r/439618TASK DETAILhttps://phabricator.wikimedia.org/T196053EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T194938: Wikibase Lexeme: security alert digest - hoek npm module in Wikibase Lexeme is a security alert

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439623 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Update three dependencies in package.json https://gerrit.wikimedia.org/r/439623TASK DETAILhttps://phabricator.wikimedia.org/T194938EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T165597: Item selector in Special:NewLexeme should show description

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...@Lydia_Pintscher ? Consider moving the resulting component to wikibase to make usable from other product (e.g. mediainfo).TASK DETAILhttps://phabricator.wikimedia.org/T165597EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T195299: Broken edit summary when editing grammatical features of a form

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Looks like this is already fixed, otherwise you should see the error when looking at the two diffs linked in the task description.TASK DETAILhttps://phabricator.wikimedia.org/T195299EMAIL

[Wikidata-bugs] [Maniphest] [Created] T196993: Investigate uses of Special:ItemDisambiguation

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Campsite. TASK DESCRIPTIONSpecial:ItemDisambiguation sees a lot of traffic, but it’s not clear if that page is actually offering the best interface for its users or if they should use something else

[Wikidata-bugs] [Maniphest] [Commented On] T195755: Migrate Special:ItemDisambiguation to use elastic

2018-06-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. The gerrit comments also mention list=wbsearch in the API, is that related to this task? If I understand correctly, that shouldn’t be a problem after all.TASK DETAILhttps://phabricator.wikimedia.org/T195755EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T194371: Special:RedirectEntity "non empty item" i18n message doesn't make sense for other entity types

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE set the point value for this task to "1". TASK DETAILhttps://phabricator.wikimedia.org/T194371EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345,

[Wikidata-bugs] [Maniphest] [Updated] T195708: Prefill spelling variant of new form representation

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE set the point value for this task to "5". TASK DETAILhttps://phabricator.wikimedia.org/T195708EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, Pablo-WMDECc: Pablo-WMDE, abian, Liuxinyu970226, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T195299: Broken edit summary when editing grammatical features of a form

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE added a comment. Hi @Lucas_Werkmeister_WMDE , we struggle to reproduce this. Can you? ThanksTASK DETAILhttps://phabricator.wikimedia.org/T195299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Pablo-WMDE, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T165597: Item selector in Special:NewLexeme should show description

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE set the point value for this task to "5". TASK DETAILhttps://phabricator.wikimedia.org/T165597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Nikki, Aklapper, WMDE-leszek, Jonas, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Edited] T191614: wrong translations of Form related strings

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE updated the task description. (Show Details)Pablo-WMDE set the point value for this task to "2". CHANGES TO TASK DESCRIPTION...* wikibaselexeme-diffview-form **AC** * prefix form with "lexicographical" in qqq file * research and apply {{Identical|}} tag to allow translators to know

[Wikidata-bugs] [Maniphest] [Updated] T196882: Create a code abstraction for "display entity link" use-case

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T196882EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aleksey_WMDE, WMDE-leszek, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci,

[Wikidata-bugs] [Maniphest] [Commented On] T196882: Create a code abstraction for "display entity link" use-case

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439885 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)): [mediawiki/extensions/Wikibase@master] Separate HTML link formatter for ItemIds https://gerrit.wikimedia.org/r/439885TASK

[Wikidata-bugs] [Maniphest] [Updated] T100897: [Task] Allow formatting references by a callback in Wikibase's infobox functionality

2018-06-12 Thread thiemowmde
thiemowmde added subscribers: Tpt, thiemowmde.thiemowmde added a comment. @hoo, I feel this ticket and the patch https://gerrit.wikimedia.org/r/217898 that got abandoned might be relevant for what you are currently working on for T182147: more convenience functions for Lua and

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T154601: Grafana: "wikidata-datamodel-terms" doesn't update anymore

2018-06-12 Thread GoranSMilovanovic
GoranSMilovanovic added subscribers: Aleksey_WMDE, WMDE-leszek.GoranSMilovanovic added a comment. @Addshore After reconsidering this, I have to state openly that I am against relying on JSON dumps as the only source of data. @WMDE-leszek @Aleksey_WMDE will also be interested to hear, I guess.

[Wikidata-bugs] [Maniphest] [Updated] T191600: Showing the lemma in recent changes

2018-06-12 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T191600EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, gerritbotCc: gerritbot, WMDE-leszek, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo,

[Wikidata-bugs] [Maniphest] [Commented On] T191600: Showing the lemma in recent changes

2018-06-12 Thread gerritbot
gerritbot added a comment. Change 439878 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/core@master] selenium: add RecentChanges test to page spec https://gerrit.wikimedia.org/r/439878TASK DETAILhttps://phabricator.wikimedia.org/T191600EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T196980: Lemma order not guaranteed

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONOrder orf [[ https://www.mediawiki.org/wiki/Extension:WikibaseLexeme/Data_Model#Lemma | lemmas ]] that are displayed in the front end depends on the order in which the lemmas are added to the store. This could

[Wikidata-bugs] [Maniphest] [Commented On] T196980: Lemma order not guaranteed

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Esc3300 The "Lexicographical data" _javascript_ front end - I expected this information to be conveyed through the product tag. This is barely a "lest we forget" ticket. Please advise in what way tickets should be created differently to avoid potentially interfering

[Wikidata-bugs] [Maniphest] [Commented On] T196980: Lemma order not guaranteed

2018-06-12 Thread Esc3300
Esc3300 added a comment. Which "frontend" ?TASK DETAILhttps://phabricator.wikimedia.org/T196980EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Esc3300, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Created] T196980: Lemma order not guaranteed

2018-06-12 Thread Pablo-WMDE
Pablo-WMDE created this task.Pablo-WMDE added projects: Lexicographical data, Technical-Debt.Herald added a project: Wikidata. TASK DESCRIPTIONOrder or lemmas that are displayed in the frontend depends on the order in which the lemmas are added to the store. This could differ between browsers

  1   2   >