Evilricepuddin added a comment.
Because, even if you wanted the query to fail because its technically
invalid, the fact that it was producing a `StackOverflowError` instead of a
more meaningful error was still a bug. Honestly, I didn't mind which way the
fix went, but it was still a bug
Evilricepuddin added a comment.
As a user, I'd be happy with the fix being that the variable re-use is
detected and I'm given an appropriate error message (this was, after all, the
fix that I deployed to work around the problem). I imagine that the
StackOverflowError is not the intended
Evilricepuddin updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T235540
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Evilricepuddin
Cc: Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin
Evilricepuddin added a comment.
Thanks for the workaround, can confirm that the query is working again for me
now :)
TASK DETAIL
https://phabricator.wikimedia.org/T235540
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Evilricepuddin
Cc
