[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

2024-05-23 Thread Jdlrobson
Jdlrobson assigned this task to Jdrewniak. TASK DETAIL https://phabricator.wikimedia.org/T306744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdrewniak, Jdlrobson Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk

[Wikidata-bugs] [Maniphest] T115013: [Story] Display Wikidata pages on mobile watchlist with labels instead of Q id titles

2024-05-23 Thread Jdlrobson
Jdlrobson closed this task as "Declined". Jdlrobson added a comment. On the long term we're hoping to remove this page and replace it with Special:ReadingList (see T363032 <https://phabricator.wikimedia.org/T363032>). Please subscribe to that ticket for updates and any

[Wikidata-bugs] [Maniphest] T78430: [Epic] Getting Wikidata to render nicely on mobile web

2024-05-23 Thread Jdlrobson
Jdlrobson closed subtask T115013: [Story] Display Wikidata pages on mobile watchlist with labels instead of Q id titles as Declined. TASK DETAIL https://phabricator.wikimedia.org/T78430 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc

[Wikidata-bugs] [Maniphest] T95026: PageImages should be able to pick Wikidata's P18 as chosen image

2024-05-23 Thread Jdlrobson
Jdlrobson edited projects, added task-needs-improvement; removed Web-Team-Backlog, Wikidata, PageImages. TASK DETAIL https://phabricator.wikimedia.org/T95026 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Titore, RogueScholar, ARR8

[Wikidata-bugs] [Maniphest] T364882: Wikidata guided tour doesn't work on mobile, throws production error

2024-05-20 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson added a project: Verified. Jdlrobson claimed this task. Jdlrobson added a comment. Temporary fix added: https://www.wikidata.org/w/index.php?title=MediaWiki%3AGuidedtour-lib.js=2157177549=1116872164 Seems to have done the j

[Wikidata-bugs] [Maniphest] T364882: Wikidata guided tour doesn't work on mobile, throws production error

2024-05-14 Thread Jdlrobson
Jdlrobson created this task. Jdlrobson added projects: MediaWiki-extensions-GuidedTour, Wikimedia-production-error, Wikidata. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Growth-Team, wmde-wikidata-tech. TASK DESCRIPTION **Steps to replicate

[Wikidata-bugs] [Maniphest] T120780: Modify Media Viewer to include Wikidata information

2024-05-14 Thread Jdlrobson
Jdlrobson closed this task as "Declined". Jdlrobson added a comment. Declining old feature request. If this is still wanted we can add a hook inside MultimediaViewer to support this - please open a new ticket. TASK DETAIL https://phabricator.wikimedia.org/T120780 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2024-05-03 Thread Jdlrobson
Jdlrobson added a comment. @Sjoerddebruin if defined via MediaWiki:Gadget-definition you can uses skins to disable Minerva. Alternatively you can add `if ( mw.config.get( 'skin' ) === 'minerva' ) return;` Alternatively if it's functional you could add some CSS to target Minerva

[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties

2024-04-25 Thread Jdlrobson
Jdlrobson added a comment. Some context: https://www.mediawiki.org/wiki/Extension:WikidataPageBanner#'origin'_parameter It looks like this feature is broken, so presumably it got broken at some point? TASK DETAIL https://phabricator.wikimedia.org/T362660 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T359446: Pagebanner should be compatible with new parser changes

2024-04-24 Thread Jdlrobson
Jdlrobson lowered the priority of this task from "High" to "Medium". TASK DETAIL https://phabricator.wikimedia.org/T359446 WORKBOARD https://phabricator.wikimedia.org/project/board/5483/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Wikidata-bugs] [Maniphest] T359446: Pagebanner should be compatible with new parser changes

2024-04-24 Thread Jdlrobson
Jdlrobson triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Andyrom75, cscott, SHB2000, Avsolov, Aklapper, Jdlrobson, Atsirlin, Nishu02

[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties

2024-04-24 Thread Jdlrobson
Jdlrobson triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T362660 WORKBOARD https://phabricator.wikimedia.org/project/board/5483/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: cscott, Jd

[Wikidata-bugs] [Maniphest] T115013: [Story] Display Wikidata pages on mobile watchlist with labels instead of Q id titles

2024-04-19 Thread Jdlrobson
Jdlrobson added a project: MobileFrontend (MobileFrontend Special Pages). TASK DETAIL https://phabricator.wikimedia.org/T115013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Liuxinyu970226, PokestarFan, Bene, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

2024-04-18 Thread Jdlrobson
Jdlrobson added a comment. The frontend stable policy currently doesn't cover mw.config values. We already have cases where config variables are not always available e.g. on mobile wgCategories is notably absent, so I think code should be providing fallbacks or error handling when those

[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties

2024-04-17 Thread Jdlrobson
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)). TASK DETAIL https://phabricator.wikimedia.org/T362660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: cscott, Jdlrobson Cc: thiemowmde, Tgr, Jdlrobson, cscott, Aklapper

[Wikidata-bugs] [Maniphest] T117158: Special:Nearby should use language fallback for labels and descriptions

2024-04-16 Thread Jdlrobson
Jdlrobson added a comment. The API response doesn't contain the English label. Is there a way to alert this request to make sure it includes the fallbacks?: https://www.wikidata.org/w/api.php?action=query=json=label%7Cdescription=*=2=coordinates%7Cpageprops%7Cpageimages%7Cdescription

[Wikidata-bugs] [Maniphest] T117158: Special:Nearby should use language fallback for labels and descriptions

2024-04-16 Thread Jdlrobson
Jdlrobson added a comment. @Lydia_Pintscher could you change the permissions on your images? To make sure I understand the Q code here should be showing "Gemeindehaus der Kaiser-Wilhelm-Gedächtniskirche Lietzenburger Straße 37/39" for English language since that one exists

[Wikidata-bugs] [Maniphest] T117158: Special:Nearby should use language fallback for labels and descriptions

2024-04-16 Thread Jdlrobson
Jdlrobson added a comment. @nikki could you please share a URL where the issue can be replicated? I can't replicate on https://www.wikidata.org/wiki/Special:Nearby?uselang=de#/coord/52.52,13.405 for example. TASK DETAIL https://phabricator.wikimedia.org/T117158 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

2024-04-15 Thread Jdlrobson
Jdlrobson added a comment. > Does mw:Stable interface policy/Frontend even apply to extensions the same way it applies to core Yes. Anything on the mw object is subject to the deprecation policy. The reason for this is that it is not fair to expect gadget developers to understand wh

[Wikidata-bugs] [Maniphest] T95883: [Task] Investigate how to use different/new diff views for entity diffs on mobile

2024-03-18 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. THe mobile diff view no longer exists. THe screenshot no longer matches the current experience so I am going to assume this can be closed now. TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] T78430: [Epic] Getting Wikidata to render nicely on mobile web

2024-03-18 Thread Jdlrobson

[Wikidata-bugs] [Maniphest] T95883: [Task] Investigate how to use different/new diff views for entity diffs on mobile

2024-03-18 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T95883 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Ricordisamoa, Liuxinyu970226, Jdlrobson, Lydia_Pintscher, Florian, Aklapper, Snaterlicious

[Wikidata-bugs] [Maniphest] T243834: How should wikidata/structured data diffs appear on mobile?

2024-03-18 Thread Jdlrobson
Jdlrobson added a comment. These currently appear stacked: https://commons.m.wikimedia.org/w/index.php?title=File:%D0%A4%D0%BE%D1%82%D0%BE_%D0%90%D0%BB%D0%B8%D1%88%D0%B5%D1%80_%D0%A2%D0%B0%D1%88%D0%BC%D0%B0%D1%82%D0%BE%D0%B2_%D0%91%D0%BE%D0%B3%D0%B0%D1%80%D0%B4%D0%B8%D0%B5%D0%B2%D0%B8%D1%87

[Wikidata-bugs] [Maniphest] T343052: Evaluate Wikidata's mobile site: Reconsider how Wikidata uses MobileFrontend/Minerva

2024-03-18 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T343052 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdforrester-WMF, Denny, Manuel, Nikki, Michael, WMDE-leszek, karapayneWMDE, Arian_Bozorg

[Wikidata-bugs] [Maniphest] T359446: Pagebanner should be compatible with new parser changes

2024-03-15 Thread Jdlrobson
Jdlrobson raised the priority of this task from "Medium" to "Needs Triage". TASK DETAIL https://phabricator.wikimedia.org/T359446 WORKBOARD https://phabricator.wikimedia.org/project/board/5483/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] T359446: Pagebanner should be compatible with new parser changes

2024-03-15 Thread Jdlrobson
Jdlrobson renamed this task from "TOC appears on pages with Pagebanner" to "Pagebanner should be compatible with new parser changes". TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

2024-03-13 Thread Jdlrobson
Jdlrobson moved this task from FY2023-24 Q3 Sprint 6 to Needs Prioritization (Tech) on the Web-Team-Backlog board. Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 6). TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

2024-03-12 Thread Jdlrobson
Jdlrobson added a comment. Patch was reverted as a temporary measure so this will ride the train this week. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Andyrom75, cscott

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

2024-03-11 Thread Jdlrobson
Jdlrobson added a comment. We pinpointed this issue to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikidataPageBanner/+/972060 TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

2024-03-07 Thread Jdlrobson
Jdlrobson added a comment. > This can be achieved by adding the NOTOC keyword in the template that calls the banner. However, I am not sure if such a solution is really desirable, or something should be fixed inside the Mediawiki code instead. Regardless of whether behaviour chan

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

2024-03-07 Thread Jdlrobson
Jdlrobson added a subscriber: cscott. Jdlrobson added a comment. @cscott I'm guessing this is fallout from the changes you were working on last week? TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T359446: TOC appears on pages with Pagebanner

2024-03-07 Thread Jdlrobson
Jdlrobson added a project: Content-Transform-Team. TASK DETAIL https://phabricator.wikimedia.org/T359446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: SHB2000, Avsolov, Aklapper, Jdlrobson, Atsirlin, FBellamy-WMF, Nishu02, ovasileva

[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6

2024-02-08 Thread Jdlrobson
Jdlrobson added a subscriber: simon04. Jdlrobson added a comment. Thanks @simon04 for taking care of MediaViewer code! TASK DETAIL https://phabricator.wikimedia.org/T353076 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: simon04

[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6

2024-02-08 Thread Jdlrobson
Jdlrobson removed a project: MediaViewer. TASK DETAIL https://phabricator.wikimedia.org/T353076 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: SD0001, Jdlrobson, Novem_Linguae, Soda, Chlod, DannyS712, Aklapper, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6

2024-01-19 Thread Jdlrobson
Jdlrobson added projects: MediaViewer, PageTriage, MediaWiki-extensions-WikibaseClient. Jdlrobson added a comment. > Why would we need to deprecate it, when it was previously marked as private until your documentation update? I guess we don't need to follow the deprecation proc

[Wikidata-bugs] [Maniphest] T353867: Selecting language in WikiData/meta-wiki (minerva-skin) will jump you to wikipedia

2024-01-17 Thread Jdlrobson
Jdlrobson removed projects: Desktop Improvements (Vector 2022), MinervaNeue. TASK DETAIL https://phabricator.wikimedia.org/T353867 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Masumrezarock100, hubaishan

[Wikidata-bugs] [Maniphest] T263633: Mobile Special:EditWatchlist displays item IDs instead of labels

2023-12-13 Thread Jdlrobson
Jdlrobson lowered the priority of this task from "Medium" to "Low". Jdlrobson changed the task status from "Open" to "Stalled". Jdlrobson added a comment. This is unlikely to be worked on but will hopefully be resolved by either T266065 <https://ph

[Wikidata-bugs] [Maniphest] T263633: Mobile Special:EditWatchlist displays item IDs instead of labels

2023-12-13 Thread Jdlrobson
Jdlrobson triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T263633 WORKBOARD https://phabricator.wikimedia.org/project/board/3707/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: phuedx,

[Wikidata-bugs] [Maniphest] T249989: Disable native OpenSearch suggestions in Wikibase wikis

2023-12-12 Thread Jdlrobson
Jdlrobson added a project: Vector (legacy skin). TASK DETAIL https://phabricator.wikimedia.org/T249989 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson, Gehel, aliu, Pols12, MisterSynergy, Lydia_Pintscher, Ainali, dcausse

[Wikidata-bugs] [Maniphest] T249989: Disable native OpenSearch suggestions in Wikibase wikis

2023-12-12 Thread Jdlrobson
Jdlrobson added a comment. @aliu does this happen in safe mode? Vector 2022 shouldn't be loading Opensearch (the mediawiki.searchSuggest module) under any circumstances. I can't replicate this myself on English Wikipedia TASK DETAIL https://phabricator.wikimedia.org/T249989 EMAIL

[Wikidata-bugs] [Maniphest] T249989: Disable native OpenSearch suggestions in Wikibase wikis

2023-12-07 Thread Jdlrobson
Jdlrobson added a project: wmde-wikidata-tech. Jdlrobson moved this task from Incoming to Tracking on the Web-Team-Backlog board. Jdlrobson added a comment. What assistance is needed from the web team? My understanding is Wikidata has its own implementation of search on legacy Vector so I

[Wikidata-bugs] [Maniphest] T352356: Wikidata in desktop view less readable in newer Vector 2022 on iPad

2023-12-04 Thread Jdlrobson
Jdlrobson added a project: wmde-wikidata-tech. TASK DETAIL https://phabricator.wikimedia.org/T352356 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, gh87, Danny_Benjafield_WMDE, JCW555, hnijhuis, Astuthiodit_1, Patafisik_WMF

[Wikidata-bugs] [Maniphest] T351681: Deprecate mediawiki.icon ResourceLoader module and use Codex mixin instead.

2023-11-21 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot

[Wikidata-bugs] [Maniphest] T351681: Deprecate mediawiki.icon ResourceLoader module and use Codex mixin instead.

2023-11-20 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71

[Wikidata-bugs] [Maniphest] T351681: Deprecate mediawiki.icon ResourceLoader module and use Codex mixin instead.

2023-11-20 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2023-10-11 Thread Jdlrobson
Jdlrobson added a comment. This is off topic but feel free to discuss on the stable policy talk page. If we were to make them stable we'd also need some practical way to deprecate them too which currently does not exist - feel free to create a Phabricator ticket for discussing that too

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2023-10-11 Thread Jdlrobson
Jdlrobson added a comment. @Lucas_Werkmeister_WMDE using `mw.loader.getState` looks great and does exactly what you want. It seems like it would also be resilient to changes elsewhere (for example if one of those modules isn't loaded on certain pages this code also wouldn't load) TASK

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2023-10-11 Thread Jdlrobson
Jdlrobson added a comment. @Tacsipacsi mw.config variables are not currently covered by the frontend stable policy <https://www.mediawiki.org/w/index.php?title=Stable_interface_policy/Frontend>. FWIW I originally added that variable for internal usage in MobileFrontend back in 201

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2023-10-10 Thread Jdlrobson
Jdlrobson added a comment. Relying on wgMFMode is not a good idea as that could disappear in future. Ideally you'd feature detect something in the UI or the browser state (e.g. checking viewport size). Per the frontend stable policy <https://www.mediawiki.org/w/index.php?ti

[Wikidata-bugs] [Maniphest] T348267: Minerva HTML markup change: #page-actions is now #p-views

2023-10-05 Thread Jdlrobson
Jdlrobson added a comment. In the mobile web skin (Minerva) the CSS ID #page-actions has been replaced with #p-views (changes will roll out week of 9th). This change is to make it consistent with other skins and to improve support for gadgets and extensions in the mobile skin. A few gadgets

[Wikidata-bugs] [Maniphest] T348267: Minerva HTML markup change: #page-actions is now #p-views

2023-10-05 Thread Jdlrobson
Jdlrobson added a project: Language-Team. TASK DETAIL https://phabricator.wikimedia.org/T348267 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Masumrezarock100, Jdlrobson, Danny_Benjafield_WMDE, Isabelladantes1983

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

2023-10-04 Thread Jdlrobson
Jdlrobson added a comment. @thiemowmde could you answer my question around RevisionSlider and AdvancedSearch? @thiemowmde I've updated the title to hopefully be less confusing, per the stable policy any hooks are stable: >The function signature of the callback function for ho

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0

2023-10-04 Thread Jdlrobson
Jdlrobson renamed this task from "WMDE: Review code on mw object and hooks contract and mark (un)stable interfaces before 1.42.0" to "WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0". TASK DETAIL https://phabricator.w

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review code on mw object and hooks contract and mark (un)stable interfaces before 1.42.0

2023-10-04 Thread Jdlrobson
Jdlrobson renamed this task from "WMDE: Review code on mw object and mark (un)stable interfaces before 1.42.0" to "WMDE: Review code on mw object and hooks contract and mark (un)stable interfaces before 1.42.0". TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL

[Wikidata-bugs] [Maniphest] T348079: WMDE: Review code on mw object and mark (un)stable interfaces before 1.42.0

2023-10-04 Thread Jdlrobson
Jdlrobson added a comment. @thiemowmde here are some examples of stable code that is not clearly documented (this is not a complete list): - The hook wikibase.entityPage.entityLoaded <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/1330706a9ae41dcdc0d21b3875c9a8d5a6ba9

[Wikidata-bugs] [Maniphest] T348138: Offer to connect with Wikidata item from "No languages yet. Add a new one?" dialog in Vector 2022

2023-10-04 Thread Jdlrobson
Jdlrobson edited projects, added UniversalLanguageSelector; removed Desktop Improvements (Vector 2022). TASK DETAIL https://phabricator.wikimedia.org/T348138 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Msz2001

[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system

2023-09-20 Thread Jdlrobson
Jdlrobson added a comment. From my point of view yes (T324991#8846440 <https://phabricator.wikimedia.org/T324991#8846440>), but I'd defer to @Lucas_Werkmeister_WMDE before closing in case you need to create any follow up tasks. TASK DETAIL https://phabricator.wikimedia.org/T324991

[Wikidata-bugs] [Maniphest] T345660: wikibase@0.1.0 install:bridge fails with webpack dependency error

2023-09-05 Thread Jdlrobson
Jdlrobson edited projects, added Wikidata; removed Wikidata Analytics. Restricted Application added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T345660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: RhinosF1

[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions

2023-09-05 Thread Jdlrobson
Jdlrobson removed projects: Cite, ChessBrowser. TASK DETAIL https://phabricator.wikimedia.org/T328497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: KSiebert, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, Legoktm

[Wikidata-bugs] [Maniphest] T343052: Evaluate Wikidata's mobile site: Reconsider how Wikidata uses MobileFrontend/Minerva

2023-07-31 Thread Jdlrobson
Jdlrobson added a comment. Collapsible sections in part of MobileFrontend, so disabling MobileFrontend would remove the feature. MobileFrontend could be retained using a more limited set of functionality, I've added that as an option. > which is why I’d prefer turning off cont

[Wikidata-bugs] [Maniphest] T343052: Evaluate Wikidata's mobile site: Reconsider how Wikidata uses MobileFrontend/Minerva

2023-07-31 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T343052 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Tacsipacsi, Aklapper, Lydia_Pintscher, Masumrezarock100, Jdlrobson, Danny_Benjafield_WMDE

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2023-07-28 Thread Jdlrobson
Jdlrobson added a comment. @Lydia_Pintscher done: T343052 <https://phabricator.wikimedia.org/T343052> hope that's helpful! TASK DETAIL https://phabricator.wikimedia.org/T340859 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrob

[Wikidata-bugs] [Maniphest] T343052: Evaluate Wikidata's mobile site: Reconsider how Wikidata uses MobileFrontend/Minerva

2023-07-28 Thread Jdlrobson
Jdlrobson created this task. Jdlrobson added a project: Wikidata. Restricted Application added subscribers: Masumrezarock100, Aklapper. TASK DESCRIPTION Wikidata engineers should spend some time assessing how Wikidata uses MobileFrontend/Minerva and determine whether it should continue

[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions

2023-07-21 Thread Jdlrobson
Jdlrobson edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25), Citoid. TASK DETAIL https://phabricator.wikimedia.org/T328497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc

[Wikidata-bugs] [Maniphest] T340859: Edit buttons overlap on Minerva on Wikidata

2023-07-20 Thread Jdlrobson
Jdlrobson added a comment. @PAC2 Minerva is not the problem here. I use the desktop skin on Wikidata.org without any problems: e.g. https://www.wikidata.org/wiki/Q42394599?useskin=minerva The problem is MobileFrontend which makes skins behave differently. Take a look at Vector 2022

[Wikidata-bugs] [Maniphest] T340859: Bug with the Minerva interface for Wikidata

2023-07-19 Thread Jdlrobson
Jdlrobson added a comment. @lucaS_werkmeister_WMDE this is a bit off topic but have we ever considered dropping MobileFrontend and Minerva from Wikidata.org and instead enable wgVectorResponsive? The main benefit of MobileFrontend these days is content massaging (e.g. section collapsing

[Wikidata-bugs] [Maniphest] T340859: Bug with the Minerva interface for Wikidata

2023-07-19 Thread Jdlrobson
Jdlrobson moved this task from Backlog to Tracking on the MinervaNeue board. Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue. TASK DETAIL https://phabricator.wikimedia.org/T340859 WORKBOARD https://phabricator.wikimedia.org/project/board/2799/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T117720: Remove use of jquery.tipsy from Wikimedia-maintained code

2023-07-18 Thread Jdlrobson
Jdlrobson closed subtask T143028: Remove use of jquery.tipsy in CodeReview as Declined. TASK DETAIL https://phabricator.wikimedia.org/T117720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: stjn, Jdlrobson, IKhitron, YFdyh000, Alfa80

[Wikidata-bugs] [Maniphest] T327510: Vector Search: Adjust bolding pattern of suggestions in Wikidata

2023-07-11 Thread Jdlrobson
Jdlrobson removed a project: Readers-Web-Backlog (Web Team FY2023-24 Q1 Sprint 2). TASK DETAIL https://phabricator.wikimedia.org/T327510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Jdlrobson Cc: ItamarWMDE, Jdlrobson, AnneT

[Wikidata-bugs] [Maniphest] T327510: Vector Search: Adjust bolding pattern of suggestions in Wikidata

2023-07-10 Thread Jdlrobson
Jdlrobson edited projects, added Readers-Web-Backlog (Web Team FY2023-24 Q1 Sprint 2); removed Readers-Web-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T327510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Jdlrobson Cc

[Wikidata-bugs] [Maniphest] T327510: Vector Search: Adjust bolding pattern of suggestions in Wikidata

2023-07-07 Thread Jdlrobson
Jdlrobson added a project: Readers-Web-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T327510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Jdlrobson Cc: ItamarWMDE, Jdlrobson, AnneT, Lydia_Pintscher, Michael, Sarai-WMDE

[Wikidata-bugs] [Maniphest] T340859: Bug with the Minerva interface for Wikidata

2023-07-06 Thread Jdlrobson
Jdlrobson added a comment. > I guess the affected gadgets need to be edited to load the dependencies dynamically in their JS code, rather than declare them in MediaWiki:Gadgets-definition, and also skip loading on mobile (mw.config.get( 'wgMFMode' ) !== null)? Not s

[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system

2023-06-30 Thread Jdlrobson
Jdlrobson removed a parent task: T127268: Dismantle ResourceLoader's "targets" system. TASK DETAIL https://phabricator.wikimedia.org/T324991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Nardog, ItamarWMDE, Lucas_Werkme

[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system

2023-06-29 Thread Jdlrobson
Jdlrobson closed subtask T326428: Make more Wikibase ResourceLoader modules available on mobile as well as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T324991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Nardog

[Wikidata-bugs] [Maniphest] T326428: Make more Wikibase ResourceLoader modules available on mobile as well

2023-06-29 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. All modules should be available on desktop and mobile now that the targets system. You can verify this by calling mw.loader.getState of any module - it should return registered

[Wikidata-bugs] [Maniphest] T335121: [PATCH REVIEW] Migrate away from `targets` key in WikibaseRepo and WikibaseLib

2023-06-29 Thread Jdlrobson
Jdlrobson added a comment. ^ ping TASK DETAIL https://phabricator.wikimedia.org/T335121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Jdlrobson Cc: hoo, ItamarWMDE, Aklapper, Jdlrobson, Isabelladantes1983, Themindcoder, Adamm71

[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system

2023-06-29 Thread Jdlrobson
Jdlrobson added a comment. Can this be resolved? Looks done to me! TASK DETAIL https://phabricator.wikimedia.org/T324991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Nardog, ItamarWMDE, Lucas_Werkmeister_WMDE, StudiesWorld

[Wikidata-bugs] [Maniphest] T316797: Languages show at bottom of page in Wikidata Vector 2022 skin due to media query that should be reconsidered

2023-06-26 Thread Jdlrobson
Jdlrobson removed a project: Readers-Web-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T316797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Lucas_Werkmeister_WMDE, Aklapper, Jdlrobson, Astuthiodit_1, karapayneWMDE

[Wikidata-bugs] [Maniphest] T336931: The link "Edit interlanguage links" on Vector 2022 didn't direct to wikidata

2023-06-26 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T336931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Edtadros, Jdlrobson, Func, Quiddity, Melos, Aklapper, Patafisik, JCW555,

[Wikidata-bugs] [Maniphest] T336931: The link "Edit interlanguage links" on Vector 2022 didn't direct to wikidata

2023-06-20 Thread Jdlrobson
Jdlrobson set the point value for this task to "0". TASK DETAIL https://phabricator.wikimedia.org/T336931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson, Func, Quiddity, Melos, Aklapper, Patafisik, JCW555

[Wikidata-bugs] [Maniphest] T335121: [PATCH REVIEW] Migrate away from `targets` key in WikibaseRepo and WikibaseLib

2023-06-15 Thread Jdlrobson
Jdlrobson added a comment. Can this be resolved now? TASK DETAIL https://phabricator.wikimedia.org/T335121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Jdlrobson Cc: hoo, ItamarWMDE, Aklapper, Jdlrobson, Isabelladantes1983

[Wikidata-bugs] [Maniphest] T331760: "mw.config.values.wbSiteDetails" module downloads 27.3 kB of compressed JavaScript on Vector-22 page load

2023-06-12 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson added a comment. Yay! Thanks for working on this! TASK DETAIL https://phabricator.wikimedia.org/T331760 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: ngkountas

[Wikidata-bugs] [Maniphest] T336931: The link "Edit interlanguage links" on Vector 2022 didn't direct to wikidata

2023-06-12 Thread Jdlrobson
Jdlrobson triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T336931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson, Func, Quiddity, Melos, Aklapper, Patafisik, JCW555, hnijhuis, Ast

[Wikidata-bugs] [Maniphest] T318138: Cannot manually log in on mobile Wikidata (real or test)

2023-06-09 Thread Jdlrobson
Jdlrobson added a comment. Could https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/4fddd1269809960b9a7faa0c480ca6a9d735d36e/wmf-config/CommonSettings.php#2767 have something to do with this? Looks like there is no rules for wikidata so a little suspicious. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T337854: Wikidata page banner should make use of object-position

2023-06-09 Thread Jdlrobson
Jdlrobson added a comment. Hi @TheDJ https://en.wikivoyage.beta.wmflabs.org/wiki/Main_Page would be the best place to hunt for examples. https://en.wikivoyage.beta.wmflabs.org/w/index.php?title=Special:WhatLinksHere/Template:pagebanner https://en.wikivoyage.beta.wmflabs.org/w

[Wikidata-bugs] [Maniphest] T338492: FederatedPropertiesErrorTest.php unit test has encoding issues and is blocking markup change

2023-06-09 Thread Jdlrobson
Jdlrobson added a comment. @tarrow if it's missing a team could we perhaps skip the test for now? TASK DETAIL https://phabricator.wikimedia.org/T338492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: WMDE-leszek, Tarrow, ItamarWMDE

[Wikidata-bugs] [Maniphest] T329699: WE-F framework no longer works on certain wiki layouts

2023-06-08 Thread Jdlrobson
Jdlrobson edited projects, added Reading-Web-Local-Wiki-Issues; removed Desktop Improvements (Vector 2022). TASK DETAIL https://phabricator.wikimedia.org/T329699 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Seudo, putnik, Aklapper

[Wikidata-bugs] [Maniphest] T336931: The link "Edit interlanguage links" on Vector 2022 didn't direct to wikidata

2023-06-08 Thread Jdlrobson
Jdlrobson added a project: Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 6). Jdlrobson added a comment. Adding to sprint 6 for QA in production TASK DETAIL https://phabricator.wikimedia.org/T336931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T336931: The link "Edit interlanguage links" on Vector 2022 didn't direct to wikidata

2023-06-08 Thread Jdlrobson
Jdlrobson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T336931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Func, Quiddity, Melos, Aklapper, Patafisik, JCW555, hnijhuis, Astuthiodit_1, Patafisik_WMF

[Wikidata-bugs] [Maniphest] T232777: id attribute isn't set correctly when adding another statement

2023-06-08 Thread Jdlrobson
Jdlrobson added a project: Wikidata-Campsite. Jdlrobson added a comment. Hey @nikki i'm not familiar with this code but tagging some people that might be. TASK DETAIL https://phabricator.wikimedia.org/T232777 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T294862: t.message is not a function (from wikibase.termbox)

2023-06-08 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. There are no instances of this error in the last 90 days. TASK DETAIL https://phabricator.wikimedia.org/T294862 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] T117720: Remove use of jquery.tipsy from Wikimedia-maintained code

2023-05-26 Thread Jdlrobson
Jdlrobson closed subtask T282547: Remove jquery.tipsy skinsStyles from legacy Vector as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T117720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson, IKhitron, YFdyh000

[Wikidata-bugs] [Maniphest] T117720: Remove use of jquery.tipsy from Wikimedia-maintained code

2023-05-26 Thread Jdlrobson
Jdlrobson changed the status of subtask T282547: Remove jquery.tipsy skinsStyles from legacy Vector from Stalled to Open. TASK DETAIL https://phabricator.wikimedia.org/T117720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson

[Wikidata-bugs] [Maniphest] T337200: Feature request: Support multiple primary coordinates in articles for Special:Nearby

2023-05-25 Thread Jdlrobson
Jdlrobson renamed this task from "Special:Nearby does not show rivers with two coordinates (water spring + river mouth)" to "Feature request: Support multiple primary coordinates in articles for Special:Nearby". Jdlrobson updated the task description.

[Wikidata-bugs] [Maniphest] T337200: Special:Nearby does not show rivers with two coordinates (water spring + river mouth)

2023-05-25 Thread Jdlrobson
Jdlrobson edited projects, added Wikidata, GeoData; removed Readers-Web-Backlog, NearbyPages. Jdlrobson added a comment. Restricted Application added a project: Discovery-Search. NearbyPages uses primary coordinates on an article and renders whatever the API gives it. Currently in Wikipedia

[Wikidata-bugs] [Maniphest] T336956: Mobile version of Wikidata broken on some pages

2023-05-20 Thread Jdlrobson
Jdlrobson added a subscriber: LucasWerkmeister. Jdlrobson added a comment. Hey @LucasWerkmeister so if I understand correctly the plan is to merge https://gerrit.wikimedia.org/r/921570 and revert it a month later, at which point all the pages in cache should be updated. Is that correct

[Wikidata-bugs] [Maniphest] T143038: Remove use of jquery.tipsy in Wikibase

2023-05-20 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. Done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/915868 TASK DETAIL https://phabricator.wikimedia.org/T143038 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-16 Thread Jdlrobson
Jdlrobson reassigned this task from Jdlrobson to Edtadros. TASK DETAIL https://phabricator.wikimedia.org/T336264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Edtadros, Jdlrobson Cc: Edtadros, Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-16 Thread Jdlrobson
Jdlrobson moved this task from Ready for Signoff to QA in Production on the Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board. Jdlrobson added a comment. Great. We should verify this in production later tomorrow: https://en.wikivoyage.org/wiki/France TASK DETAIL https

[Wikidata-bugs] [Maniphest] T117720: Remove use of jquery.tipsy from Wikimedia-maintained code

2023-05-16 Thread Jdlrobson
Jdlrobson closed this task as "Resolved". Jdlrobson claimed this task. Jdlrobson added a comment. Now done. I've updated T336019 <https://phabricator.wikimedia.org/T336019> with details on mitigation strategies for broken gadgets. Skin style removal tracked in

  1   2   3   4   5   6   7   8   9   10   >