[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

2016-02-23 Thread adrianheine
adrianheine added a comment. Current patch revision does good things: In chromium, it breaks on whitespace where possible, long words just randomly. In Firefox, it adds hyphens. Reviewers, please check in your browsers. TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T127191: [Task] Allow extensions to register additonal EntityViews

2016-02-23 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T127191#2054679, @Bene wrote: > I'd also add factory methods for the `StatementSectionsView` and `EntityTermsView` because extensions of Wikibase defining new entity types want to reuse those views.

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

2016-02-23 Thread adrianheine
adrianheine added a comment. Long words are an issue. I see three straight-forward workarounds. @Lydia_Pintscher @Incabell Limit leakage to length of site id: F3405816: Screenshot from 2016-02-23 12-27-51.png <https://phabricator.wikimedia.org/F3405816> Break words wh

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T127067: [Story] Reduce initialisation time of SiteLinks

2016-02-23 Thread adrianheine
adrianheine added a subscriber: Incabell. adrianheine added a comment. @Incabell says vertical-align: middle. TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Incabell

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

2016-02-23 Thread adrianheine
adrianheine added a comment. Two versions of site id positioning: F3404155: Screenshot from 2016-02-23 10-51-18.png <https://phabricator.wikimedia.org/F3404155> F3404156: Screenshot from 2016-02-23 10-51-53.png <https://phabricator.wikimedia.org/F3404156> TASK DE

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125503: [Story] Reduce initialization time of Statementview

2016-02-23 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125503 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Unblock] T56098: [Epic][UI] Front-end performance: Improve loading time of items

2016-02-23 Thread adrianheine
adrianheine closed blocking task T125503: [Story] Reduce initialization time of Statementview as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T56098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Agabi10,

[Wikidata-bugs] [Maniphest] [Closed] T125503: [Story] Reduce initialization time of Statementview

2016-02-23 Thread adrianheine
adrianheine closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T125503 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lydia_Pintscher, gerritbot, Agabi10, thiemowmde, adrianheine, Jonas, Akla

[Wikidata-bugs] [Maniphest] [Closed] T100654: [Task] use generic composer based Jenkins jobs for WikibaseJavaScriptApi CI

2016-02-23 Thread adrianheine
adrianheine closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T100654 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, adrianheine Cc: gerritbot, Paladox, JanZerebecki, aude, Aklapper, Izno, Wik

[Wikidata-bugs] [Maniphest] [Changed Project Column] T100654: [Task] use generic composer based Jenkins jobs for WikibaseJavaScriptApi CI

2016-02-23 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T100654 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Unblock] T108946: [Epic] Improve the development infrastructure

2016-02-23 Thread adrianheine
adrianheine closed blocking task T100654: [Task] use generic composer based Jenkins jobs for WikibaseJavaScriptApi CI as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T108946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adri

[Wikidata-bugs] [Maniphest] [Changed Project Column] T126426: Wikidata.org extension tests fail on Jenkins

2016-02-23 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T126426 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T126426: Wikidata.org extension tests fail on Jenkins

2016-02-23 Thread adrianheine
adrianheine closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T126426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, adrianheine Cc: JanZerebecki, Aklapper, aude, StudiesWorld, Izno, Wikidata-bug

[Wikidata-bugs] [Maniphest] [Changed Project Column] T127305: [Task] Change ellipsis from JS to CSS

2016-02-23 Thread adrianheine
adrianheine moved this task to Backlog on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T127305 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Changed Project Column] T127316: [Bug] Can not save new quantity statement

2016-02-23 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T127316 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T127316: [Bug] Can not save new quantity statement

2016-02-23 Thread adrianheine
adrianheine closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T127316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, Aklapper, adrianheine, thiemowmde, Lydia_Pintscher, Jonas, Izno,

[Wikidata-bugs] [Maniphest] [Unblock] T125503: [Story] Reduce initialization time of Statementview

2016-02-23 Thread adrianheine
adrianheine closed blocking task T127316: [Bug] Can not save new quantity statement as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T125503 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T127067: [Story] Reduce initialisation time of SiteLinks

2016-02-23 Thread adrianheine
adrianheine added a subscriber: Lydia_Pintscher. adrianheine added a comment. @Lydia_Pintscher We should talk about this today, unless you already know what you want. TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T127316: [Bug] Can not save new quantity statement

2016-02-22 Thread adrianheine
adrianheine added a comment. Don't forget that we need a valueview release and dependency bump TASK DETAIL https://phabricator.wikimedia.org/T127316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, Aklapper, adrianheine

[Wikidata-bugs] [Maniphest] [Commented On] T127191: [Task] Allow extensions to register additonal EntityViews

2016-02-18 Thread adrianheine
adrianheine added a comment. From my point of view, `WikibaseView` is a component providing widgets for a specific set of `WikibaseDataModel` concepts. Since the widgets for items and properties use all other widgets, we provide an `EntityViewFactory` wiring them together. `Wikibase\View

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-18 Thread adrianheine
adrianheine added a comment. I checked again: This works locally. TASK DETAIL https://phabricator.wikimedia.org/T126585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore

[Wikidata-bugs] [Maniphest] [Changed Project Column] T127305: [Task] Change ellipsis from JS to CSS

2016-02-18 Thread adrianheine
adrianheine moved this task to Review on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T127305 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T124042: [Task] Adapt UI to use new wbformatvalue parameter

2016-02-18 Thread adrianheine
adrianheine closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T124042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, adrianheine Cc: daniel, gerritbot, Bene, Tobi_WMDE_SW, Lydia_Pintscher, thiemowmde,

[Wikidata-bugs] [Maniphest] [Changed Project Column] T124042: [Task] Adapt UI to use new wbformatvalue parameter

2016-02-18 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T124042 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Unblock] T124918: [Task] Support external identifier datatype in javascript ui

2016-02-18 Thread adrianheine
adrianheine closed blocking task T124042: [Task] Adapt UI to use new wbformatvalue parameter as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T124918 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, adrianheine Cc: To

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-18 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-16 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125064 WORKBOARD https://phabricator.wikimedia.org/project/board/1744/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Unblock] T95684: [Story] Format identifiers as Links

2016-02-18 Thread adrianheine
adrianheine closed blocking task T124042: [Task] Adapt UI to use new wbformatvalue parameter as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T95684 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: mate

[Wikidata-bugs] [Maniphest] [Closed] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-18 Thread adrianheine
adrianheine closed this task as "Resolved". adrianheine claimed this task. adrianheine added a comment. https://www.wikidata.org/wiki/Help:Monolingual_text_languages TASK DETAIL https://phabricator.wikimedia.org/T125064 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Unblock] T124757: [Story] Improve the set of language codes available for monolingual text values

2016-02-18 Thread adrianheine
adrianheine closed blocking task T125064: [Task] Define and document process for requesting language codes for monolingual text values as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T124757 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Commented On] T125073: [Story] Replace bad, but currently necessary language codes

2016-02-17 Thread adrianheine
adrianheine added a comment. @XXN First, there is no urgency whatsoever. I don't currently plan on doing this story, it's just for future reference. Second, even if I would do this change, existing data on Wikidata.org would continue to work, we would just prevent saving of these language

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-17 Thread adrianheine
adrianheine added a comment. Locally this failed because of rate limiting and stopped failing after I changed config. I'll try again locally. TASK DETAIL https://phabricator.wikimedia.org/T126585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T127095: Unable to add statement with math or external identifier data type

2016-02-17 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. https://gerrit.wikimedia.org/r/#/c/271242/ should help debugging such changes in the future. TASK DETAIL https://phabricator.wikimedia.org/T127095 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Edited] T127056: [Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController

2016-02-16 Thread adrianheine
adrianheine edited the task description. adrianheine set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T127056 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Izno, Wikidata-bugs, aude, Mbch331

[Wikidata-bugs] [Maniphest] [Updated] T127055: [Task] Use ViewController for editing in statementview

2016-02-16 Thread adrianheine
adrianheine added a project: Wikidata-Sprint-2016-02-16. TASK DETAIL https://phabricator.wikimedia.org/T127055 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Izno, Wikidata-bugs, aude, Mbch331

[Wikidata-bugs] [Maniphest] [Updated] T127055: [Task] Use ViewController for editing in statementview

2016-02-16 Thread adrianheine
adrianheine added a blocked task: T127056: [Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController. TASK DETAIL https://phabricator.wikimedia.org/T127055 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc

[Wikidata-bugs] [Maniphest] [Updated] T127056: [Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController

2016-02-16 Thread adrianheine
adrianheine added a blocking task: T127055: [Task] Use ViewController for editing in statementview. TASK DETAIL https://phabricator.wikimedia.org/T127056 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Izno

[Wikidata-bugs] [Maniphest] [Updated] T117689: [Task] Introduce ViewController for managing edit mode in referenceview

2016-02-16 Thread adrianheine
adrianheine added a blocked task: T127056: [Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController. TASK DETAIL https://phabricator.wikimedia.org/T117689 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc

[Wikidata-bugs] [Maniphest] [Updated] T127056: [Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController

2016-02-16 Thread adrianheine
adrianheine added a blocking task: T117689: [Task] Introduce ViewController for managing edit mode in referenceview. TASK DETAIL https://phabricator.wikimedia.org/T127056 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine

[Wikidata-bugs] [Maniphest] [Created] T127056: [Story] Replace jquery.wikibase.toolbarcontroller by wikibase.view.ViewController

2016-02-16 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T127056 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T127055: [Task] Use ViewController for editing in statementview

2016-02-16 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION In T117689, we introduced ViewController, but it's unused now. All our views with edit mode should use it. Let's start

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-16 Thread adrianheine
adrianheine added a comment. Not fixed :/ TASK DETAIL https://phabricator.wikimedia.org/T126585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, Aklapper, Izno

[Wikidata-bugs] [Maniphest] [Commented On] T124918: [Task] Support external identifier datatype in javascript ui

2016-02-16 Thread adrianheine
adrianheine added a comment. @Bene Now that the blockers are fixed, do you want to update your change? If you don't have time in the next sprint for that, I could also have a look at it. TASK DETAIL https://phabricator.wikimedia.org/T124918 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Edited] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-16 Thread adrianheine
adrianheine edited the task description. adrianheine set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T125064 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Izno, Wikidata-bugs, aude, Mbch331

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-16 Thread adrianheine
adrianheine moved this task to Review on the Wikidata-Sprint-2016-02-02 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125064 WORKBOARD https://phabricator.wikimedia.org/project/board/1722/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-16 Thread adrianheine
adrianheine added a comment. First draft: https://www.wikidata.org/wiki/User:Adrian_Heine_%28WMDE%29/Mono TASK DETAIL https://phabricator.wikimedia.org/T125064 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-16 Thread adrianheine
adrianheine added a project: Wikidata-Sprint-2016-02-02. TASK DETAIL https://phabricator.wikimedia.org/T125064 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Izno, Wikidata-bugs, aude, Mbch331

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125521: [Task] Refactor how formatters are passed to valueview

2016-02-16 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-02 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125521 WORKBOARD https://phabricator.wikimedia.org/project/board/1722/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Unblock] T124042: [Task] Adapt UI to use new wbformatvalue parameter

2016-02-16 Thread adrianheine
adrianheine closed blocking task T125521: [Task] Refactor how formatters are passed to valueview as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T124042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, adrianheine

[Wikidata-bugs] [Maniphest] [Closed] T125521: [Task] Refactor how formatters are passed to valueview

2016-02-16 Thread adrianheine
adrianheine closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T125521 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, adrianheine, aude, hoo, thiemowmde, Lydia_Pintscher, Tobi_WMD

[Wikidata-bugs] [Maniphest] [Commented On] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-16 Thread adrianheine
adrianheine added a comment. What about the talk pages of monolingual text value properties? TASK DETAIL https://phabricator.wikimedia.org/T125064 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Aklapper, Izno, Wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-02-16 Thread adrianheine
adrianheine added a comment. - MediaWiki:Wikibase-listdatatypes-monolingualtext-body <https://www.wikidata.org/wiki/MediaWiki:Wikibase-listdatatypes-monolingualtext-body> for Special:ListDatatypes <https://www.wikidata.org/wiki/Special:ListDatatypes> - Help:Data type <https://w

[Wikidata-bugs] [Maniphest] [Commented On] T126152: [RFC] Design of provider/holder interfaces in Wikibase's data model

2016-02-12 Thread adrianheine
adrianheine added a comment. I suppose ChangeOps could easily work with immutable objects by having setters return new objects. For deserialization, this would probably produce a lot of objects, though. Can't we deserialize bottom-up to avoid this? TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T126152: [RFC] Design of provider/holder interfaces in Wikibase's data model

2016-02-12 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T126152#2021971, @daniel wrote: > In https://phabricator.wikimedia.org/T126152#2021847, @adrianheine wrote: > > > Why would that be awkward? > > > For one thing, because the SiteLinkList (and Reference

[Wikidata-bugs] [Maniphest] [Commented On] T126152: [RFC] Design of provider/holder interfaces in Wikibase's data model

2016-02-12 Thread adrianheine
adrianheine added a comment. Why would that be awkward? It's another item. Also, you don't need the old one afterwards. I think in ChangeOps it would not look worse. Also, what would be inefficient about that? We are neither doing a lot of changes in ChangeOps nor are we working a lot

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread adrianheine
adrianheine added subscribers: Tobi_WMDE_SW, JanZerebecki. adrianheine added a comment. @tobi_WMDE_SW @addshore @janzerebecki Rate limiting settings for beta need to be adapted, either by IP or in general. TASK DETAIL https://phabricator.wikimedia.org/T126585 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Reopened] T125521: [Task] Refactor how formatters are passed to valueview

2016-02-11 Thread adrianheine
adrianheine reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T125521 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, adrianheine, aude, hoo, thiemowmde, Lydia_Pintscher, Tobi_WMD

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125521: [Task] Refactor how formatters are passed to valueview

2016-02-11 Thread adrianheine
adrianheine moved this task to Review on the Wikidata-Sprint-2016-02-02 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125521 WORKBOARD https://phabricator.wikimedia.org/project/board/1722/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Block] T124042: [Task] Adapt UI to use new wbformatvalue parameter

2016-02-11 Thread adrianheine
adrianheine reopened blocking task T125521: [Task] Refactor how formatters are passed to valueview as "Open". TASK DETAIL https://phabricator.wikimedia.org/T124042 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, adrianheine

[Wikidata-bugs] [Maniphest] [Retitled] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread adrianheine
adrianheine changed the title from "Sitelink browser test fails with firefox" to "Sitelink browser test sometimes fails with firefox". adrianheine edited the task description. adrianheine set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T126585 EMAIL

[Wikidata-bugs] [Maniphest] [Created] T126585: Sitelink browser test fails with firefox

2016-02-11 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added projects: Browser-Tests, Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION Edit sitelinks/Remove multiple sitelinks fails on sauce and locally in firefox: ``` And I remove all

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread adrianheine
adrianheine added a comment. This is a rate limiting problem. Whenever the test fails, I have the following in my debug log: [ratelimit] User '0:0:0:0:0:0:0:1' (IP ::1) tripped my_wiki:limiter:edit:ip:%3A%3A1 at 8 (limit 8 in 60s) TASK DETAIL https://phabricator.wikimedia.org/T126585

[Wikidata-bugs] [Maniphest] [Commented On] T118860: [RFC] Use Role Object Pattern to represent derived data in the data model

2016-02-11 Thread adrianheine
adrianheine added a comment. Not quite. I want to see facet usage to have more opportunities at explaining you why I think they are bad, since my abstract points didn't get to you yet :) TASK DETAIL https://phabricator.wikimedia.org/T118860 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T126512: flaky qunit test wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode()

2016-02-11 Thread adrianheine
adrianheine added a comment. I don't get how this fails. If `ExtensionRegistry::getInstance()->isLoaded( 'UniversalLanguageSelector' )`, we require `ext.uls.mediawiki`. `ext.uls.mediawiki` depends on `ext.uls.init` as well as `jquery.uls`, which in turn depends on `jquery.uls.data`. B

[Wikidata-bugs] [Maniphest] [Commented On] T126512: flaky qunit test wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode()

2016-02-11 Thread adrianheine
adrianheine added a comment. They are not flaky imho, they consistently fail since yesterday ~ 6PM TASK DETAIL https://phabricator.wikimedia.org/T126512 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, daniel, Jonas

[Wikidata-bugs] [Maniphest] [Commented On] T126512: flaky qunit test wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode()

2016-02-11 Thread adrianheine
adrianheine added a comment. qunit now passes with patch set 4, but selenium started being flaky. `recheck`'d. TASK DETAIL https://phabricator.wikimedia.org/T126512 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, daniel

[Wikidata-bugs] [Maniphest] [Commented On] T125503: [Story] Reduce initialization time of Statementview

2016-02-11 Thread adrianheine
adrianheine added a comment. I'd consider this done when the last linked change is merged. It reduces loading time of big items by around 50% for me. TASK DETAIL https://phabricator.wikimedia.org/T125503 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125503: [Story] Reduce initialization time of Statementview

2016-02-11 Thread adrianheine
adrianheine moved this task to Review on the Wikidata-Sprint-2016-02-02 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125503 WORKBOARD https://phabricator.wikimedia.org/project/board/1722/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Edited] T125503: [Story] Reduce initialization time of Statementview

2016-02-11 Thread adrianheine
adrianheine edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T125503 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, Agabi10, thiemowmde, adrianheine, Jonas, Aklapper, Izno, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Commented On] T126512: flaky qunit test wikibase.getLanguageNameByCode wikibase.getLanguageNameByCode()

2016-02-11 Thread adrianheine
adrianheine added a comment. selenium consistently failed at `expect(page.first_heading?).to be true`. TASK DETAIL https://phabricator.wikimedia.org/T126512 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: gerritbot, daniel, Jonas

[Wikidata-bugs] [Maniphest] [Commented On] T126152: [RFC] Design of provider/holder interfaces in Wikibase's data model

2016-02-09 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Where do we currently need mutability of our data model objects? TASK DETAIL https://phabricator.wikimedia.org/T126152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T112548: [Epic] Provide derived values for re-use by third parties (as well as for internal use)

2016-02-09 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T112548 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Ricordisamoa, Aklapper, daniel, Izno, Wikidata-bugs, aude, Mbch331

[Wikidata-bugs] [Maniphest] [Raised Priority] T125521: [Task] Refactor how formatters are passed to valueview

2016-02-09 Thread adrianheine
adrianheine moved this task to Review on the Wikidata-Sprint-2016-02-02 workboard. adrianheine raised the priority of this task from "Normal" to "High". TASK DETAIL https://phabricator.wikimedia.org/T125521 WORKBOARD https://phabricator.wikimedia.org/project/board/1722

[Wikidata-bugs] [Maniphest] [Lowered Priority] T125521: [Task] Refactor how formatters are passed to valueview

2016-02-09 Thread adrianheine
adrianheine lowered the priority of this task from "High" to "Normal". TASK DETAIL https://phabricator.wikimedia.org/T125521 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, adrianheine, aude, hoo, thiemow

[Wikidata-bugs] [Maniphest] [Updated] T125073: [Story] Replace bad, but currently necessary language codes

2016-02-09 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T125073#2001862, @Nikki wrote: > I was mostly talking about terms because they're more common than monolingual > text statements. :) I can't think of anything where I would expect them be > treated differently though, o

[Wikidata-bugs] [Maniphest] [Commented On] T125503: [Story] Reduce initialization time of Statementview

2016-02-09 Thread adrianheine
adrianheine added a comment. Patch merged, https://github.com/wmde/WikibaseDataModelJavaScript/milestones/3.0.0 still to be done. TASK DETAIL https://phabricator.wikimedia.org/T125503 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc

[Wikidata-bugs] [Maniphest] [Changed Project Column] T125063: [Task] Remove universally bad language codes from the set of language codes available for monolingual text values

2016-02-09 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2016-02-02 workboard. TASK DETAIL https://phabricator.wikimedia.org/T125063 WORKBOARD https://phabricator.wikimedia.org/project/board/1722/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T125502: [Task] Investigate time spent for initialization of individual widgets

2016-02-03 Thread adrianheine
adrianheine added a comment. It's roughly like this (arbitrary numbers, but the relations should be somewhat right): - 12 seconds for everything - 9 seconds without `snakview`s - 4.7 seconds without `statementview`s - 4.5 seconds without `entityview` The item I tested on didn't have any

[Wikidata-bugs] [Maniphest] [Closed] T124276: HHVM 3.11 segfaults with Wikibase when transliteration is done

2016-02-03 Thread adrianheine
adrianheine closed this task as "Resolved". adrianheine added a comment. Change got merged, but might not get into a 3.11 patch release. TASK DETAIL https://phabricator.wikimedia.org/T124276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Closed] T95419: [Bug] Save button inactive when changing language on monolingual text statements

2016-02-02 Thread adrianheine
adrianheine closed this task as "Resolved". adrianheine added a comment. Works for me with ValueView 0.15.8. TASK DETAIL https://phabricator.wikimedia.org/T95419 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, adrianhei

[Wikidata-bugs] [Maniphest] [Edited] T125073: [Story] Replace bad, but currently necessary language codes

2016-01-30 Thread adrianheine
adrianheine edited the task description. adrianheine set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T125073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Nikki, Fomafix, adrianheine, Aklapper, Izno, Wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T125073: [Story] Replace bad, but currently necessary language codes

2016-01-30 Thread adrianheine
adrianheine added a comment. Thanks for your feedback, @Nikki. I added `nrm` to the list. As for `cbk-zam` and `roa-tara`, they could be `cbk-x-zam` and `roa-x-tara` to be valid, right? I fixed `sr` in the description. The comments in `languages/Names.php` say it's »Serbian Cyrillic ekavian

[Wikidata-bugs] [Maniphest] [Closed] T87580: caching difference between current language in top header and current language in in other languages box

2016-01-28 Thread adrianheine
adrianheine closed this task as "Invalid". adrianheine claimed this task. adrianheine added a comment. I suppose this is not an issue anymore. TASK DETAIL https://phabricator.wikimedia.org/T87580 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Commented On] T117886: [Task] Don't fail when running job mediawiki-extensions-qunit with Wikidata

2016-01-28 Thread adrianheine
adrianheine added a comment. Yeah :) TASK DETAIL https://phabricator.wikimedia.org/T117886 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, adrianheine Cc: gerritbot, thiemowmde, adrianheine, Aklapper, JanZerebecki, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Updated] T125063: [Task] Remove universally bad language codes from the set of language codes available for monolingual text values

2016-01-28 Thread adrianheine
adrianheine added a comment. - Language codes that are not even well-formed BCP 47 <https://en.wikipedia.org/wiki/IETF_language_tag> language codes - `tokipona`, `simple` - Duplicate, deprecated language codes - `roa-rup` (=> `rup`), `bat-smg` (=> `sgs`), `be-x-old` (=> `be-

[Wikidata-bugs] [Maniphest] [Created] T125073: [Story] Replace bad, but currently necessary language codes

2016-01-28 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION * `eml` does not exist, it should be `egl` or `rgn` * `map-bms` uses a very generic primary language subtag, it could

[Wikidata-bugs] [Maniphest] [Updated] T125066: [Task] Add already-requested language codes to set of language codes available for monolingual text values

2016-01-28 Thread adrianheine
adrianheine added a blocked task: T74126: [Story] Monolingual text does not accept sr-cyrl and a number of other language codes. TASK DETAIL https://phabricator.wikimedia.org/T125066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc

[Wikidata-bugs] [Maniphest] [Updated] T74126: [Story] Monolingual text does not accept sr-cyrl and a number of other language codes

2016-01-28 Thread adrianheine
adrianheine added a blocking task: T125066: [Task] Add already-requested language codes to set of language codes available for monolingual text values. TASK DETAIL https://phabricator.wikimedia.org/T74126 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T72205: [Story] Mono-lingual text datatype should support "no linguistic content" and "undetermined language"

2016-01-28 Thread adrianheine
adrianheine added a comment. Apparently, a fix around this did not get deployed, so the suggester might not even allow these four language codes yet. Should get better next week. TASK DETAIL https://phabricator.wikimedia.org/T72205 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Retitled] T125062: [Task] Support monolingual text values with invalid language codes

2016-01-28 Thread adrianheine
adrianheine changed the title from "[Task] Support of monolingual text values with invalid language codes" to "[Task] Support monolingual text values with invalid language codes". adrianheine set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T12506

[Wikidata-bugs] [Maniphest] [Created] T125062: [Task] Support of monolingual text values with invalid language codes

2016-01-28 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION Language codes for monolingual text values should only be validated when entering the system. Everywhere else, they should

[Wikidata-bugs] [Maniphest] [Created] T125066: [Task] Add already-requested language codes to set of language codes available for monolingual text values

2016-01-28 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION As a first step, these language codes should be added to the PHP definition of `ContentLanguages`, so that they are available

[Wikidata-bugs] [Maniphest] [Created] T125063: [Task] Remove universally bad language codes from the set of language codes available for monolingual text values

2016-01-28 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION There are some language codes currently supported that we should not support at all. They have to be removed from PHP and JS

[Wikidata-bugs] [Maniphest] [Created] T125064: [Task] Define and document process for requesting language codes for monolingual text values

2016-01-28 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T125064 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Closed] T95286: [Story] Monolingual text should support macrolanguages

2016-01-28 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as "Resolved". adrianheine claimed this task. adrianheine added a comment. You can already use `no` via API. UI support will get better with the next deployment so that you can enter it in the UI and save, bu

[Wikidata-bugs] [Maniphest] [Declined] T53071: Utils::getLanguageCodes() should filter [[mw:Manual:$wgDummyLanguageCodes]] out

2016-01-28 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as "Declined". adrianheine claimed this task. adrianheine added a comment. Code does not exist anymore, https://phabricator.wikimedia.org/T44396 is a better place to track the user-facing issue. TASK DETA

[Wikidata-bugs] [Maniphest] [Updated] T39459: [Task] Don't try to add labels in non-existing languages: restrict to Language::isKnownLanguageTag

2016-01-28 Thread adrianheine
adrianheine added a blocked task: T124286: [Epic] Language support. TASK DETAIL https://phabricator.wikimedia.org/T39459 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Ricordisamoa, Liuxinyu970226, Aklapper, Fomafix, Nikola_Smolenski

[Wikidata-bugs] [Maniphest] [Updated] T124286: [Epic] Language support

2016-01-28 Thread adrianheine
adrianheine added a blocking task: T39459: [Task] Don't try to add labels in non-existing languages: restrict to Language::isKnownLanguageTag. TASK DETAIL https://phabricator.wikimedia.org/T124286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T124286: [Epic] Language support

2016-01-28 Thread adrianheine
adrianheine added a blocking task: T51024: [Task] Removal of de-formal from allowed language for labels. TASK DETAIL https://phabricator.wikimedia.org/T124286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Ricordisamoa, adrianheine

[Wikidata-bugs] [Maniphest] [Updated] T74590: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant)

2016-01-28 Thread adrianheine
adrianheine added a blocking task: T125066: [Task] Add already-requested language codes to set of language codes available for monolingual text values. TASK DETAIL https://phabricator.wikimedia.org/T74590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T125066: [Task] Add already-requested language codes to set of language codes available for monolingual text values

2016-01-28 Thread adrianheine
adrianheine added a blocked task: T74590: [Bug] Monolingual code is missing for Kvensk (fkv), Romani (rom) and Scandoromani (rmg-variant). TASK DETAIL https://phabricator.wikimedia.org/T125066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

<    1   2   3   4   5   6   7   8   9   10   >