[Wikidata-bugs] [Maniphest] [Changed Project Column] T221104: Disable failing ruby browser tests in daily browser tests

2019-04-24 Thread hoo
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. In T221104#5130208 <https://phabricator.wikimedia.org/T221104#5130208>, @Lucas_Werkmeister_WMDE wrote: > To be honest, I’m starting

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

2019-04-24 Thread hoo
hoo added a comment. In T212869#5122970 <https://phabricator.wikimedia.org/T212869#5122970>, @Lucas_Werkmeister_WMDE wrote: > Unfortunately the `ChangeOp` approach seems to have the same problem: it uses the base revision, not the parent revision, to check if

[Wikidata-bugs] [Maniphest] [Closed] T220602: Convert property Irish Grid Reference (P4091) from External identifier to String

2019-04-24 Thread hoo
hoo closed this task as "Resolved". hoo claimed this task. hoo added a comment. hoo@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/changePropertyDataType.php --wiki wikidatawiki --new-data-type string --property-id P4091 Successfully updated the property

[Wikidata-bugs] [Maniphest] [Edited] T221648: Add WikibaseSchema to make-wmf-branch/config.json

2019-04-23 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T221648 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lydia_Pintscher, Aklapper, Ifygal3, Lucas_Werkmeister_WMDE, pdehaye, alaa_wmde, Michael, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Edited] T221649: Add WikibaseSchema submodule to mediawiki/extensions.git

2019-04-23 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T221649 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lydia_Pintscher, Aklapper, Ifygal3, Lucas_Werkmeister_WMDE, pdehaye, alaa_wmde, Michael, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Commented On] T220883: Wikidata JSON dumps should include Lexemes

2019-04-23 Thread hoo
hoo added a comment. > While I understand your point, I fair that isolating some data from the main dump is only a temporary solution to its size growth. Sooner or later, it will weight 1 TB (even compressed), and we'll have to deal with this (as producer or as consumer). We ind

[Wikidata-bugs] [Maniphest] [Commented On] T220883: Wikidata JSON dumps should include Lexemes

2019-04-22 Thread hoo
hoo added a comment. In T220883#5127292 <https://phabricator.wikimedia.org/T220883#5127292>, @Lydia_Pintscher wrote: > Is anything missing before we can create those separate dumps? Any decisions we still need to take? I just test-dumped a Lexeme in production and

[Wikidata-bugs] [Maniphest] [Declined] T173008: Create a maintenance script for pruning stale entity subscriptions and run periodically

2019-04-18 Thread hoo
hoo closed this task as "Declined". hoo added a comment. In T173008#3863378 <https://phabricator.wikimedia.org/T173008#3863378>, @Lydia_Pintscher wrote: > So let's be realistic and close this ticket? Yes, probably not worth spending time on right now.

[Wikidata-bugs] [Maniphest] [Unblock] T108944: [Epic] Improve change dispatching

2019-04-18 Thread hoo
hoo closed subtask T173008: Create a maintenance script for pruning stale entity subscriptions and run periodically as Declined. TASK DETAIL https://phabricator.wikimedia.org/T108944 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc

[Wikidata-bugs] [Maniphest] [Claimed] T194179: Allow configuring WDQS UI without changes to files under version control

2019-04-18 Thread hoo
hoo claimed this task. hoo edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T194179 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T218229: Wikidata gui grammatical features field no longer focus second entry

2019-04-18 Thread hoo
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo removed a project: Patch-For-Review. hoo added a comment. Problem on the demo site fixed, this just needs an OOUI release now. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T210598: Add data value type to Special:ListDatatypes

2019-04-18 Thread hoo
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. I assume this is complete for now, but please see T210598#5110640 <https://phabricator.wikimedia.org/T210598#5110640> before closing. TASK

[Wikidata-bugs] [Maniphest] [Claimed] T172937: Cursor jumping to next field and overlapping of menus

2019-04-17 Thread hoo
hoo claimed this task. hoo edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T172937 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

2019-04-17 Thread hoo
hoo added a comment. Why not do this as part of `ChangeOpDescription` and `ChangeOpLabel`? I know some places don't use this, but this seems to be the right place to me. TASK DETAIL https://phabricator.wikimedia.org/T212869 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Declined] T125352: Prefetch data needed for page rendering based on usage tracking data

2019-04-15 Thread hoo
hoo closed this task as "Declined". hoo added a comment. In T125352#3952803 <https://phabricator.wikimedia.org/T125352#3952803>, @samuwmde wrote: > Hej Marius is this still relevant? While I think this is still a good thing to consider, it doesn't solve an im

[Wikidata-bugs] [Maniphest] [Updated] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-15 Thread hoo
hoo removed a project: Patch-For-Review. hoo added a comment. The test page Lucas set up looks good now: https://wikidata.beta.wmflabs.org/wiki/Talk:Q15905 TASK DETAIL https://phabricator.wikimedia.org/T220122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T221025: WikibaseClient phpunit tests fail if the "repoDatabase" setting is not false

2019-04-15 Thread hoo
hoo created this task. hoo added projects: MediaWiki-extensions-WikibaseClient, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION If the WikibaseClient setting `repoDatabase` isn't false, but referring to the local wiki's database by name, the client phpunit tests

[Wikidata-bugs] [Maniphest] [Commented On] T210598: Add data value type to Special:ListDatatypes

2019-04-15 Thread hoo
hoo added a comment. Maybe we want something like: translated type name (`typeName`) (that way I hope it's clear that `typeName` is the technical term?) TASK DETAIL https://phabricator.wikimedia.org/T210598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T220883: Wikidata JSON dumps should include Lexemes

2019-04-15 Thread hoo
hoo added a comment. As we don't want to inflate the current JSON dumps even more, we will not add Lexemes to them. What we will do is add a new JSON dump covering just Lexemes. TASK DETAIL https://phabricator.wikimedia.org/T220883 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T144103: Create .nt (NTriples) dumps for wikidata data

2019-04-15 Thread hoo
hoo closed subtask T154914: Add .nt to DCAT-AP for Wikidata dumps as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T144103 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, hoo Cc: gerritbot, Lydia_Pintscher, thalhamm, Hydriz

[Wikidata-bugs] [Maniphest] [Closed] T154914: Add .nt to DCAT-AP for Wikidata dumps

2019-04-15 Thread hoo
hoo closed this task as "Resolved". hoo removed a project: Patch-For-Review. hoo added a comment. In T154914#5110672 <https://phabricator.wikimedia.org/T154914#5110672>, @ArielGlenn wrote: > @hoo what's left to be done here? AFAICT this is fully done \o/ :)

[Wikidata-bugs] [Maniphest] [Claimed] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-11 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T220122 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T195226: Precision issues with diff-within-range constraint in Wikidata

2019-04-10 Thread hoo
hoo added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T195226 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Lucas_Werkmeister_WMDE, abian, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T218378: Flaky test Wikibase\Repo SetAliasesTest::testUserCannotSetAliasesWhenTheyLackPermission [4h]

2019-04-10 Thread hoo
hoo added a comment. This problem occurs because `SetAliasesTest` uses two `User` instances referring to the same user with different configurations (`$this->createUserWithGroup( 'no-permission' )` and `$this->createUserWithGroup( 'all-permission' )` which both act on th

[Wikidata-bugs] [Maniphest] [Commented On] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo added a comment. Seems I had this quiet wrong initially… no idea what I tested then. Anyway this is only affecting Lua, not the parser function and we don't ever output `` (just ``). We might still want to fix this in the way laid out in the description, but we could also use

[Wikidata-bugs] [Maniphest] [Edited] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T220122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, hoo, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Edited] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T220122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, hoo, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Updated] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo added a comment. @Lucas_Werkmeister_WMDE `useKartographerMaplinkInWikitext` needs to be false (I had this wrong in the initial description)… and I also messed this up in production while fixing T218051: Raw code displayed in an infobox template when mapframe is not enabled on that wiki

[Wikidata-bugs] [Maniphest] [Edited] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T220122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, hoo, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Claimed] T218378: Flaky test Wikibase\Repo SetAliasesTest::testUserCannotSetAliasesWhenTheyLackPermission [4h]

2019-04-10 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T218378 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T220122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, hoo, Liuxinyu970226, Tpt,

[Wikidata-bugs] [Maniphest] [Edited] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-10 Thread hoo
hoo updated the task description. hoo removed the point value for this task. TASK DETAIL https://phabricator.wikimedia.org/T220122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, hoo

[Wikidata-bugs] [Maniphest] [Updated] T210926: Display mapframe for geocoordinate statements on client

2019-04-04 Thread hoo
hoo added a comment. > There is a small bug that may affect some Lua modules: calls `mw.wikibase.entity:formatStatements().value` using Lua may need to be passed to frame:preprocess to be properly display the table. I have already fixed Module:Databox that was affected. The s

[Wikidata-bugs] [Maniphest] [Created] T220122: Displaying mapframes for geocoordinate on client requires preprocessing by the user

2019-04-04 Thread hoo
hoo created this task. hoo added projects: Wikidata, Wikibase-Lua, MediaWiki-extensions-WikibaseClient. Restricted Application added subscribers: Liuxinyu970226, Aklapper. TASK DESCRIPTION As pointed out by @Tpt in T210926#4999461 <https://phabricator.wikimedia.org/T210926#4999

[Wikidata-bugs] [Maniphest] [Commented On] T44325: Prevent creation of items having the same sitelinks (duplicates)

2019-04-04 Thread hoo
hoo added a comment. In T44325#412 <https://phabricator.wikimedia.org/T44325#412>, @Addshore wrote: > @hoo did we ever get a result from that script run? I forgot about this… most of this seems to still be unresolved, so I put it up on https://www.wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T219979: Improve Extension:WikibaseSchema documentation

2019-04-04 Thread hoo
hoo added a comment. I like this :) IMO it would be nicer to instruct users to not run composer in the extension dir (would that even work? I'm not sure MW would pick up a Diff installation in the extensions vendor dir), but in the main MediaWiki dir (via composer merge plugin). I've

[Wikidata-bugs] [Maniphest] [Reassigned] T219173: Prevent Schema edits with no changes

2019-04-04 Thread hoo
hoo reassigned this task from hoo to Lucas_Werkmeister_WMDE. hoo added a comment. Yay for Phabricator not telling me about the conflicts… TASK DETAIL https://phabricator.wikimedia.org/T219173 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Claimed] T219173: Prevent Schema edits with no changes

2019-04-04 Thread hoo
hoo claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T219173 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, pdehaye, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo

[Wikidata-bugs] [Maniphest] [Changed Project Column] T218895: Migrate “edit schema label/description/aliases” summaries to FormatAutocomments-based system

2019-04-03 Thread hoo
hoo moved this task from Peer Review to Verification on the Shape Expressions Sprint 5 board. hoo added a comment. Done AFAICT https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseSchema/+/500720 TASK DETAIL https://phabricator.wikimedia.org/T218895 WORKBOARD https

[Wikidata-bugs] [Maniphest] [Created] T219980: Disable "move" and "create" protection for Schemas

2019-04-03 Thread hoo
hoo created this task. hoo added projects: Shape Expressions Sprint 5, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Schemas can't be moved and it's not possible to create a Schema with a user supplied title (numeric IDs are assigned as page titles), thus

[Wikidata-bugs] [Maniphest] [Claimed] T216835: track number of Schemas

2019-04-02 Thread hoo
hoo claimed this task. hoo edited projects, added Shape Expressions Sprint 5; removed Shape Expressions. TASK DETAIL https://phabricator.wikimedia.org/T216835 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Lydia_Pintscher, pdehaye

[Wikidata-bugs] [Maniphest] [Closed] T219699: Convert property Guggenheim fellows ID (P6594) from string to identifier

2019-04-01 Thread hoo
hoo closed this task as "Resolved". hoo claimed this task. hoo added a comment. hoo@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/changePropertyDataType.php --wiki wikidatawiki --new-data-type external-id --property-id P6594 Successfully updated the property

[Wikidata-bugs] [Maniphest] [Commented On] T219313: Prevent moving Schema pages

2019-03-27 Thread hoo
hoo added a comment. Moving back to backlog (per the open question in T219313#5061925 <https://phabricator.wikimedia.org/T219313#5061925>). TASK DETAIL https://phabricator.wikimedia.org/T219313 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Claimed] T218894: Migrate “edit schema text” summaries to FormatAutocomments-based system

2019-03-26 Thread hoo
hoo claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T218894 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Lucas_Werkmeister_WMDE, pdehaye, alaa_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Unassigned] T214887: [Story] edit summaries for Schemas

2019-03-25 Thread hoo
hoo moved this task from Peer Review to Verification on the Shape Expressions Sprint 5 board. hoo removed hoo as the assignee of this task. hoo added a comment. Moving this to verification… done for now, the rest is T218893 <https://phabricator.wikimedia.org/T218893> and follow-ups.

[Wikidata-bugs] [Maniphest] [Commented On] T214887: [Story] edit summaries for Schemas

2019-03-25 Thread hoo
hoo added a comment. Shall we also do this for the special page in the "Message way" or don't we care? TASK DETAIL https://phabricator.wikimedia.org/T214887 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T218867: Validate length limits for Schema inputs in the front-end

2019-03-22 Thread hoo
hoo added a comment. Turns out I forgot Special:NewSchema… will do next. TASK DETAIL https://phabricator.wikimedia.org/T218867 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, pdehaye

[Wikidata-bugs] [Maniphest] [Changed Project Column] T218867: Validate length limits for Schema inputs in the front-end

2019-03-21 Thread hoo
hoo moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board. hoo added a comment. Patch is up for Special:SetSchemaLabelDescriptionAliases, but editing schema text (action=edit) still missing. TASK DETAIL https://phabricator.wikimedia.org/T218867 WORKBOARD

[Wikidata-bugs] [Maniphest] [Commented On] T218867: Validate length limits for Schema inputs in the front-end

2019-03-21 Thread hoo
hoo added a comment. We can use https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.widgets-method-visibleCodePointLimit for this! TASK DETAIL https://phabricator.wikimedia.org/T218867 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Claimed] T218867: Validate length limits for Schema inputs in the front-end

2019-03-21 Thread hoo
hoo claimed this task. hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board. hoo added a comment. I think there's a mw lib for this, will investigate. TASK DETAIL https://phabricator.wikimedia.org/T218867 WORKBOARD https://phabricator.wikimedia.org/project

[Wikidata-bugs] [Maniphest] [Commented On] T217331: [Story] Add link to Schema page to check against list of entities

2019-03-15 Thread hoo
hoo added a comment. target=_blank? to be decided rel=noopener probably @Lydia_Pintscher Do we want to do this? TASK DETAIL https://phabricator.wikimedia.org/T217331 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Changed Project Column] T216144: View schemas in multiple languages

2019-03-14 Thread hoo
hoo moved this task from Peer Review to Verification on the Shape Expressions Sprint 4 board. hoo removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T216144 WORKBOARD https://phabricator.wikimedia.org/project/board/3954/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T215759: Schema heading

2019-03-13 Thread hoo
hoo moved this task from Peer Review to Doing on the Shape Expressions Sprint 4 board. hoo added a comment. Move back to doing, as per @Lucas_Werkmeister_WMDE's comment. TASK DETAIL https://phabricator.wikimedia.org/T215759 WORKBOARD https://phabricator.wikimedia.org/project/board/3954

[Wikidata-bugs] [Maniphest] [Changed Project Column] T217331: [Story] Add link to Schema page to check against list of entities

2019-03-12 Thread hoo
hoo moved this task from Peer Review to Doing on the Shape Expressions Sprint 4 board. hoo added a comment. Nothing to review right now (https://gerrit.wikimedia.org/r/495889 needs its follow up to be properly judged). TASK DETAIL https://phabricator.wikimedia.org/T217331 WORKBOARD

[Wikidata-bugs] [Maniphest] [Updated] T216145: Edit schemas in multiple languages

2019-03-12 Thread hoo
hoo moved this task from Peer Review to Doing on the Shape Expressions Sprint 4 board. hoo removed a project: Patch-For-Review. hoo added a comment. Moving this back to Doing as this seems to not be done yet (also the full scope is somewhat unclear). TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T217314: Support subpage syntax

2019-03-11 Thread hoo
hoo moved this task from Peer Review to Doing on the Shape Expressions Sprint 4 board. hoo added a comment. - `Special:SetSchemaLabelDescriptionAliases/O1/en` skips the first form and shows directly the second form for English This is working already (although languages other

[Wikidata-bugs] [Maniphest] [Updated] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-03-11 Thread hoo
hoo added a comment. In T215393#5014627 <https://phabricator.wikimedia.org/T215393#5014627>, @Lydia_Pintscher wrote: > Looking good and the link leads to the special page. For some reason the special page doesn't keep the schema ID though and I need to fill it in again.

[Wikidata-bugs] [Maniphest] [Changed Project Column] T216144: View schemas in multiple languages

2019-03-10 Thread hoo
hoo moved this task from Peer Review to Doing on the Shape Expressions Sprint 3 board. hoo added a comment. @Lucas_Werkmeister_WMDE Is this fully done? TASK DETAIL https://phabricator.wikimedia.org/T216144 WORKBOARD https://phabricator.wikimedia.org/project/board/3909/ EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T216270: Update property suggester data

2019-03-08 Thread hoo
hoo added a comment. @Lucas_Werkmeister_WMDE Yes, please see https://gist.github.com/mariushoch/22f4ead44f75c5133e403f465bc279a5. TASK DETAIL https://phabricator.wikimedia.org/T216270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc

[Wikidata-bugs] [Maniphest] [Updated] T217409: Rename schema, schema content, schema code etc. to schema text

2019-03-07 Thread hoo
hoo removed a project: Patch-For-Review. hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T217409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, hoo Cc: gerritbot, Michael, Aklapper

[Wikidata-bugs] [Maniphest] [Changed Project Column] T217314: Support subpage syntax

2019-03-07 Thread hoo
hoo moved this task from Peer Review to Doing on the Shape Expressions Sprint 3 board. hoo added a comment. Moving back to "Doing" as all changes appear to be WIP. TASK DETAIL https://phabricator.wikimedia.org/T217314 WORKBOARD https://phabricator.wikimedia.org/project/

[Wikidata-bugs] [Maniphest] [Closed] T217749: Uncaught exception from Special:SetSchemaLabelDescriptionAliases if aliases are duplicated

2019-03-06 Thread hoo
hoo removed a project: Patch-For-Review. hoo moved this task from Peer Review to Done on the Shape Expressions Sprint 3 board. hoo closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T217749 WORKBOARD https://phabricator.wikimedia.org/project/board/39

[Wikidata-bugs] [Maniphest] [Closed] T217634: Check that aliases for Schema are unique before saving

2019-03-05 Thread hoo
hoo removed a project: Patch-For-Review. hoo moved this task from Peer Review to Done on the Shape Expressions Sprint 3 board. hoo closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T217634 WORKBOARD https://phabricator.wikimedia.org/project/board/39

[Wikidata-bugs] [Maniphest] [Claimed] T215393: Add edit links for “identifying information” section and “ShExC” section

2019-03-01 Thread hoo
hoo claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T215393 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Addshore, gerritbot, Lydia_Pintscher, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, pdehaye, Michael, CucyNoiD, Nandana

[Wikidata-bugs] [Maniphest] [Claimed] T214887: [Story] edit summaries for Schemas

2019-02-25 Thread hoo
hoo claimed this task. hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 3 board. TASK DETAIL https://phabricator.wikimedia.org/T214887 WORKBOARD https://phabricator.wikimedia.org/project/board/3909/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Unassigned] T214396: Display diffs between Schema versions

2019-02-13 Thread hoo
hoo removed hoo as the assignee of this task.hoo moved this task from Doing to Backlog on the Shape Expressions Sprint 2 board. TASK DETAILhttps://phabricator.wikimedia.org/T214396WORKBOARDhttps://phabricator.wikimedia.org/project/board/3872/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Claimed] T214396: Display diffs between Schema versions

2019-02-06 Thread hoo
hoo claimed this task.hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 1 board. TASK DETAILhttps://phabricator.wikimedia.org/T214396WORKBOARDhttps://phabricator.wikimedia.org/project/board/3833/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T97126: [Task] Investigate label prefetching for entities referred to (solely) in revision comments

2019-02-06 Thread hoo
hoo added a comment. In T97126#4902048, @Addshore wrote: @hoo, do we still want to do this? I'm not sure how important this… but loading terms seems to take a significant amount of the time when loading RecentChanges.TASK DETAILhttps://phabricator.wikimedia.org/T97126EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Edited] T214576: Add tests for not being able to edit Schemas

2019-01-29 Thread hoo
hoo updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - [ - [x] [actually implement this restriction](https://gerrit.wikimedia.org/r/487030)  - [ - [x] [test it](https://gerrit.wikimedia.org/r/487031) - [ ] the page is protected and the user does not have

[Wikidata-bugs] [Maniphest] [Edited] T214576: Add tests for not being able to edit Schemas

2019-01-29 Thread hoo
hoo updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [the user is blocked from this page](https://gerrit.wikimedia.org/r/486471) - [ - [x] the user does not have `'edit'` rights...TASK DETAILhttps://phabricator.wikimedia.org/T214576EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Edited] T214399: Revert to previous version of a shape expression

2019-01-29 Thread hoo
hoo updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONA user should be able to revert to the previous version of a shape _expression_...TASK DETAILhttps://phabricator.wikimedia.org/T214399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T129040: [Bug] Wikibase/Installation instructions fail due to T99459 change

2019-01-23 Thread hoo
hoo added a comment. In T129040#4765078, @Addshore wrote: @hoo as your face is on the first ticket, did you look into this at all in the past 2 years? No, but this shouldn't be a problem with freshly created InnoDB tables anymore (The index key prefix length limit is 3072 bytes for InnoDB

[Wikidata-bugs] [Maniphest] [Commented On] T92281: [Task] Browsertests for link-item widget on Wikidata-Clients

2019-01-23 Thread hoo
hoo added a comment. In T92281#4902077, @Addshore wrote: We had an UBN relating to this in the past few weeks Do you have a link?TASK DETAILhttps://phabricator.wikimedia.org/T92281EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Addshore, hoo, WMDE

[Wikidata-bugs] [Maniphest] [Retitled] T114471: [Task] Don't use the (deprecated) SiteSQLStore, but MediaWikiServices::getSite(Lookup|Store)

2019-01-23 Thread hoo
hoo renamed this task from "[Task] Introduce a convenient alternative to the (deprecated) SiteSQLStore and make use of it" to "[Task] Don't use the (deprecated) SiteSQLStore, but MediaWikiServices::getSite(Lookup|Store)".hoo updated the task description. (Show Details) CHANGES

[Wikidata-bugs] [Maniphest] [Block] T76705: SiteStore / SiteList performance and caching (tracking)

2019-01-23 Thread hoo
hoo reopened subtask T114471: [Task] Introduce a convenient alternative to the (deprecated) SiteSQLStore and make use of it as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T76705EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, hooCc

[Wikidata-bugs] [Maniphest] [Reopened] T114471: [Task] Introduce a convenient alternative to the (deprecated) SiteSQLStore and make use of it

2019-01-23 Thread hoo
hoo reopened this task as "Open".hoo added a comment. In T114471#4901935, @Addshore wrote: We decided to close this one as invalid as the thing doesn't appear to be deprecated? Well, on master SiteSQLStore::newInstance (the only function in SiteSQLStore) says @deprecated sinc

[Wikidata-bugs] [Maniphest] [Claimed] T205216: Buggy message when trying to merge a non-existent Lexeme via Special:MergeLexemes

2019-01-22 Thread hoo
hoo claimed this task.hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.hoo added a comment. The message on Special:MergeItems is actually just "Item not found. ", the more elaborate message ("The ID "Q13453453535"

[Wikidata-bugs] [Maniphest] [Commented On] T151789: Wikibase\\TermSqlIndex::deleteTerms: Deadlock found when trying to get lock; try restarting transaction

2019-01-14 Thread hoo
hoo added a comment. Still happening (very occasionally): $ zgrep -c 'TermSqlIndex::deleteTerms' archive/exception.log-201901* archive/exception.log-20190101.gz:0 archive/exception.log-20190102.gz:0 archive/exception.log-20190103.gz:2 archive/exception.log-20190104.gz:0 archive/exception.log

[Wikidata-bugs] [Maniphest] [Commented On] T205045: Exception from LinksUpdate: Deadlock found in database query (from Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages)

2019-01-14 Thread hoo
hoo added a comment. Maybe EntityUsageTable::INSERT_BATCH_SIZE_FACTOR should be changed from 5 to 3/2.5/2?TASK DETAILhttps://phabricator.wikimedia.org/T205045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: hoo, Addshore, Marostegui, Aklapper, Krinkle

[Wikidata-bugs] [Maniphest] [Commented On] T154914: Add .nt to DCAT-AP for Wikidata dumps

2019-01-11 Thread hoo
hoo added a comment. I merged the patch and will deploy it probably in the next days… but without a configuration change, this is a no-op for now.TASK DETAILhttps://phabricator.wikimedia.org/T154914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_Profil

[Wikidata-bugs] [Maniphest] [Changed Project Column] T212210: Make query service logo and favicon configurable

2019-01-11 Thread hoo
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.hoo added a comment. Done with https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/483780/1 and https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/483781/1, I

[Wikidata-bugs] [Maniphest] [Commented On] T189506: Evaluate usages of mw.wikibase.getEntity

2019-01-09 Thread hoo
hoo added a comment. In T189506#4858317, @Lydia_Pintscher wrote: @hoo are you still working on this? Should it move to camp? No, I'm not actively tackling this… I don't this is overly urgent now, but this might bit us sometime later.TASK DETAILhttps://phabricator.wikimedia.org/T189506EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T212561: basic SpecialPage for creating a new Schema

2019-01-03 Thread hoo
hoo added a comment. So this is just about registering a dummy special page (which is not yet able to actually create a schema)?!TASK DETAILhttps://phabricator.wikimedia.org/T212561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: hoo, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T184933: Display map for geocoordinate statements

2018-12-13 Thread hoo
hoo added a comment. In T184933#4819706, @Lea_Lacroix_WMDE wrote: @hoo Another question was also raised: is it possible to adapt the scale of the map (=zoom level) depending on what it is about? (see discussion here) I looked at this briefly and it would be hard to integrate with how the maps

[Wikidata-bugs] [Maniphest] [Commented On] T204531: Wikidata dumps creating large amounts of log spam

2018-12-13 Thread hoo
hoo added a comment. In T204531#4813322, @hoo wrote: I just revisited the original logs… and I found that the way way way more common error back then was from LoadBalancer::getRandomNonLagged: 2018-09-19 07:13:27 [1d74bb1b0e64917ec3cd47e7] snapshot1008 wikidatawiki 1.32.0-wmf.20 DBReplication

[Wikidata-bugs] [Maniphest] [Updated] T207850: Consolidate the log groups used within Wikibase & Wikibase extensions.

2018-12-13 Thread hoo
hoo removed a project: Patch-For-Review.hoo added a comment. $ grep -rnF 'wfLogWarning(' Wikibase WikibaseLexeme/ WikibaseQualityConstraints/ | wc -l 41 $ grep -rnF 'wfWarn(' Wikibase WikibaseLexeme/ WikibaseQualityConstraints/ | wc -l 22 Do we care about them in this context? wfLogWarning

[Wikidata-bugs] [Maniphest] [Commented On] T191416: track usage of Wikibase Lua functions

2018-12-13 Thread hoo
hoo added a comment. This is scheduled to be enabled on Dec 20 after the train (probably around 19:00–20:00 UTC).TASK DETAILhttps://phabricator.wikimedia.org/T191416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Changed Project Column] T191416: track usage of Wikibase Lua functions

2018-12-12 Thread hoo
hoo moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.hoo removed a project: Patch-For-Review.hoo added a comment. Still needs to be enabled via mediawiki-configuration.TASK DETAILhttps://phabricator.wikimedia.org/T191416WORKBOARDhttps

[Wikidata-bugs] [Maniphest] [Commented On] T191416: track usage of Wikibase Lua functions

2018-12-12 Thread hoo
hoo added a comment. I suggest to enable this tracking per group for all groups (wikipedia, wikiquote, …) and for the following wikis specifically: commonswiki ruwiki ukwiki arwiki zhwiki cawiki frwiki enwiki svwiki itwiki These are the top 10 wikis by number of entity usage (per https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T184933: Display map for geocoordinate statements

2018-12-12 Thread hoo
hoo moved this task from Needs Announcement to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.hoo removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T184933WORKBOARDhttps://phabricator.wikimedia.org/project/board/3539/EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T206535: wikidata weekly dumps take too long to complete

2018-12-12 Thread hoo
hoo added a comment. This looks very good. I just checked and even the latest PHP still uses the "zlib compatibility functions" which had troubles with chunked bzip2s before (see T118379) (it uses them for both the compress.bzip2 stream wrapper and for bzopen). Given this now works (wh

[Wikidata-bugs] [Maniphest] [Updated] T184933: Display map for geocoordinate statements

2018-12-11 Thread hoo
hoo added a comment. In T184933#4812900, @TheDJ wrote: Fancy... Just a followup/enhancement idea: since we have precision.. wouldn't this be a good place to draw a precision circle ? This is a very good point: Basically we can alter the generated mapframes like in any article… in fact we

[Wikidata-bugs] [Maniphest] [Edited] T211676: Inline Kartographer mapframes: Take precision into account

2018-12-11 Thread hoo
hoo updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Currently these are being generated by just creating a `GeoJSON` point from the value (in `CachingKartographerEmbeddingHandler::getWikiText`): `"geometry": { "type": "Point", "coor

[Wikidata-bugs] [Maniphest] [Created] T211676: Inline Kartographer mapframes: Take precision into account

2018-12-11 Thread hoo
hoo created this task.hoo added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONAfter T184933: Display map for geocoordinate statements we now have small inline maps which are obtained using Kartographer mapframes

[Wikidata-bugs] [Maniphest] [Commented On] T204531: Wikidata dumps creating large amounts of log spam

2018-12-11 Thread hoo
hoo added a comment. I just revisited the original logs… and I found that the way way way more common error back then was from LoadBalancer::getRandomNonLagged: 2018-09-19 07:22:32 [c36272088a424bcc438a31e9] snapshot1008 wikidatawiki 1.32.0-wmf.20 DBReplication ERROR: Server db1109 has

[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-12-11 Thread hoo
hoo added a comment. Given the lock timeouts happen on SELECT, I don't really see how using a single query instead of SELECT+UPDATE/INSERT would greatly help us here. While that's definitely nice to have performance wise (less queries, less roundtrips), the main problem seems to me that something

[Wikidata-bugs] [Maniphest] [Updated] T211469: Inconsistent query results for recently created items on query service

2018-12-08 Thread hoo
hoo added a comment. Maybe duplicate/ overlapping with T210044: Data corruption when loading RDF data into WDQS?TASK DETAILhttps://phabricator.wikimedia.org/T211469EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: hoo, Aklapper, Smalyshev

[Wikidata-bugs] [Maniphest] [Commented On] T204531: Wikidata dumps creating large amounts of log spam

2018-12-07 Thread hoo
hoo added a comment. Anything that depends on a particular db server makes me uneasy Hm… above I meant that for every DB server it should ever warn ever (like) LAG_WARN_THRESHOLD / 2 seconds… for all DB servers… it makes little sense to let a single LoadMonitor instance create more log entries

[Wikidata-bugs] [Maniphest] [Commented On] T204531: Wikidata dumps creating large amounts of log spam

2018-12-07 Thread hoo
hoo added a comment. Or we could alter LoadMonitor::getServerStates to not log for a certain db-server more than every N seconds (where N could be derived from LAG_WARN_THRESHOLD, which currently is 10s).TASK DETAILhttps://phabricator.wikimedia.org/T204531EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T204531: Wikidata dumps creating large amounts of log spam

2018-12-07 Thread hoo
hoo added a comment. I just looked into this some more… We could also create a new LB settings key which would be passed as lagWarnThreshold to LoadMonitor (currently this options is never set, as their is no way to do so, thus this always defaults to LoadMonitor::LAG_WARN_THRESHOLD (10s

<    1   2   3   4   5   6   7   8   9   10   >