[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

gerritbot added a comment. Change 268811 merged by jenkins-bot: Temporarily skip a test that fails on HHVM. https://gerrit.wikimedia.org/r/268811 TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

gerritbot added a comment. Change 268811 had a related patch set uploaded (by Paladox): Temporarily skip a test that fails on HHVM. https://gerrit.wikimedia.org/r/268811 TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

gerritbot added a comment. Change 268473 merged by jenkins-bot: Temporarily skip a test that fails on HHVM. https://gerrit.wikimedia.org/r/268473 TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

gerritbot added a comment. Change 268473 had a related patch set uploaded (by Mattflaschen): Temporarily skip a test that fails on HHVM. https://gerrit.wikimedia.org/r/268473 TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

gerritbot added a comment. Change 252508 merged by jenkins-bot: Temporarily skip a test that fails on HHVM. https://gerrit.wikimedia.org/r/252508 TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

daniel added a subscriber: daniel. daniel added a comment. What's the actual problem here? Are our tests failing, because input that shouldn't be accepted is accepted? Or what? Do we actually need to fail on a trailing comma? Is it part of our contract to perform strict validation on json

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

daniel added a comment. If the relevant input isn't actually harmful, I'd suggest to relax the tests. Sure, hhvm should be fixed, and there's a ticket for that. But *we* shouldn't block on hhvm getting fixed. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

JanZerebecki added a comment. Our tests fail correctly because hhvm accepts input that is invalid json that it should not accept. Suggested action: Fix hhvm. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

JanZerebecki added a comment. This tests the json functions we implement Lua, so yes need to perform strict validation, as we specified our Lua json_decode function that way. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

Anomie added a comment. In https://phabricator.wikimedia.org/T103346#1625120, @daniel wrote: > Are our tests failing, because input that shouldn't be accepted is accepted? Yes. For example, `[1,]` is not valid JSON (it's not allowed in either RFC 7159 or

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

daniel added a comment. A compromise would be to mark the relevant test as skipped until this issue is fixed in hhvm. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, Anomie,

[Wikidata-bugs] [Maniphest] [Commented On] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)

Anomie added a subscriber: Anomie. Anomie added a comment. Bug in HHVM: the json-c library used by hhvm accepts input that's not actually valid json by default, and HHVM doesn't pass the override flag or even expose it to PHP code. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL