[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a comment. Change 227634 had a related patch set uploaded (by Aude): On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/227634 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a comment. Change 227634 merged by jenkins-bot: On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/227634 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a comment. Change 227632 had a related patch set uploaded (by Aude): On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/227632 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a comment. Change 222463 merged by Aude: On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/222463 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a comment. Change 227632 merged by Aude: On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/227632 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a comment. Change 222463 had a related patch set uploaded (by Aude): On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/222463 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 222463 had a related patch set uploaded (by Daniel Kinzler): On page views, update usage tracking via the job queue. https://gerrit.wikimedia.org/r/222463 TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

daniel added a comment. The patch above makes the update always go via the job queue. Not sure whether that is the Right Thing. TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

hoo added a comment. Also would my original idea work if the client setting `allowDataAccessInUserLanguage` is set to false? If so, that //might// be worth special casing (that would work for the `ParserCacheSaveComplete` hook which is more important here, at least). TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

daniel added a comment. @hoo: we need to update usage tracking whenever a new target language is //viewed// after a page was //touched//. Relying on the modified date sadly doesn't work, because it's not set when the update is triggered via the job queue (learned that the hard way). TASK

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

hoo added a subscriber: hoo. hoo added a comment. I think we should only do that if the data is not there before... that only happens once per page after the initial entity usage deploy. To achieve that we should compare the `MAX( eu_touched )` (from slave) with the touched timestamp we get

[Wikidata-bugs] [Maniphest] [Commented On] T103429: Investigation: Parser save hook handler does master writes in GETs

Tobi_WMDE_SW added a subscriber: Tobi_WMDE_SW. Tobi_WMDE_SW added a comment. We are going to look into that and see how bad this is. TASK DETAIL https://phabricator.wikimedia.org/T103429 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW