[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

gerritbot added a comment. Change 228785 abandoned by Jdlrobson: WikidataPageBanner add open-source srcset polyfill Reason: Due to lack of activity. https://gerrit.wikimedia.org/r/228785TASK DETAILhttps://phabricator.wikimedia.org/T106523EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. Brion have added you to the patch. I've also moved this to the `freezer` column since it's not a huge priority right now in my opinion as we get closer to launch. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

brion added a comment. But yeah that code'll have to run on both. Feel free to ping me for review etc TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brion Cc: brion, gerritbot, Jdlrobson,

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

brion added a comment. If http://caniuse.com/#feat=srcset is to be believed, the main problem browser on mobile is going to be Safari on iOS 8, since it supports native srcset but only for density switching, not for the size specifications. So if you use a customized polyfill, you can't rely

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. This is desktop AND mobile so the impact is a little greater.. :-/ TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: brion, gerritbot, Jdlrobson, Sumit,

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. Thanks @brion for the quick response! You read correctly. Right now we're using srcset attribute to serve the best sized banner depending on the user's current browser window. The plan is to point the src attribute to the lowest res image but we're keen to use a

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

brion added a comment. Well, desktop isn't as big a worry since high-res screen usually means large screen (and you'll usually max out at 2, rather than the 3 that some phones like the iPhone 6plus reach)... :) So it should be safe there to load the 1x and then polyfill-load the

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

brion added a comment. So if I'm reading the above comments correctly, these banners want to use the width capping specifications ('w640') in img srcset, but Safari and our JS polyfill only support switching on the device pixel ratio ('2x'). I suppose you might be able to rig up a fancier

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Sumit added a comment. @Jdlrobson, testing the above patch is difficult for me as all the browsers support srcset, can you test it on the emulator which reported a problem in the task above? TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 228785 had a related patch set uploaded (by Sumit): WikidataPageBanner implement srcset polyfill https://gerrit.wikimedia.org/r/228785 TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Sumit added a comment. Sample of 640px banner F278957: banner640.png https://phabricator.wikimedia.org/F278957 Sample of 1280px banner F278961: banner1280.png https://phabricator.wikimedia.org/F278961 A 640px banner still gives a bad impression on a large screen. Given that full-width banners

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. It might be worth exploring a srcset polyfill for browsers that do not support it. This way with JS you will always see the best possible image. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. (Note, 640px width should be enough for most browsers...) TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson, Sumit, Aklapper, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Sumit added a comment. If I use javascript to adjust banner when srcset is not supported, we risk blurry banners in javascript disabled case. Going ahead with the current scenario, we preserve whatever is the status-quo regarding responsive banners, i.e, largest banner when no srcset. I think

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. One of the motivations however was to provide a better experience for mobile browsers - currently they are needlessly downloading huge images for all browsers except Chrome... :-( I think a middle-res banner would be a good compromise here. What do you think? TASK

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Sumit added a comment. Yes, agreed, I'll take the middle path of adding a 640px size banner and then manipulating accordingly. TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T106523: Issues with srcset with browsers that do not properly support it

Jdlrobson added a comment. I think it is best we talk about this tomorrow in our meeting (I may be misunderstanding something) TASK DETAIL https://phabricator.wikimedia.org/T106523 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: