gerritbot added a comment.
Change 231886 merged by jenkins-bot:
WikidataPageBanner add max-width
https://gerrit.wikimedia.org/r/231886
TASK DETAIL
https://phabricator.wikimedia.org/T108986
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 231886 had a related patch set uploaded (by Sumit):
WikidataPageBanner add max-wdith
https://gerrit.wikimedia.org/r/231886
TASK DETAIL
https://phabricator.wikimedia.org/T108986
EMAIL PREFERENCES
Jdlrobson added a comment.
You could add an inline style surely and do this css only?
style=max-width:max widthpx;
TASK DETAIL
https://phabricator.wikimedia.org/T108986
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson
Cc: Sumit, Aklapper,
Sumit added a subscriber: Sumit.
Sumit added a comment.
It would not be possible to determine max-width of image in css. Should a js
approach be used after setting a data-max-width attribute in html of banner
image?
TASK DETAIL
https://phabricator.wikimedia.org/T108986
EMAIL PREFERENCES
