gerritbot added a comment.
Change 232195 merged by jenkins-bot:
WikidataPageBanner improve qunit test
https://gerrit.wikimedia.org/r/232195
TASK DETAIL
https://phabricator.wikimedia.org/T109319
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Sumit added a subscriber: Sumit.
Sumit added a comment.
The qunit tests for origin were added in
https://gerrit.wikimedia.org/r/#/c/230050/ , are some other tests also needed?
TASK DETAIL
https://phabricator.wikimedia.org/T109319
EMAIL PREFERENCES
Jdlrobson added a comment.
Whoops!
Looks like I missed those in code review :-s
I'll add some comments on the tests. If you could address the points I think we
are good :)
TASK DETAIL
https://phabricator.wikimedia.org/T109319
EMAIL PREFERENCES
gerritbot added a comment.
Change 232195 had a related patch set uploaded (by Sumit):
WikidataPageBanner improve qunit test
https://gerrit.wikimedia.org/r/232195
TASK DETAIL
https://phabricator.wikimedia.org/T109319
EMAIL PREFERENCES
