daniel added a comment.
I merged the pull request that adds isEmpty to EntityDocument
TASK DETAIL
https://phabricator.wikimedia.org/T110177
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: daniel
Cc: JanZerebecki, daniel, JeroenDeDauw, thiemowmde,
thiemowmde added a comment.
- `clear` should just die. If you need a new entity, create a new one. Never
ever repurpose an existing one to be something else.
- `copy` can be and is useful, but I'm not sure if it needs to be in an
interface. Having it in the implementations is fine in my
Bene added a comment.
Proposed patch on github: https://github.com/wmde/WikibaseDataModel/pull/547
TASK DETAIL
https://phabricator.wikimedia.org/T110177
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Bene
Cc: JanZerebecki, daniel, JeroenDeDauw,
Bene added a comment.
I think it makes sense at least for isEmpty to add it to the interface. copy
may not be in the interface, but should still be available in the
implementations (Item, Property). clear is used only once in the api in
wbeditentity, where one can set clear=true to clear the
