[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix negative argument (ArgumentError) in browsertests

hashar added a comment. We attempted to debug it on the Jenkins slave itself but could not find why the source_indent would end up yelling -2 :-( TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix negative argument (ArgumentError) in browsertests

hashar added a comment. $ irb irb(main):001:0> p "x" * 2 "xx" => "xx" irb(main):002:0> p "x" * -2 ArgumentError: negative argument from (irb):2:in `*' from (irb):2 from /usr/local/bin/irb:11:in `' irb(main):003:0> TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix negative argument (ArgumentError) in browsertests

hashar added a comment. Looking at the indent method: p re p indent_string p amount p indent_string * amount 08:47:59 And I enter "MODIFIED LABEL" as label # features/step_definitions/label_steps.rb:20 08:47:59 /^(?!$)/ 08:47:59 " " 08:47:59 -2 08:47:59

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. I have created a new job, browsertests-Wikidata-SmokeTests-linux-firefox-sauce-T111069 , copied from browsertests-Wikidata-SmokeTests-linux-firefox-sauce

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. Unlike https://phabricator.wikimedia.org/T111069, I can not reproduce this one locally. TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: zeljkofilipin Cc: hashar,

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. When I switched Cucumber to another formatter (progress), the job does not fail: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-SmokeTests-linux-firefox-sauce-T111069/5/console 00:00:04.661 ... bundle exec cucumber --format progress

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. I have created a new job (using JJB) browsertests-Wikidata-T110510-linux-firefox-sauce , using browsertests-Wikidata-SmokeTests-linux-firefox-sauce as a template. The

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. Strange, the error message says the problem is in Cucumber's default (pretty) formatter. 00:00:04.450 ... bundle exec cucumber features/label.feature:49 ... 00:00:19.206 Scenario: | press the RETURN key in the label input field |

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. Ideas: - update Cucumber and dependencies - make sure to run the same Ruby version on my machine and Jenkins TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. I have tried running the same Ruby version on my machine and Jenkins. Jenkins runs ruby 1.9.3p484: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-SmokeTests-linux-firefox-sauce-T110510/9/consoleFull ... 16:08:41 + ruby -v 16:08:41 ruby

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. This problem is introduced by T106839: move browsertests-Wikidata-WikidataTests-linux-chrome-sauce to jjb . TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

hashar added a comment. Maybe you can regenerate the job entirely and see what happens? Make sure your JJB is the current version from integration/jenkins-job-builder. TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

hashar added a subscriber: hashar. hashar added a comment. Since JJB and Jenkins generated configurations are different, if you want to compare the current JJB version you can configure the job, save it and Jenkins will renormalize it to its internal format. That then let you a diff between

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

JanZerebecki added a comment. I reverted to the old config, triggered a run and reverted to the jjb generated one again: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-chrome-sauce/133/console TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

JanZerebecki added a comment. Diff that made the crome job also fail: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-chrome-sauce/jobConfigHistory/showDiffFiles?timestamp1=2015-05-15_12-18-07=2015-08-26_09-42-21 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

zeljkofilipin added a comment. The actual job diff: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-WikidataTests-linux-chrome-sauce/jobConfigHistory/showDiffFiles?timestamp1=2015-05-15_12-18-07=2015-09-01_14-09-36 TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T110510: fix `negative argument (ArgumentError) in browsertests

JanZerebecki added a comment. There is an earlier error message in the log: no implicit conversion of String into Integer (TypeError) TASK DETAIL https://phabricator.wikimedia.org/T110510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: