Jdlrobson added a comment.
Yeh if it is in Common.js delete it from Vector and mobile as otherwise it will
run twice (bad! ) :)
It will take time to see the results.
Essentially all the code does is this:
check if the toc is 1
if it is purge the cache.
TASK DETAIL
Jdlrobson added a comment.
No `1` should be generated as of Wednesday. I'm still not exactly sure how this
started happening but the bug was in the code from the day it was deployed and
seems to impact older pages.
TASK DETAIL
https://phabricator.wikimedia.org/T117050
EMAIL PREFERENCES
Jdlrobson added a comment.
my thinking was mobile traffic was less so less traffic would hit purge urls
but actually on second thought Common.js would probably make more sense but be
sure to remove it if you notice any slowdown on the site and as soon as the
problem goes away (I'm not yet sure
Jdlrobson added a comment.
Sorry about this :( It should be fixed now (see discussion in other bug) but we
have no way to clear cache. It might be possible to ask operations to purge
html but I suspect that might be too costly an operation...
TASK DETAIL
Jdlrobson added a comment.
Actually I had an idea...
Add this code to MediaWiki:Mobile.js and it will purge existing pages when the
problem is encountered (e.g. crowd source purging the cache where needed)
if ($( '.wpb-banner-toc' ).text() === '1' ) { $.post( mw.util.getUrl(
mw.config.get(
Atsirlin added a comment.
Now I have it in Mobile.js and Vector.js. Should be enough, while adding the
same line to Common.js will be redundant, right?
I have edited the template right now and also earlier this morning, but as far
as I can see this did not help.
TASK DETAIL
Atsirlin added a comment.
It looks like we have got this problem after the update. When exactly did it
happen?
TASK DETAIL
https://phabricator.wikimedia.org/T117050
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Atsirlin
Cc: Sumit, Jdlrobson,
Atsirlin added a comment.
added to Mobile.js, but why Mobile.js? We are talking about desktop version.
Should it be added to Common.js as well?
TASK DETAIL
https://phabricator.wikimedia.org/T117050
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Atsirlin added a comment.
@Jdlrobson: thanks for your support! At first glance, the problem has been
resolved, although we still have to see how it develops after the patches in
Vector.js and Mobile.js are removed
TASK DETAIL
https://phabricator.wikimedia.org/T117050
EMAIL PREFERENCES
