[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2016-05-18 Thread Jan_Dittrich
Jan_Dittrich added a comment. If we deem this as important (or just interesting) we could make this part of a small, informal usability test – we could ask in-house, since I assume not everyone is familiar with data entry behavior in wikidata. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2016-05-12 Thread Jan_Dittrich
Jan_Dittrich added a comment. Thiemo asked me about my UX view on that issue. In general, the single-escape = out (Thiemos suggestion) makes sense, but I can not judge how much people may rely on that and got used to it. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2016-05-12 Thread gerritbot
gerritbot added a comment. Change 288391 had a related patch set uploaded (by Jonas Kress (WMDE)): Introduce step "I Close the entity selector if present" https://gerrit.wikimedia.org/r/288391 TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2016-05-11 Thread gerritbot
gerritbot added a comment. Change 288209 merged by jenkins-bot: Fix: Property suggester leads to test fail https://gerrit.wikimedia.org/r/288209 TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2016-05-11 Thread Jonas
Jonas added a comment. Browsertests are failing, because when property suggester is present entity selector opens directly when entering edit mode. There is no race condition whatsoever... TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2016-05-11 Thread gerritbot
gerritbot added a comment. Change 288209 had a related patch set uploaded (by Jonas Kress (WMDE)): Fix: Property suggester leads to test fail https://gerrit.wikimedia.org/r/288209 TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2015-11-09 Thread Tobi_WMDE_SW
Tobi_WMDE_SW added a comment. @lydia_pintscher I've updated the task description according to @janzerebecki's comment. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2015-11-08 Thread Lydia_Pintscher
Lydia_Pintscher added a subscriber: Lydia_Pintscher. Lydia_Pintscher added a comment. Please be more specific in writing these tasks. Is this about a behavior change of the existing UI? Is this about testing something as the blocker seems to indicate? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2015-11-08 Thread JanZerebecki
JanZerebecki added a comment. This is about changing the exiting UI. Currently there is a race conditions in the UI for editing an item value in a statement. After typing but before the PropertySuggester shows its item suggestions, ESC cancels the edit. If the PropertySuggester shows, ESC only

[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode

2015-11-08 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Ok thanks. This really isn't clear from the initial description. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher,