[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-04-03 Thread daniel
daniel added a comment. Wooot! /me does a happy dance TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Smalyshev, adrianheine, Bene, gerritbot, JanZerebecki, daniel, AndyRussG, Sp

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-04-03 Thread gerritbot
gerritbot added a comment. Change 264403 merged by jenkins-bot: Introduce top level service locator. https://gerrit.wikimedia.org/r/264403 TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-04-02 Thread daniel
daniel added a comment. Session notes from today's hackathon session: - performance-sensitive hooks may want to cache/singletonize the instance created from global state - Example: MappingConfigHookHandler - SL pattern as a stepping stone towards DI. -> Recipe for converting a cl

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-04-02 Thread daniel
daniel added a comment. Etherpad for hackathon session on DI: https://etherpad.wikimedia.org/p/wmhack2016_DI TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Smalyshev, adrianheine,

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-03-24 Thread daniel
daniel added a comment. Summary of the IRC meeting held about this RFC on March 23: - Acreement that declarative wiring is not a good idea (SMalyshev) - The functionality of Pimple seems to be covered (Matt, Roan) - Extensions can add wiring files via extension.json (Daniel) - Overri

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-03-19 Thread adrianheine
adrianheine added a comment. Is there a convention for the service names? Is it the interface implemented? What about when you possibly need multiple, different implementations of the same interface? TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabric

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-03-18 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T124792#2135463, @adrianheine wrote: > Is there a convention for the service names? Is it the interface implemented? What about when you possibly need multiple, different implementations of the same interface? I followe

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core

2016-03-18 Thread daniel
daniel added a comment. In https://phabricator.wikimedia.org/T124792#1968417, @RobLa-WMF wrote: > Thanks for the clarification, @daniel! Should we try spinning up a software engineering working group (per https://phabricator.wikimedia.org/T119032 and https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core.

2016-01-26 Thread daniel
daniel added a comment. Not to ArchCom: I consider this RFC "under discussion", with a focus on code review. I don't see a need for an IRC meeting at this time. TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpre

[Wikidata-bugs] [Maniphest] [Commented On] T124792: RFC: Service Locator for MediaWiki core.

2016-01-26 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 264403 had a related patch set uploaded (by Daniel Kinzler): Introduce top level service locator. https://gerrit.wikimedia.org/r/264403 TASK DETAIL https://phabricator.wikimedia.org/T124792 EMAIL PREFERENCES https:/