[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 271753 abandoned by Thiemo Mättig (WMDE): Never shorten page titles in sitelinks below 15 characters Reason: I4a26042 is merged, code does not exist any more. https://gerrit.wikimedia.org/r/271753 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 272475 abandoned by Thiemo Mättig (WMDE): Use binary search in sitelinkview._shortenPageName Reason: I4a26042 is merged, code does not exist any more. https://gerrit.wikimedia.org/r/272475 TASK DETAIL https://phabricator.wikimedia.org/T127067

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 272625 merged by jenkins-bot: Make long site links wrap nicely https://gerrit.wikimedia.org/r/272625 TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

thiemowmde added a comment. I linked https://phabricator.wikimedia.org/T124786 so it doesn't get lost so easily, but I agree we can and should close this here for now. TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

Jonas added a comment. Firefox: F3426661: pasted_file TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Incabell, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

Jonas added a comment. @thiemowmde F3426644: pasted_file TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Incabell, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

Incabell added a comment. I agree with @Lydia_Pintscher TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Incabell Cc: Incabell, Lydia_Pintscher, gerritbot, Aklapper, Jonas, thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 272625 had a related patch set uploaded (by Adrian Heine): Make long site links wrap nicely https://gerrit.wikimedia.org/r/272625 TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

adrianheine added a comment. Current patch revision does good things: In chromium, it breaks on whitespace where possible, long words just randomly. In Firefox, it adds hyphens. Reviewers, please check in your browsers. TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

Lydia_Pintscher added a comment. Option one and three are clearnly no-gos. Let's go with 2. TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Incabell, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

adrianheine added a comment. Long words are an issue. I see three straight-forward workarounds. @Lydia_Pintscher @Incabell Limit leakage to length of site id: F3405816: Screenshot from 2016-02-23 12-27-51.png Break words wherever

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

adrianheine added a comment. Two versions of site id positioning: F3404155: Screenshot from 2016-02-23 10-51-18.png F3404156: Screenshot from 2016-02-23 10-51-53.png TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 272625 had a related patch set uploaded (by Adrian Heine): Make long site links wrap nicely https://gerrit.wikimedia.org/r/272625 TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 272475 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Use binary search in sitelinkview._shortenPageName https://gerrit.wikimedia.org/r/272475 TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

gerritbot added a comment. Change 271753 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Never shorten page titles in sitelinks below 15 characters https://gerrit.wikimedia.org/r/271753 TASK DETAIL https://phabricator.wikimedia.org/T127067 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T127067: [Story] Reduce initialisation time of SiteLinks

thiemowmde added a comment. We found that the `_shortenPageName` function in `sitelinkview.js` is one of the most time consuming details on the page now. For testing, here is one of the longest page titles on the live site: https://www.wikidata.org/wiki/Q229568 TASK DETAIL