gerritbot added a comment.
Change 295311 merged by jenkins-bot:
Remove old mobile workaround for wikidata descriptions
https://gerrit.wikimedia.org/r/295311TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 295311 had a related patch set uploaded (by Jhobs):
Remove old mobile workaround for wikidata descriptions
https://gerrit.wikimedia.org/r/295311TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
jhobs added a comment.
Thanks @phuedx!TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobsCc: Stashbot, gerritbot, Dbrant, Oliv0, Jhernandez, bmansurov, phuedx, Lydia_Pintscher, Moushira, dr0ptp4kt,
phuedx added a comment.
Ping @jhobs, @dr0ptp4kt ^TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs, phuedxCc: Stashbot, gerritbot, Dbrant, Oliv0, Jhernandez, bmansurov, phuedx, Lydia_Pintscher, Moushira,
gerritbot added a comment.
Change 295012 merged by jenkins-bot:
Enable wikibase descriptions for beta, even if disabled for production
https://gerrit.wikimedia.org/r/295012TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
gerritbot added a comment.
Change 295012 had a related patch set uploaded (by Jhobs):
Enable wikibase descriptions for beta, even if disabled for production
https://gerrit.wikimedia.org/r/295012TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
dr0ptp4kt added a comment.
@Jhernandez, I'll file the Task for the SWAT.
@jhobs is going to fix the conditional logic via this task to make it complete.TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs,
Jhernandez added a comment.
@dr0ptp4kt do we have follow-up tasks for:
A follow-up deployment will happen on Monday to disable this by default on production
and
Some additional code on top of the existing MASTER is also needed to add logic to ensure beta will generally retain Wikidata
dr0ptp4kt added a comment.
Okay, @bmansurov and @jhobs and I spoke this afternoon. As noted in the patch:
* Note: A follow-up deployment will happen on Monday to disable
* this by default on production. It is not included in
* this patch in order to minimize the time in prod-beta
*
Stashbot added a comment.
Mentioned in SAL [2016-06-16T23:07:40Z] Synchronized wmf-config/InitialiseSettings-labs.php: T127250: Prepare Wikidata descriptions on mobile for production rollout (duration: 00m 27s)TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
gerritbot added a comment.
Change 293883 merged by jenkins-bot:
Prepare Wikidata descriptions on mobile for production rollout
https://gerrit.wikimedia.org/r/293883TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
phuedx added a comment.
Test how cached pages appear and post a screenshot on the card.
F4172739: Screen Shot 2016-06-16 at 21.25.02.png
TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs, phuedxCc:
jhobs added a comment.
Check that, it's happening tonight. Thanks @dr0ptp4kt!TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobsCc: gerritbot, Dbrant, Oliv0, Jhernandez, bmansurov, phuedx, Lydia_Pintscher,
jhobs added a comment.
@bmansurov thanks. I'll talk with you guys at standup to see when a good time to schedule it is.
Can someone else upload the cached page screenshot? I was finally able to get the dev script working with the help of Baha, but I can't view the page within Mediawiki for some
bmansurov added a comment.
@jhobs I think your config file is ready to be SWAT deployed.TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs, bmansurovCc: gerritbot, Dbrant, Oliv0, Jhernandez, bmansurov,
gerritbot added a comment.
Change 293882 merged by jenkins-bot:
Prepare Wikidata descriptions for rollout to stable
https://gerrit.wikimedia.org/r/293882TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
phuedx added a comment.
In T127250#2382872, @jhobs wrote:
Yeah, I understood that. The tmp folder in my extension directory is empty.
Weird. This worked perfectly for me.TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
jhobs added a comment.
In T127250#2381323, @bmansurov wrote:
@jhobs /tmp/cached.html is relative to the MF extension directory, not the system dir. Mybad.
Yeah, I understood that. The tmp folder in my extension directory is empty.TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
bmansurov added a comment.@jhobs /tmp/cached.html is relative to the MF extension directory, not the system dir. Mybad.TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs, bmansurovCc: gerritbot, Dbrant,
jhobs added a comment.
In T127250#2376700, @bmansurov wrote:
You can test how your patch affects the cached pages by following these steps:
./dev-scripts/cachedpage.sh 6d588b23ddab1a2cb1514d97018a8213063153ad San_Francisco <- The command fetches the San Francisco article for the commit
jhobs added a comment.
In T127250#2375363, @bmansurov wrote:
@jhobs can you also do the last bullet point?
Of course, just ran out of time last week and wanted to get it in code review. If I'm not mistaken though, won't we need to SWAT deploy the labs patch first? If not, I may be
bmansurov added a comment.@jhobs can you also do the last bullet point?TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhobs, bmansurovCc: gerritbot, Dbrant, Oliv0, Jhernandez, bmansurov, phuedx,
gerritbot added a comment.Change 293883 had a related patch set uploaded (by Jhobs):
Prepare Wikidata descriptions on mobile for production rollout
https://gerrit.wikimedia.org/r/293883TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
gerritbot added a comment.Change 293882 had a related patch set uploaded (by Jhobs):
Prepare Wikidata descriptions for rollout to stable
https://gerrit.wikimedia.org/r/293882TASK DETAILhttps://phabricator.wikimedia.org/T127250EMAIL
24 matches
Mail list logo