gerritbot added a comment.
Change 274792 merged by jenkins-bot:
Add a config override for siteGroup
https://gerrit.wikimedia.org/r/274792
TASK DETAIL
https://phabricator.wikimedia.org/T128779
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
daniel added a comment.
In https://phabricator.wikimedia.org/T128779#2088436, @JanZerebecki wrote:
> No job know to me fails because of this notice. Please change and add a
link if you know of one.
@Krinkle can you explain again why this is blocking you?
TASK DETAIL
gerritbot added a comment.
Change 274792 had a related patch set uploaded (by Daniel Kinzler):
Provide config ovberrides for Jenkins
https://gerrit.wikimedia.org/r/274792
TASK DETAIL
https://phabricator.wikimedia.org/T128779
EMAIL PREFERENCES
daniel added a comment.
Oh duh!
From WikibaseClient.example.php:
// NOTE: If this wiki also runs the Wikibase repo extension,
// stop and just use the defaults for settings.
if ( defined( 'WB_VERSION' ) ) {
return;
}
TASK DETAIL
daniel added a comment.
So apparently, the mwext-mw-selenium-composer job doesn't hit the die() in
WikibaseClient.example.php, even though the branch that should include the
example settings does get hit. What the hell?
See https://gerrit.wikimedia.org/r/#/c/274792/4
TASK DETAIL
daniel added a comment.
Verified that the top level entry point (Wikibase.php) goes into the branch
that has
require_once __DIR__ . '/client/ExampleSettings.php';
see https://gerrit.wikimedia.org/r/#/c/274792/3
TASK DETAIL
https://phabricator.wikimedia.org/T128779
EMAIL
daniel added a comment.
Verified that the top level entry point (Wikibase.php) gets loaded by putting
die() at the top of the file: https://gerrit.wikimedia.org/r/#/c/274792/2
TASK DETAIL
https://phabricator.wikimedia.org/T128779
EMAIL PREFERENCES
daniel added a comment.
I tried adding the group in https://gerrit.wikimedia.org/r/#/c/274792/ with
no effect. It seems like example settings are not loaded by the
mwext-mw-selenium-composer job.
TASK DETAIL
https://phabricator.wikimedia.org/T128779
EMAIL PREFERENCES
