[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-28 Thread gerritbot
gerritbot added a comment. Change 340135 merged by jenkins-bot: Remove unused code from TermView components and tests https://gerrit.wikimedia.org/r/340135TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-27 Thread gerritbot
gerritbot added a comment. Change 337849 merged by jenkins-bot: Fix TermView components assuming all entities have labels/descriptions https://gerrit.wikimedia.org/r/337849TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-27 Thread gerritbot
gerritbot added a comment. Change 340135 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove unused code from TermView components and tests https://gerrit.wikimedia.org/r/340135TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-26 Thread gerritbot
gerritbot added a comment. Change 339912 merged by jenkins-bot: Remove Fingerprint from the backend https://gerrit.wikimedia.org/r/339912TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde,

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-26 Thread thiemowmde
thiemowmde added a comment. I just checked again (as I already did dozens of times in the pasts months) and found that the biggest remaining issues are: https://gerrit.wikimedia.org/r/337849 not merged after almost 2 weeks. EntityRetrievingTermLookup still binds against FingerprintProvider

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-15 Thread gerritbot
gerritbot added a comment. Change 337849 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Fix TermView components assuming all entities have labels/descriptions https://gerrit.wikimedia.org/r/337849TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-13 Thread gerritbot
gerritbot added a comment. Change 335617 merged by jenkins-bot: Simplify TermValidatorFactoryTest setup to not use Fingerprint https://gerrit.wikimedia.org/r/335617TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-10 Thread gerritbot
gerritbot added a comment. Change 335615 merged by jenkins-bot: Remove Fingerprint interface from label & description ChangeOps https://gerrit.wikimedia.org/r/335615TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-09 Thread gerritbot
gerritbot added a comment. Change 335614 merged by jenkins-bot: Remove Fingerprint from FingerprintValidator interface https://gerrit.wikimedia.org/r/335614TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-09 Thread gerritbot
gerritbot added a comment. Change 335464 merged by jenkins-bot: Replace unused CompositeFingerprintValidator with null implementation https://gerrit.wikimedia.org/r/335464TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-09 Thread gerritbot
gerritbot added a comment. Change 335463 merged by jenkins-bot: Remove unused interface from LabelUniquenessValidator https://gerrit.wikimedia.org/r/335463TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-02 Thread gerritbot
gerritbot added a comment. Change 335617 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Simplify TermValidatorFactoryTest setup to not use Fingerprint https://gerrit.wikimedia.org/r/335617TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335615 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove Fingerprint interface from label & description ChangeOps https://gerrit.wikimedia.org/r/335615TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335614 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove Fingerprint from FingerprintValidator interface https://gerrit.wikimedia.org/r/335614TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335464 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Replace unused CompositeFingerprintValidator with null implementation https://gerrit.wikimedia.org/r/335464TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2017-02-01 Thread gerritbot
gerritbot added a comment. Change 335463 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove unused interface from LabelUniquenessValidator https://gerrit.wikimedia.org/r/335463TASK DETAILhttps://phabricator.wikimedia.org/T134735EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-30 Thread gerritbot
gerritbot added a comment. Change 290461 merged by jenkins-bot: Make terms table compatible with MediaInfo https://gerrit.wikimedia.org/r/290461 TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-27 Thread gerritbot
gerritbot added a comment. Change 290900 merged by jenkins-bot: Runtime optimizations and more narrow interfaces in TermSqlIndex https://gerrit.wikimedia.org/r/290900 TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-26 Thread gerritbot
gerritbot added a comment. Change 290900 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Runtime optimizations and more narrow interfaces in TermSqlIndex https://gerrit.wikimedia.org/r/290900 TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-24 Thread gerritbot
gerritbot added a comment. Change 290461 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Make terms table compatible with MediaInfo https://gerrit.wikimedia.org/r/290461 TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-18 Thread gerritbot
gerritbot added a comment. Change 287580 merged by jenkins-bot: Make use of Label/DescriptionProvider interfaces in history/search https://gerrit.wikimedia.org/r/287580 TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-11 Thread Addshore
Addshore added a comment. In https://phabricator.wikimedia.org/T134735#2275304, @adrianheine wrote: > Can you create a subtask for each change you're doing on this thing? I'd call this tracking, not task, too. I imagine there are maaany places to touch for this :O TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-09 Thread adrianheine
adrianheine added a comment. Can you create a subtask for each change you're doing on this thing? I'd call this tracking, not task, too. TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T134735: [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases

2016-05-09 Thread gerritbot
gerritbot added a comment. Change 287580 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Make use of Label/DescriptionProvider interfaces in history/search https://gerrit.wikimedia.org/r/287580 TASK DETAIL https://phabricator.wikimedia.org/T134735 EMAIL PREFERENCES