gerritbot added a comment.
Change 306163 merged by Gehel:
WDQS caching headers
https://gerrit.wikimedia.org/r/306163TASK DETAILhttps://phabricator.wikimedia.org/T137238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev,
Gehel added a comment.
@Smalyshev yes there is: adding some cache-control headers. Change submitted. Thanks for reminding me!TASK DETAILhttps://phabricator.wikimedia.org/T137238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: gerritbot, Smalyshev,
gerritbot added a comment.
Change 306163 had a related patch set uploaded (by Gehel):
WDQS caching headers
https://gerrit.wikimedia.org/r/306163TASK DETAILhttps://phabricator.wikimedia.org/T137238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc:
Smalyshev added a comment.
@Gehel is anything left to do in this ticket?TASK DETAILhttps://phabricator.wikimedia.org/T137238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Smalyshev, Aklapper, Zppix, Jonas, Gehel, BBlack, mschwarzer,
gerritbot added a comment.Change 293492 merged by Gehel:
Don't publish etags for WDQS
https://gerrit.wikimedia.org/r/293492TASK DETAILhttps://phabricator.wikimedia.org/T137238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Smalyshev,
Smalyshev added a comment.
main page (index.html) -> no cache (or very short)
I would cache it for the same as below. It doesn't change that much - pretty much once a week now. While re-fetching it is no big deal, I think we still can cache it for like 5 mins.
everything under /css and /js ->
Jonas added a comment.
In T137238#2368243, @Gehel wrote:
We shoudl be able to also process at least:
vendor/jquery.uls/css/jquery.uls.css
This is fixed.
main page (index.html) -> no cache (or very short)
everything under /css and /js -> long cache (7 days to start ?)
everything else ->
Gehel added a comment.We shoudl be able to also process at least:
vendor/jquery.uls/css/jquery.uls.css
logo.svg
They are unlikely to change frequently but still it would be nice...
At this point I'm not entirely sure which resources can be cached and which cannot. My guess:
main page
Jonas added a comment.We can only use filerev for files that are referenced from the html file, because the application itself is not aware about filerev and then will not find its resources.
The json files are for i18n, so there will be no problem when they are outdated.TASK
gerritbot added a comment.Change 293492 had a related patch set uploaded (by Gehel):
Don't publish etags for WDQS
https://gerrit.wikimedia.org/r/293492TASK DETAILhttps://phabricator.wikimedia.org/T137238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Gehel added a comment.It seems that at the moment only .js and .css files which ar in the js / css directories are processed by filerev. Is there any reason to not process other files as well? It seems that we have .json files that could benefit from the same processing.TASK
Smalyshev added a comment.
Yes, after the switch to built GUI we can cache at least the hashed CSS/JS
pretty much forever, they'd never change. Non-hashed ones probably fine with
time like 1 day or so, we change them about once a week. If we want to have
different rules, it may require some
12 matches
Mail list logo
