Dzahn added a comment.
Patch needs to be amended to reflect the latest comments?TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: Dzahn, akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel,
akosiaris added a comment.
I support that as well. The code in wdqs::updater should probably anyway be amended to use base::service_unit at some point, at which point the question of whether puppet should also manage a service resource will probably be posed. We would at least be ready from that
Smalyshev added a comment.
I'm fine with that.TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, Lewizho99, Maathavan,
Gehel added a comment.
Some discussion with Stas to clarify the need:
We do not declare a service in puppet, so puppet will not restart that service. This is on purpose, as we don't want updater to start before the initial import is done. This might be improved at some point.
As in this case,
Smalyshev added a comment.
Maybe I misunderstand what mask/unmask does, but I though it disables service completely. That's not what I need. What I need is to either make it start on boot automatically (when data is loaded) or not start on boot (when data is not loaded). Isn't that what
gerritbot added a comment.
Change 295968 had a related patch set uploaded (by Smalyshev):
Allow wdqs admins to control wdqs-updater service
https://gerrit.wikimedia.org/r/295968TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL
