[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2017-01-04 Thread gerritbot
gerritbot added a comment. Change 315694 merged by jenkins-bot: Remove hard-coded supportedEntityTypesForEntitiesWithoutTermListings default https://gerrit.wikimedia.org/r/315694TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2017-01-04 Thread gerritbot
gerritbot added a comment. Change 314555 merged by jenkins-bot: Introduce the "supportedEntityTypesForEntitiesWithoutTermListings" setting https://gerrit.wikimedia.org/r/314555TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-12-19 Thread gerritbot
gerritbot added a comment. Change 314554 merged by jenkins-bot: New SqlEntitiesWithoutTermFinder implementation https://gerrit.wikimedia.org/r/314554TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo,

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-18 Thread hoo
hoo added a comment. @thiemowmde: The essential part is that we need to be able to do this in SQL, not (only) in PHP.TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: thiemowmde, Izno, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-18 Thread thiemowmde
thiemowmde added a comment. we can only provide this functionality for entity types where we know how to programmatically construct the entity id serialization from the entity-type and the numeric entity id. We do know this for all entity types that provide an entity-id-composer, see

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-18 Thread hoo
hoo added a comment. Just to re-explain this, because I think it might not have been clear enough before: Currently we join the wb_entity_per_page table against the wb_terms table (term_entity_id = epp_entity_id AND term_entity_type = epp_entity_type). After this change, we will join the page

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-13 Thread gerritbot
gerritbot added a comment. Change 315694 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove hard-coded supportedEntityTypesForEntitiesWithoutTermListings default https://gerrit.wikimedia.org/r/315694TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-06 Thread gerritbot
gerritbot added a comment. Change 314554 had a related patch set uploaded (by Hoo man): New SqlEntitiesWithoutTermFinder implementation https://gerrit.wikimedia.org/r/314554TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-06 Thread gerritbot
gerritbot added a comment. Change 314555 had a related patch set uploaded (by Hoo man): Introduce the "entitiesWithoutTermEntityTypes" setting https://gerrit.wikimedia.org/r/314555TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-05 Thread gerritbot
gerritbot added a comment. Change 314182 merged by jenkins-bot: Move EntitiesWithoutTermFinder::getEntitiesWithoutTerm https://gerrit.wikimedia.org/r/314182TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-10-04 Thread gerritbot
gerritbot added a comment. Change 314182 had a related patch set uploaded (by Hoo man): Move EntitiesWithoutTermFinder::getEntitiesWithoutTerm https://gerrit.wikimedia.org/r/314182TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-08-31 Thread gerritbot
gerritbot added a comment. Change 305496 merged by jenkins-bot: Split the EntityPerPage interface https://gerrit.wikimedia.org/r/305496TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Izno,

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-08-18 Thread gerritbot
gerritbot added a comment. Change 305496 had a related patch set uploaded (by Hoo man): Split the EntityPerPage interface https://gerrit.wikimedia.org/r/305496TASK DETAILhttps://phabricator.wikimedia.org/T140891EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-07-20 Thread Izno
Izno added a comment. In T140891#2479890, @Lydia_Pintscher wrote: I just discussed with Daniel if we actually need Special:EntitiesWithoutDescription and Special:EntitiesWithoutLabel They lost their usefulness mostly as Wikidata grew. If you want to find items without a label in a given language

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-07-20 Thread daniel
daniel added a comment. @hoo What drives the restriction is our desire to drop the wb_entity_per_page table. Does terminator need that table? Cab it maintain its own copy? The idea behind restricting to Properties is: Without wb_entity_per_page, joining against the wb_terms table is inefficient.

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-07-20 Thread hoo
hoo added a comment. In T140891#2479890, @Lydia_Pintscher wrote: I just discussed with Daniel if we actually need Special:EntitiesWithoutDescription and Special:EntitiesWithoutLabel They lost their usefulness mostly as Wikidata grew. If you want to find items without a label in a given language

[Wikidata-bugs] [Maniphest] [Commented On] T140891: Factor EntityPerPage::getEntitiesWithoutTerm out into it's own service

2016-07-20 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. I just discussed with Daniel if we actually need Special:EntitiesWithoutDescription and Special:EntitiesWithoutLabel They lost their usefulness mostly as Wikidata grew. If you want to find items without a label in a given language the resultset is in most cases too