gerritbot added a comment.
Change 307538 merged by Smalyshev:
Merging from 98cec07b87e7699dd33cbfd43b3f0416a5ab954a:
https://gerrit.wikimedia.org/r/307538TASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 307473 merged by jenkins-bot:
Display data updated message as single message.
https://gerrit.wikimedia.org/r/307473TASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 307473 had a related patch set uploaded (by Smalyshev):
Display data updated message as single message.
https://gerrit.wikimedia.org/r/307473TASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL
Oriciu added a comment.
The issue here is that for Asturian, Spanish and other languages we need the string for $time to come after the string for $ago to get a correct sentence.
Regards.TASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL
Smalyshev added a comment.
I have no objection to making it single messageTASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Jonas, Amire80, Aklapper, Avner, debt, Gehel, D3r1ck01,
Jonas added a comment.
There should be only one message instead of two.
Something like "Data updated $1 ago"
The $1 is updated frequently and on mouse over.TASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Amire80 added a comment.
It's possible that I misunderstand the purpose of the string, but that's something that the qqq should make clear :)TASK DETAILhttps://phabricator.wikimedia.org/T143005EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Amire80Cc:
