hoo added a comment.
Note: Until T192462 is resolved, I wont add this to Extension:Wikibase Client/Lua.TASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, Tom.Reding, Ahecht, Uzume, Anomie,
Ahecht added a comment.
mw.wikibase.entityExists('Q404') returns falseTASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, AhechtCc: gerritbot, Tom.Reding, Ahecht, Uzume, Anomie, hoo, Lucie, aude, daniel,
Uzume added a comment.
Does entityExists properly handle redirects (e.g., merged entities) and if so how do we get the entity ID we are redirected to?
For example, what does mw.wikibase.entityExists(Q404) yield? and how do I find out that refers to Q395?
ThanksTASK
gerritbot added a comment.
Change 423260 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce mw.wikibase.entityExists
https://gerrit.wikimedia.org/r/423260TASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL
gerritbot added a comment.
Change 423259 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce mw.wikibase.isValidEntityId
https://gerrit.wikimedia.org/r/423259TASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL
gerritbot added a comment.
Change 423260 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Introduce mw.wikibase.hasEntity
https://gerrit.wikimedia.org/r/423260TASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL
gerritbot added a comment.
Change 423259 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Introduce mw.wikibase.isValidEntityId
https://gerrit.wikimedia.org/r/423259TASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL
hoo added a comment.
In T143970#2586090, @Anomie wrote:
In order for the error to be caught by pcall, you need to throw a Scribunto_LuaError rather than a ScribuntoException.
Good point, we might also want to do this… but if someone specifically wants to test whether an id is valid, going with
Anomie added a comment.
In order for the error to be caught by pcall, you need to throw a Scribunto_LuaError rather than a ScribuntoException.TASK DETAILhttps://phabricator.wikimedia.org/T143970EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Anomie,
