Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-10-10T18:23:22Z] Synchronized php-1.28.0-wmf.21/includes/Linker.php: Do not normalise external links to special pages (T147685) (duration: 01m 07s)TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-10-10T18:22:09Z] scap aborted: file php-1.28.0-wmf.21/includes/Linker.php Do not normalise external links to special pages (T147685) (duration: 00m 03s)TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-10-10T18:22:06Z] Started scap: file php-1.28.0-wmf.21/includes/Linker.php Do not normalise external links to special pages (T147685)TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
gerritbot added a comment.
Change 315142 merged by jenkins-bot:
Do not normalise external links to special pages
https://gerrit.wikimedia.org/r/315142TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 315142 had a related patch set uploaded (by Ladsgroup):
Do not normalise external links to special pages
https://gerrit.wikimedia.org/r/315142TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
Ladsgroup added a comment.
It's fixed in beta cluster: https://wikidata.beta.wmflabs.org/w/index.php?title=Q2268="">TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, Aklapper, daniel,
gerritbot added a comment.
Change 314840 abandoned by Ladsgroup:
Use main ns instead of special for external links in action="" in repo
Reason:
Since the upstream fix got merged I0ec004b3f7194696eaca9541d336b061602e36df
It's not needed anymore
https://gerrit.wikimedia.org/r/314840TASK
gerritbot added a comment.
Change 314841 had a related patch set uploaded (by Ladsgroup):
Do not normalise external links to special pages
https://gerrit.wikimedia.org/r/314841TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
gerritbot added a comment.
Change 314840 had a related patch set uploaded (by Ladsgroup):
Use main ns instead of special for external links in action="" in repo
https://gerrit.wikimedia.org/r/314840TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
Ladsgroup added a comment.
There is a bug in normalizeTarget in LinkeRenderer when the title is a special page. Obviously that's an upstream bug but I can bypass that by using main ns title instead of special ns one.TASK DETAILhttps://phabricator.wikimedia.org/T147685EMAIL
Ladsgroup added a comment.
I ran this on terbium. It's obvious why it's broken:
ladsgroup@terbium:~$ mwscript eval.php --wiki=wikidatawiki
> $mediaWikiServices = \MediaWiki\MediaWikiServices::getInstance();
> $siteLookup = $mediaWikiServices->getSiteLookup();
> $linkRender =
11 matches
Mail list logo