[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Addshore added a comment. So, although not particularly clear on the https://www.mediawiki.org/wiki/Wikibase/DataModel/JSON page, this is the JSON data model definition for items and properties. And the stable interface policy on wikidata only currently applies to wikidata. >

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. In T149410#5285579 , @Magnus wrote: > In T149410#5284363 , @Jdforrester-WMF wrote: > > > In T149410#5284327

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Ramsey-WMF added a comment. The SDC team will follow the recommendations/decisions of the original authors (WMDE). We do believe, as Addshore mentioned above, that there's a strong possibility that the Commons model will end up not using references in the way that Wikidata does. We'll

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Jdforrester-WMF added a comment. In T149410#5285579 , @Magnus wrote: > In T149410#5284363 , @Jdforrester-WMF wrote: > > > As established above, when Wikimedia DE wrote WBMI in early

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Esc3300 added a comment. To avoid that people confuse claims and statements in general, maybe the feature should use an entirely different name. TASK DETAIL https://phabricator.wikimedia.org/T149410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Magnus added a comment. In T149410#5284363 , @Jdforrester-WMF wrote: > In T149410#5284327 , @Multichill wrote: > > > Changed back the topic. This is a huge scope change and

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Jdforrester-WMF added a comment. In T149410#5284327 , @Multichill wrote: > Changed back the topic. This is a huge scope change and derailing things. As far as I see everywhere in the api we use "claims", not "statements" (also in the

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. Changed back the topic. This is a huge scope change and derailing things. As far as I see everywhere in the api we use "claims", not "statements" (also in the functions). The only inconsistency right now is mediainfo, that should be fixed. If you want to change

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Addshore added a comment. This is partly a question for the SDOC team, and if SDOC will ever have references as part of their data model. Then there is also the question for wikidata and wikibase, which is, why are we using "claims" in the serialization? The answer to the latter is

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. In T149410#5275912 , @Addshore wrote: > > Drastically? We're talking Commons here. Before I ran a bot only 50.000 files even had claims. Nothing has references and qualifiers are only introduced this week.

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Addshore added a comment. > Drastically? We're talking Commons here. Before I ran a bot only 50.000 files even had claims. Nothing has references and qualifiers are only introduced this week. Everything is still tiny compared to Wikidata I'm talking about changing this from "claims" to

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. In T149410#5275900 , @Addshore wrote: > In T149410#5275599 , @Multichill wrote: > > > Can't we do a smart trick with showing it twice (claims and

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Lydia_Pintscher added a comment. Jep absolutely. TASK DETAIL https://phabricator.wikimedia.org/T149410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Bene, Lucas_Werkmeister_WMDE, Ramsey-WMF, Keegan, Multichill, Magnus,

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Magnus added a comment. FWIW, I have already changed my code to work with either `claims` or `statements`. Quick thoughts: - IMHO this change is too significant to do it "just because it's a nicer word". No one really cares what it's called, as long as you call it the same thing every

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Lydia_Pintscher added a comment. In T149410#5275156 , @Addshore wrote: > > Magnus ran into this and this is very confusing and inconsistent. The longer we wait with fixing this, the more effort it will cost. > > Totally agree there,

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. Can't we do a smart trick with showing it twice (claims and statements) in the front and storing it only once in the back? A big bang is much more complicated and riskier. You would have a timeline like: - Switch api read and write functions to expose both

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Addshore added a comment. > Magnus ran into this and this is very confusing and inconsistent. The longer we wait with fixing this, the more effort it will cost. Totally agree there, we have already put this off for years. It's a pretty breaking change though. But with the correct

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. https://commons.wikimedia.org/wiki/File:Wikidata_statement.svg might be useful for the relation between a claim and a statement. TASK DETAIL https://phabricator.wikimedia.org/T149410 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Multichill added a comment. Magnus ran into this and this is very confusing and inconsistent. The longer we wait with fixing this, the more effort it will cost. Example https://commons.wikimedia.org/w/api.php?action=wbgetentities=M27401711 uses "statements" as the key, but we expect

[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

Addshore added a comment. This is in MediaInfoSerializer::getSerialized $serialization['statements'] = $this->statementListSerializer->serialize( $mediaInfo->getStatements() ); This is already now going to cause an issue as we now have entities in the commons DB including serialization