[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-29 Thread gerritbot
gerritbot added a comment. Change 323404 merged by jenkins-bot: Integrate ForeignEntityValidator with ValidatorBuilders. https://gerrit.wikimedia.org/r/323404TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-28 Thread gerritbot
gerritbot added a comment. Change 322093 merged by jenkins-bot: Add ForeignEntityValidator. https://gerrit.wikimedia.org/r/322093TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc:

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-24 Thread gerritbot
gerritbot added a comment. Change 323404 had a related patch set uploaded (by Jakob): Integrate ForeignEntityValidator with ValidatorBuilders. https://gerrit.wikimedia.org/r/323404TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-17 Thread gerritbot
gerritbot added a comment. Change 322093 had a related patch set uploaded (by Jakob): Add ForeignEntityValidator. https://gerrit.wikimedia.org/r/322093TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-17 Thread WMDE-leszek
WMDE-leszek added a comment. Good point. I think there should be a per-repo setting saying what entity types are enabled/relevant etc when using this particular repo. BTW I haven't really thought much on how those settings should be configured but I believe for now the current format would still

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-17 Thread Jakob_WMDE
Jakob_WMDE added a comment. @daniel ahh right, I'll use the new setting. Thanks! Just to clarify: I was considering entityNamespaces not because I thought it had anything to do with namespaces but because it says in the docs that "Mapping must be done for each type of entity that should be

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-15 Thread daniel
daniel added a comment. @Jakob_WMDE This has nothing to do with namespaces. It's about repository prefixes. We need to have a list of supported foreign repositories somewhere. Leszek introduced a foreignRepository setting in I618b127, I suggest to use that for the validator too.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T150655: Validator for EntityId should check that foreign repo prefix is known

2016-11-15 Thread Jakob_WMDE
Jakob_WMDE added a comment. that foreign repo is enabled for the given entity type How is this supposed to be done? By checking the repo specific entityNamespaces?TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL