gerritbot added a comment.
Change 323404 merged by jenkins-bot:
Integrate ForeignEntityValidator with ValidatorBuilders.
https://gerrit.wikimedia.org/r/323404TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 322093 merged by jenkins-bot:
Add ForeignEntityValidator.
https://gerrit.wikimedia.org/r/322093TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc:
gerritbot added a comment.
Change 323404 had a related patch set uploaded (by Jakob):
Integrate ForeignEntityValidator with ValidatorBuilders.
https://gerrit.wikimedia.org/r/323404TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL
gerritbot added a comment.
Change 322093 had a related patch set uploaded (by Jakob):
Add ForeignEntityValidator.
https://gerrit.wikimedia.org/r/322093TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
WMDE-leszek added a comment.
Good point. I think there should be a per-repo setting saying what entity types are enabled/relevant etc when using this particular repo.
BTW I haven't really thought much on how those settings should be configured but I believe for now the current format would still
Jakob_WMDE added a comment.
@daniel ahh right, I'll use the new setting. Thanks!
Just to clarify: I was considering entityNamespaces not because I thought it had anything to do with namespaces but because it says in the docs that "Mapping must be done for each type of entity that should be
daniel added a comment.
@Jakob_WMDE This has nothing to do with namespaces. It's about repository prefixes.
We need to have a list of supported foreign repositories somewhere. Leszek introduced a foreignRepository setting in I618b127, I suggest to use that for the validator too.TASK
Jakob_WMDE added a comment.
that foreign repo is enabled for the given entity type
How is this supposed to be done? By checking the repo specific entityNamespaces?TASK DETAILhttps://phabricator.wikimedia.org/T150655EMAIL