gerritbot added a comment.
Change 322254 merged by jenkins-bot:
Expose the name of the repository on which TermSearchResult was found
https://gerrit.wikimedia.org/r/322254TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL
gerritbot added a comment.
Change 322118 merged by jenkins-bot:
Add DispatchingTermSearchInteractor
https://gerrit.wikimedia.org/r/322118TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek,
daniel added a comment.
Most of this is done now. I'm wondering whether we want to explicitly expose the repo on which a match was found via the wbsearchentities API module. It's implicit in the entity IDs, but the client should not need to decode the IDs in order to indicate where a match was
gerritbot added a comment.
Change 322254 had a related patch set uploaded (by WMDE-leszek):
Expose the name of the repository on which TermSearchResult was found
https://gerrit.wikimedia.org/r/322254TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL
WMDE-leszek added a comment.
Regarding this part:
Eventually, TermSearchResults should get a new field identifying the repository on which a match was found.
If I get it right, it could already be fetched from the matched entity id. It makes sense to expose the repository name, and would be easy
gerritbot added a comment.
Change 322118 had a related patch set uploaded (by WMDE-leszek):
Add DispatchingTermSearchInteractor
https://gerrit.wikimedia.org/r/322118TASK DETAILhttps://phabricator.wikimedia.org/T150848EMAIL
