Lucas_Werkmeister_WMDE added a comment.
Apparently, for external identifiers the “publish” link becomes disabled at a length of 4592 characters, and for monolingual text, at 4566 characters. (Tested with strings of x characters, generated via printf '%*s' 4566 | tr ' ' 'x' | xclip, and using the
gerritbot added a comment.
Change 478928 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add parameter type assertions to StringLengthValidator
https://gerrit.wikimedia.org/r/478928TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 478928 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add parameter type assertions to StringLengthValidator
https://gerrit.wikimedia.org/r/478928TASK
gerritbot added a comment.
Change 478678 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix configuration of max string length
https://gerrit.wikimedia.org/r/478678TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 478678 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix configuration of max string length
https://gerrit.wikimedia.org/r/478678TASK
Lucas_Werkmeister_WMDE added a comment.
Um, actually, way longer strings are apparently still permitted…?TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, Lucas_Werkmeister_WMDECc: Lea_Lacroix_WMDE,
Lucas_Werkmeister_WMDE added a comment.
I believe it’s 1500 characters (example edit), for monolingual text, strings, and URLs.TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,
Lea_Lacroix_WMDE added a comment.
@Tarrow Could you give me an update on this? Is it already deployed, what's the final max length? Thanks :)TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,
Addshore added a comment.
beta commons was fixed with https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/473814/ and https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/473816/TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 473815 abandoned by Tarrow:
Don't set Wikibase StringLengths on Commons
Reason:
addshore beat me
https://gerrit.wikimedia.org/r/473815TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 473815 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[operations/mediawiki-config@master] Don't set Wikibase StringLengths on Commons
https://gerrit.wikimedia.org/r/473815TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-11-15T12:30:45Z] Synchronized wmf-config/Wikibase.php: [[gerrit:473716]] Read WikibaseStringLimit in Wikibase.php T154660 (duration: 00m 53s)TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 473716 merged by jenkins-bot:
[operations/mediawiki-config@master] Read WikibaseStringLimit in Wikibase.php
https://gerrit.wikimedia.org/r/473716TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-11-15T12:21:29Z] Synchronized wmf-config/InitialiseSettings.php: [[gerrit:473694]] Set Wikibase string-limits for wikidata dblist T154660 (duration: 00m 54s)TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 473694 merged by jenkins-bot:
[operations/mediawiki-config@master] Set Wikibase string-limits for wikidata dblist
https://gerrit.wikimedia.org/r/473694TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 473716 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[operations/mediawiki-config@master] Read WikibaseStringLimit in Wikibase.php
https://gerrit.wikimedia.org/r/473716TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
gerritbot added a comment.
Change 473694 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[operations/mediawiki-config@master] Set Wikibase string-limits
https://gerrit.wikimedia.org/r/473694TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
Jheald added a comment.
The 400 character limit can also be a problem for the titles of old books, maps, etc -- the original titles of these, as given eg in library catalogues, can get pretty long.TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
Pasleim added a comment.
The length limit does also affect the migration of constraints from property talk pages to statements on properties. ISBN-13 has a format _expression_ which is 481 characters long and therefore can't be added to the property page.TASK
Sebotic added a comment.
@thiemowmde agreed, it would bring down the error rate for this specific identifier/string. But currently, that's the only one we have a size distribution for. I think, Lydia intended to solve this issue here for every property of data type string. So, if for technical
EgonWillighagen added a comment.
I am not sure how much we should worry about the exact percentages for PubChem; to me, more important is are the percentages of the chemistry we have in Wikidata. These are likely correlated, and since PubChem is a lot bigger puts things in perspective. InChIs are
thiemowmde added a comment.
Again, how are almost 100% "not much", compared to the 99% we have now? This is a huge difference. It will decrease the error rate by a factor of 10.
I don't believe that increasing the limit to 2000 would make any difference. The next day somebody will come and ask
daniel added a comment.
@thiemowmde based on your numbers, we are talking about a 1% improvement. If we could get to the full 100%, we would no longer have to account for the failure case. But if we still have to account for that case anyway, going from 99% to 99.9% doesn't really gain us
thiemowmde added a comment.
I don't get that. o_O Increasing the limit to 768 will cover almost 1% more in addition to the 99% we have now. How are these almost 100% "not worth the effort"?TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
EgonWillighagen added a comment.
The InChI is not the only use case for chemistry, btw. SMILES also runs into the char limit right now for a number of compounds.TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
Sebotic added a comment.
Thanks Lydia!
For the InChI example above, 4000 should be fine, question is what other properties outside my expertise would need more than 4000 chars.
Best,
SebastianTASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
Sadads added a comment.
Does this run into some of the same problems as https://meta.wikimedia.org/wiki/Community_Tech/Edit_summary_length_for_non-Latin_languages ?TASK DETAILhttps://phabricator.wikimedia.org/T154660EMAIL
27 matches
Mail list logo
