[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. The fix is live on Wikidata now! \o/TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Tarrow, Addshore, Lucas_Werkmeister_WMDE, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-08 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Assuming nothing goes wrong, this should be deployed to Wikidata in two weeks. It’s also live on Beta (though you might need to purge some JS caches; I tested it successfully with ?debug=true in the URL, but that only works reliably in Chromium), if you want

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-08 Thread gerritbot
gerritbot added a comment. Change 472238 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add test for adding statement via keyboard https://gerrit.wikimedia.org/r/472238TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-08 Thread gerritbot
gerritbot added a comment. Change 472208 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don’t always save statement when enter is pressed inside https://gerrit.wikimedia.org/r/472208TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-07 Thread gerritbot
gerritbot added a comment. Change 472238 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] WIP: add test for editing qualifiers via keyboard https://gerrit.wikimedia.org/r/472238TASK

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-07 Thread gerritbot
gerritbot added a comment. Change 472208 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Don’t always save statement when enter is pressed inside https://gerrit.wikimedia.org/r/472208TASK

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-07 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Would it be possible to check which type of HTML element is focused? We want pressing enter to save in an input field and trigger the corresponding action on links. The only link which should save a statement when pressing enter is the save link itself.

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-07 Thread Nikki
Nikki added a comment. Would it be possible to check which type of HTML element is focused? We want pressing enter to save in an input field and trigger the corresponding action on links. The only link which should save a statement when pressing enter is the save link itself. I do wonder what

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-11-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I tried it in private Firefox and Chromium windows, and while I feel like the issue occurs slightly less frequently than before, it’s definitely not fixed. But the funny part is, on my local wiki I can now reproduce the bug again as well… so at least we

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-10-20 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. I just tried it again on the item linked in the description and it still doesn't work. This doesn't seem like a caching issue to me. Browser specific? I'm using Chromium to test.TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-10-16 Thread Tarrow
Tarrow added a comment. I just tried both test and wikidata.org and the patch works as expected for me. Perhaps it is some caching issue?TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-10-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Hm, this isn’t working yet on Wikidata (test and real) even though it’s deployed on both as far as I can tell :/TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-10-02 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Yes, and it should be on test.wikidata.org by tonight, as far as I understand.TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-09-26 Thread gerritbot
gerritbot added a comment. Change 462914 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix keyboard navigation when editing statements https://gerrit.wikimedia.org/r/462914TASK DETAILhttps://phabricator.wikimedia.org/T154869EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T154869: Adding/removing qualifier/reference using the keyboard (by pressing enter) saves the statement too

2018-09-26 Thread gerritbot
gerritbot added a comment. Change 462914 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Fix keyboard navigation when editing statements https://gerrit.wikimedia.org/r/462914TASK