[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

daniel added a comment. It seems like all essential patches are merged. Can this be closed now? TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Demian, Jdforrester-WMF, kostajh,

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

gerritbot added a comment. Change 511778 abandoned by Daniel Kinzler: [DNM] Register schema updates as callbacks during DatabaseUpdater construction Reason: Superceeded by I84f5fe6836a89352c3ff19c9a985ca359a5bf74d https://gerrit.wikimedia.org/r/511778 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

gerritbot added a comment. Change 587213 **merged** by jenkins-bot: [mediawiki/core@master] DatabaseUpdate: warn extensions about direct modification https://gerrit.wikimedia.org/r/587213 TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

aaron added a comment. In T157651#6039302 , @Tgr wrote: > I would suggest the opposite: keep `sql.php`, drop `patchSql.php`. I don't think many people are familiar with the latter (compare patchSql

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

gerritbot added a comment. Change 587389 **merged** by jenkins-bot: [mediawiki/core@master] Revert "maintenance: Remove sql.php temporarily" https://gerrit.wikimedia.org/r/587389 TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

gerritbot added a comment. Change 587389 had a related patch set uploaded (by Krinkle; owner: Tim Starling): [mediawiki/core@master] Revert "maintenance: Remove sql.php temporarily" https://gerrit.wikimedia.org/r/587389 TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

Krinkle added a comment. As said, I don't mind keeping `sql.php` as a cross-rdbms debug tool if there's interest for that. However, I think use in production is problematic and should not be allowed for the same reason that `echo | mwscript eval.php` shouldn't be used as part of

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

Jdforrester-WMF added a comment. In T157651#6037432 , @Krinkle wrote: > I suggest that we: > > - Keep `patchSql.php` and to the extent not already the case make it only support running queries from a patch file (not arbitrary

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

Krinkle added a comment. In T157651#6035533 , @daniel wrote: > Looking at the code, there seems to be a whole set of dubious things going on which all together caused the disaster above > > - … > - the only thing this does is add

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

Ladsgroup added a comment. In T157651#6035601 , @daniel wrote: > Tagging #wikidata-campsite for the issues with the wikibase schema updater. I think this task will