gerritbot added a comment.
Change 345419 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Don't attempt to index invalid coordinates
https://gerrit.wikimedia.org/r/345419TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL
gerritbot added a comment.
Change 345419 had a related patch set uploaded (by MaxSem):
[mediawiki/extensions/GeoData@master] Don't attempt to index invalid coordinates
https://gerrit.wikimedia.org/r/345419TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL
EBernhardson added a comment.
IMO appropriate fix is probably in GeoData, it needs to not provide coordinates for elasticsearch to index if they don't validate.TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
daniel added a comment.
Could GeoData "wrap" the coordinates into the range of -180..+180 before exposing them to elastic?TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Smalyshev, Deskana,
thiemowmde added a comment.
Ok. And where are we going to fix this? I would not like to add special case handling to Wikibase. I believe it should be GeoData, or whatever code actually puts this into Cirrus. It should check the Coords it gets (they include the globe, and GeoData supports more than
EBernhardson added a comment.
The indexing failure comes from elasticsearch itself, elasticsearch will only accept geocoordinates that have valid coordinates on an earth globe. it rejects any create/update request to a document that includes a coordinate outside the -180 to 180TASK
daniel added a comment.
@thiemowmde thanks for checking this out. Strange issue. Not sure how to find the problem.TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Smalyshev, Deskana,
thiemowmde added a comment.
FYI, I tried to add an extreme value to the GeoDataDataUpdaterTest in Wikibase, but all code this test triggers (which includes parts of #geodata, including its Coord constructor) succeeds just fine.TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL
Deskana added a comment.
In T160140#3127645, @thiemowmde wrote:
There is way to much essential information missing here: Steps to reproduce, what "search" the ticket is referring to, what information is provided to said search (e.g. via an example URL), what "failures" appear, and where they
thiemowmde added a comment.
There is way to much essential information missing here: Steps to reproduce, what "search" the ticket is referring to, what information is provided to said search (e.g. via an example URL), what "failures" appear, and where they appear. Currently the ticket jumps
Deskana added a comment.
This problem means that these pages with invalid coordinates are not indexed and will never show up in search. I am confused why this is a lowest priority issue for Wikidata. Can someone explain? :-)TASK DETAILhttps://phabricator.wikimedia.org/T160140EMAIL
MaxSem added a comment.
GeoData does validate coordinates provided to it the standard way - via the parser function. WD adds its data later, when GD assumes it doesn't need any validation. I guess I can add optional validation to CoordinatesOutput but WD would need to handle exceptions I'll be
12 matches
Mail list logo
