Sjoerddebruin added a comment.
In T161367#3898939, @Infovarius wrote:
Button "publish" isn't localized to Russian in Wikidata...
It was translated on the 4th of January, so it would be live since last Thursday. The MediaWiki update was rolled back due to issues though.TASK
Infovarius added a comment.
Button "publish" isn't localized to Russian in Wikidata...TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, InfovariusCc: Infovarius, Mbch331, Sjoerddebruin, gerritbot,
Lucas_Werkmeister_WMDE added a comment.
and didn't need to change nl.json, but only edit the text in the browser inspector
that’s what I did as well, I just meant – I don’t speak Dutch, so I had to look up the Dutch translation of “save” in nl.json :)TASK
Mbch331 added a comment.
I've tested it too (and didn't need to change nl.json, but only edit the text in the browser inspector)
Current situation:
F12246415: afbeelding.png
Old situation:
F12246422: afbeelding.png
For my screen the current situation just fits and the old situation had some spare
Lucas_Werkmeister_WMDE added a comment.
It looks like this could have been a problem even with the old label? If I change the text to wikibase-save from nl.json, it looks like this:
F12245755: Screenshot-2018-1-4 Wikidata-zandbak.png
But perhaps my font setup is different and on your system that
Sjoerddebruin added a comment.
This seems to be creating issues in the UI for languages that require more space:
F12245674: Schermafdruk 2018-01-04 17.33.33.pngTASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL
Lea_Lacroix_WMDE added a comment.
OK, my fault, sorry :)) Everything's fine.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lea_Lacroix_WMDECc: gerritbot, Elitre, Lea_Lacroix_WMDE, Ladsgroup,
Ladsgroup added a comment.
It shows publish to me (Tested on https://www.wikidata.org/wiki/Q27955144)TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, Elitre, Lea_Lacroix_WMDE,
Lea_Lacroix_WMDE added a comment.
The change is not displayed on Wikidata.org yet. Did anything happen?TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lea_Lacroix_WMDECc: gerritbot, Elitre,
Lea_Lacroix_WMDE added a comment.
@Elitre Yes, it's good. We'll continue monitoring carefully after the change is deployed, because this is when people will start noticing it.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL
Elitre added a comment.
I don't see any feedback in the location you linked, so I'm assuming all's good for tomorrow.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, ElitreCc: gerritbot, Elitre,
Lea_Lacroix_WMDE added a comment.
Announcement is done. Deployment is expected on January 3rd.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lea_Lacroix_WMDECc: gerritbot, Elitre,
Lea_Lacroix_WMDE added a comment.
It will be deployed live on January 3rd. I'll take care of the announcement on December 28th. I expect some negative feedback on this, so we should be extra careful.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL
gerritbot added a comment.
Change 399409 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove unused …-inprogress messages from $.wikibase.edittoolbar
https://gerrit.wikimedia.org/r/399409TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL
gerritbot added a comment.
Change 399409 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove unused …-inprogress messages from $.wikibase.edittoolbar
https://gerrit.wikimedia.org/r/399409TASK
gerritbot added a comment.
Change 399236 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Change label of save edit to publish if wgEditSubmitButtonLabelPublish is true
https://gerrit.wikimedia.org/r/399236TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL
gerritbot added a comment.
Change 399236 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Change label of save edit to publish if wgEditSubmitButtonLabelPublish is true
https://gerrit.wikimedia.org/r/399236TASK
Jdforrester-WMF added a comment.
Exactly. Also I'm sure there'll be documentation to update etc.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMFCc: Lydia_Pintscher, Lucas_Werkmeister_WMDE,
Jan_Dittrich added a comment.
@Jdforrester-WMF : you mean this, I assume?
F11782073: image.png
If yes, I see no problem in the change itself, but rather in some (If I remember it right) brittle UI around that link.TASK DETAILhttps://phabricator.wikimedia.org/T161367EMAIL
19 matches
Mail list logo